Skip to content

Commit 0fccbf4

Browse files
[CHA-0] Fix QueryReminders to properly encode empty filter as JSON object (#152)
* feat: fixed filter param * feat: updated test * feat: Fix QueryReminders to cast empty filter array to object for proper JSON encoding * feat: Remove trailing whitespace in queryReminders
1 parent 3fbb567 commit 0fccbf4

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

lib/GetStream/StreamChat/Client.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1721,8 +1721,10 @@ public function deleteReminder(string $messageId, string $userId): StreamRespons
17211721
*/
17221722
public function queryReminders(string $userId, array $filterConditions = [], ?array $sort = null, array $options = []): StreamResponse
17231723
{
1724+
$filter = !empty($filterConditions) ? $filterConditions : (object)[];
1725+
17241726
$params = array_merge($options, [
1725-
'filter_conditions' => $filterConditions,
1727+
'filter' => $filter,
17261728
'sort' => $sort ?? [['field' => 'remind_at', 'direction' => 1]],
17271729
'user_id' => $userId
17281730
]);

tests/integration/ReminderTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ protected function setUp(): void
4949
$message = [
5050
'text' => 'This is a test message for reminders'
5151
];
52-
$response = $this->channel->sendMessage($message, $this->user['id']);
52+
$response = $this->channel->sendMessage($message, $this->user['id']); // message id 1
53+
$response = $this->channel->sendMessage($message, $this->user['id']); // message id 2
5354
$this->messageId = $response['message']['id'];
5455
}
5556

0 commit comments

Comments
 (0)