Skip to content

Commit b97a007

Browse files
authored
feat: drop php 7.3 support (#99)
1 parent d7d428f commit b97a007

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
strategy:
1414
max-parallel: 1
1515
matrix:
16-
php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2']
16+
php-versions: ['7.4', '8.0', '8.1', '8.2']
1717
steps:
1818
- name: Checkout
1919
uses: actions/checkout@v3
2020
with:
2121
fetch-depth: 0 # gives the commit message linter access to all previous commits
2222

2323
- name: Commit lint
24-
if: ${{ matrix.php-versions == '7.3' }}
24+
if: ${{ matrix.php-versions == '7.4' }}
2525
uses: wagoid/commitlint-github-action@v4
2626

2727
- name: Setup PHP
@@ -36,11 +36,11 @@ jobs:
3636
run: composer install
3737

3838
- name: Format
39-
if: ${{ matrix.php-versions == '7.3' }}
39+
if: ${{ matrix.php-versions == '7.4' }}
4040
run: vendor/bin/php-cs-fixer fix -v --dry-run --stop-on-violation
4141

4242
- name: Quality
43-
if: ${{ matrix.php-versions == '7.3' }}
43+
if: ${{ matrix.php-versions == '7.4' }}
4444
run: vendor/bin/phan --no-progress-bar
4545

4646
- name: Test

.phan/config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// that functions removed in php 7.0 exist.
1717
// (See `backward_compatibility_checks` for additional options)
1818
// TODO: Set this.
19-
'minimum_target_php_version' => '7.3',
19+
'minimum_target_php_version' => '7.4',
2020

2121
'plugins' => [
2222
'AlwaysReturnPlugin',

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"docs": "https://getstream.io/chat/docs/php/?language=php"
2121
},
2222
"require": {
23-
"php": ">=7.3",
23+
"php": ">=7.4",
2424
"guzzlehttp/guzzle": "^6.5.8 || ^7.0.1"
2525
},
2626
"require-dev": {

lib/GetStream/StreamChat/StreamResponse.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ public function __construct(array $array, ResponseInterface $response)
3333
parent::__construct($array);
3434

3535
if (
36-
$response->hasHeader("x-ratelimit-limit")
37-
&& $response->hasHeader("x-ratelimit-remaining")
38-
&& $response->hasHeader("x-ratelimit-reset")
39-
) {
36+
$response->hasHeader("x-ratelimit-limit")
37+
&& $response->hasHeader("x-ratelimit-remaining")
38+
&& $response->hasHeader("x-ratelimit-reset")
39+
) {
4040
$this->rateLimits = new StreamRateLimit(
4141
$response->getHeader("x-ratelimit-limit")[0],
4242
$response->getHeader("x-ratelimit-remaining")[0],

0 commit comments

Comments
 (0)