Skip to content

Commit b7f94f6

Browse files
author
Daksh
committed
fix linter issues
1 parent 3c99d52 commit b7f94f6

File tree

5 files changed

+27
-44
lines changed

5 files changed

+27
-44
lines changed

stream_chat/async_chat/client.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -355,15 +355,13 @@ async def update_message_partial(
355355
data.update(options)
356356
return await self.put(f"messages/{message_id}", data=data)
357357

358-
async def delete_message(self, message_id: str, delete_for_me: bool = False, deleted_by: str = None, **options: Any) -> StreamResponse:
359-
if delete_for_me and not deleted_by:
360-
raise ValueError("deleted_by is required when delete_for_me is True")
361-
358+
async def delete_message(
359+
self, message_id: str, deleted_by: str = None, **options: Any
360+
) -> StreamResponse:
362361
data = options.copy()
363-
if delete_for_me:
364-
data["delete_for_me"] = True
362+
if deleted_by:
365363
data["deleted_by"] = deleted_by
366-
364+
367365
return await self.delete(f"messages/{message_id}", data)
368366

369367
async def undelete_message(self, message_id: str, user_id: str) -> StreamResponse:

stream_chat/base/client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -560,15 +560,14 @@ def update_message_partial(
560560

561561
@abc.abstractmethod
562562
def delete_message(
563-
self, message_id: str, delete_for_me: bool = False, deleted_by: str = None, **options: Any
563+
self, message_id: str, deleted_by: str = None, **options: Any
564564
) -> Union[StreamResponse, Awaitable[StreamResponse]]:
565565
"""
566566
Deletes a message.
567-
567+
568568
Args:
569569
message_id: The ID of the message to delete
570-
delete_for_me: If True, deletes the message only for the specified user
571-
deleted_by: The user ID who is deleting the message (required when delete_for_me is True)
570+
deleted_by: The user ID who is deleting the message
572571
**options: Additional options to pass to the delete request
573572
"""
574573
pass

stream_chat/client.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,13 @@ def update_message_partial(
342342
data.update(options)
343343
return self.put(f"messages/{message_id}", data=data)
344344

345-
def delete_message(self, message_id: str, delete_for_me: bool = False, deleted_by: str = None, **options: Any) -> StreamResponse:
346-
if delete_for_me and not deleted_by:
347-
raise ValueError("deleted_by is required when delete_for_me is True")
348-
345+
def delete_message(
346+
self, message_id: str, deleted_by: str = None, **options: Any
347+
) -> StreamResponse:
349348
data = options.copy()
350-
if delete_for_me:
351-
data["delete_for_me"] = True
349+
if deleted_by:
352350
data["deleted_by"] = deleted_by
353-
351+
354352
return self.delete(f"messages/{message_id}", data)
355353

356354
def undelete_message(self, message_id: str, user_id: str) -> StreamResponse:

stream_chat/tests/async_chat/test_client.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -462,27 +462,20 @@ async def test_delete_message(
462462
)
463463
await client.delete_message(msg_id, hard=True)
464464

465-
async def test_delete_message_for_me(
465+
async def test_delete_message_with_deleted_by(
466466
self, client: StreamChatAsync, channel: Channel, random_user: Dict
467467
):
468-
"""Test deleting a message for a specific user (delete for me functionality)"""
468+
"""Test deleting a message with deleted_by parameter"""
469469
msg_id = str(uuid.uuid4())
470470
await channel.send_message(
471471
{"id": msg_id, "text": "helloworld"}, random_user["id"]
472472
)
473-
474-
# Delete message for the user
475-
response = await client.delete_message(
476-
msg_id,
477-
delete_for_me=True,
478-
deleted_by=random_user["id"]
479-
)
480-
473+
474+
# Delete message with deleted_by parameter
475+
response = await client.delete_message(msg_id, deleted_by=random_user["id"])
476+
481477
# Verify the request succeeded
482478
assert response.is_ok()
483-
484-
# Verify the message is still visible to other users but deleted for the specified user
485-
# (This would require additional API calls to verify, but we're just testing the request succeeds)
486479

487480
async def test_flag_message(
488481
self, client: StreamChatAsync, channel: Channel, random_user, server_user: Dict

stream_chat/tests/test_client.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -509,23 +509,18 @@ def test_delete_message(self, client: StreamChat, channel, random_user: Dict):
509509
channel.send_message({"id": msg_id, "text": "helloworld"}, random_user["id"])
510510
client.delete_message(msg_id, hard=True)
511511

512-
def test_delete_message_for_me(self, client: StreamChat, channel, random_user: Dict):
513-
"""Test deleting a message for a specific user (delete for me functionality)"""
512+
def test_delete_message_with_deleted_by(
513+
self, client: StreamChat, channel, random_user: Dict
514+
):
515+
"""Test deleting a message with deleted_by parameter"""
514516
msg_id = str(uuid.uuid4())
515517
channel.send_message({"id": msg_id, "text": "helloworld"}, random_user["id"])
516-
517-
# Delete message for the user
518-
response = client.delete_message(
519-
msg_id,
520-
delete_for_me=True,
521-
deleted_by=random_user["id"]
522-
)
523-
518+
519+
# Delete message with deleted_by parameter
520+
response = client.delete_message(msg_id, deleted_by=random_user["id"])
521+
524522
# Verify the request succeeded
525523
assert response.is_ok()
526-
527-
# Verify the message is still visible to other users but deleted for the specified user
528-
# (This would require additional API calls to verify, but we're just testing the request succeeds)
529524

530525
def test_flag_message(
531526
self, client: StreamChat, channel, random_user, server_user: Dict

0 commit comments

Comments
 (0)