fix: prefer local uri when sharing if there (#3118)

* fix: prefer local uri when sharing if there

* fix: failing tests and add new ones

Author: isekovanic

package/src/components/ImageGallery/__tests__/ImageGalleryFooter.test.tsx

@@ -159,21 +159,115 @@ describe('ImageGalleryFooter', () => {
     });
   });
 
-  it('should trigger the share button onPress Handler', async () => {
+  it('should trigger the share button onPress Handler with local attachment and no mime_type', async () => {
     const user = userEvent.setup();
     const chatClient = await getTestClientWithUser({ id: 'testID' });
     const saveFileMock = jest.spyOn(NativeHandlers, 'saveFile');
     const shareImageMock = jest.spyOn(NativeHandlers, 'shareImage');
     const deleteFileMock = jest.spyOn(NativeHandlers, 'deleteFile');
 
+    const attachment = generateImageAttachment();
+
+    render(
+      <OverlayProvider>
+        <ImageGalleryContext.Provider
+          value={
+            {
+              messages: [
+                generateMessage({
+                  attachments: [attachment],
+                }),
+              ] as unknown as LocalMessage[],
+            } as unknown as ImageGalleryContextValue
+          }
+        >
+          <Chat client={chatClient}>
+            <ImageGallery overlayOpacity={{ value: 1 } as SharedValue<number>} />
+          </Chat>
+        </ImageGalleryContext.Provider>
+      </OverlayProvider>,
+    );
+
+    await waitFor(() => {
+      user.press(screen.queryByLabelText('Share Button') as ReactTestInstance);
+    });
+
+    await waitFor(() => {
+      expect(saveFileMock).not.toHaveBeenCalled();
+      expect(shareImageMock).toHaveBeenCalledWith({
+        type: 'image/jpeg',
+        url: attachment.image_url,
+      });
+      expect(deleteFileMock).not.toHaveBeenCalled();
+    });
+  });
+
+  it('should trigger the share button onPress Handler with local attachment and existing mime_type', async () => {
+    const user = userEvent.setup();
+    const chatClient = await getTestClientWithUser({ id: 'testID' });
+    const saveFileMock = jest.spyOn(NativeHandlers, 'saveFile');
+    const shareImageMock = jest.spyOn(NativeHandlers, 'shareImage');
+    const deleteFileMock = jest.spyOn(NativeHandlers, 'deleteFile');
+
+    const attachment = { ...generateImageAttachment(), mime_type: 'image/png' };
+
+    render(
+      <OverlayProvider>
+        <ImageGalleryContext.Provider
+          value={
+            {
+              messages: [
+                generateMessage({
+                  attachments: [attachment],
+                }),
+              ] as unknown as LocalMessage[],
+            } as unknown as ImageGalleryContextValue
+          }
+        >
+          <Chat client={chatClient}>
+            <ImageGallery overlayOpacity={{ value: 1 } as SharedValue<number>} />
+          </Chat>
+        </ImageGalleryContext.Provider>
+      </OverlayProvider>,
+    );
+
+    await waitFor(() => {
+      user.press(screen.queryByLabelText('Share Button') as ReactTestInstance);
+    });
+
+    await waitFor(() => {
+      expect(saveFileMock).not.toHaveBeenCalled();
+      expect(shareImageMock).toHaveBeenCalledWith({
+        type: 'image/png',
+        url: attachment.image_url,
+      });
+      expect(deleteFileMock).not.toHaveBeenCalled();
+    });
+  });
+
+  it('should trigger the share button onPress Handler with cdn attachment', async () => {
+    const user = userEvent.setup();
+    const chatClient = await getTestClientWithUser({ id: 'testID' });
+    const saveFileMock = jest
+      .spyOn(NativeHandlers, 'saveFile')
+      .mockResolvedValue('file:///local/asset/url');
+    const shareImageMock = jest.spyOn(NativeHandlers, 'shareImage');
+    const deleteFileMock = jest.spyOn(NativeHandlers, 'deleteFile');
+
+    const attachment = {
+      ...generateImageAttachment(),
+      image_url: 'https://my-image-service/image/123456',
+      mime_type: 'image/png',
+    };
+
     render(
       <OverlayProvider>
         <ImageGalleryContext.Provider
           value={
             {
               messages: [
                 generateMessage({
-                  attachments: [generateImageAttachment()],
+                  attachments: [attachment],
                 }),
               ] as unknown as LocalMessage[],
             } as unknown as ImageGalleryContextValue
@@ -192,7 +286,10 @@ describe('ImageGalleryFooter', () => {
 
     await waitFor(() => {
       expect(saveFileMock).toHaveBeenCalled();
-      expect(shareImageMock).toHaveBeenCalled();
+      expect(shareImageMock).toHaveBeenCalledWith({
+        type: 'image/png',
+        url: 'file:///local/asset/url',
+      });
       expect(deleteFileMock).toHaveBeenCalled();
     });
   });

package/src/components/ImageGallery/components/ImageGalleryFooter.tsx

@@ -142,17 +142,29 @@ export const ImageGalleryFooterWithContext = (props: ImageGalleryFooterPropsWith
         return;
       }
       const extension = photo.mime_type?.split('/')[1] || 'jpg';
-      setSavingInProgress(true);
-      const localFile = await NativeHandlers.saveFile({
-        fileName: `${photo.user?.id || 'ChatPhoto'}-${
-          photo.messageId
-        }-${selectedIndex}.${extension}`,
-        fromUrl: photo.uri,
-      });
-      setSavingInProgress(false);
+      const shouldDownload = photo.uri && photo.uri.includes('http');
+      let localFile;
+      // If the file is already uploaded to a CDN, create a local reference to
+      // it first; otherwise just use the local file
+      if (shouldDownload) {
+        setSavingInProgress(true);
+        localFile = await NativeHandlers.saveFile({
+          fileName: `${photo.user?.id || 'ChatPhoto'}-${
+            photo.messageId
+          }-${selectedIndex}.${extension}`,
+          fromUrl: photo.uri,
+        });
+        setSavingInProgress(false);
+      } else {
+        localFile = photo.uri;
+      }
+
       // `image/jpeg` is added for the case where the mime_type isn't available for a file/image
       await NativeHandlers.shareImage({ type: photo.mime_type || 'image/jpeg', url: localFile });
-      await NativeHandlers.deleteFile({ uri: localFile });
+      // Only delete the file if a local reference has been created beforehand
+      if (shouldDownload) {
+        await NativeHandlers.deleteFile({ uri: localFile });
+      }
     } catch (error) {
       setSavingInProgress(false);
       console.log(error);