early return of nonSelfUsers in order to avoid too much optional chaining on filterTypingUsers

Author: tsirlucas

src/components/MessageList/utils/filterTypingUsers.ts

@@ -1,6 +1,6 @@
 import type { ChatContextValue } from '../../../contexts/chatContext/ChatContext';
-import type { TypingContextValue } from '../../../contexts/typingContext/TypingContext';
 import type { ThreadContextValue } from '../../../contexts/threadContext/ThreadContext';
+import type { TypingContextValue } from '../../../contexts/typingContext/TypingContext';
 import type {
   DefaultAttachmentType,
   DefaultChannelType,
@@ -37,24 +37,29 @@ export const filterTypingUsers = <
   thread,
   typing,
 }: FilterTypingUsersParams<At, Ch, Co, Ev, Me, Re, Us>) => {
-  const typingKeys = Object.keys(typing);
   const nonSelfUsers: string[] = [];
+
+  if (!client || !client.user || !typing) return nonSelfUsers;
+
+  const typingKeys = Object.keys(typing);
+
   typingKeys.forEach((typingKey) => {
-    // removes own typing events
-    if (client?.user?.id === typing?.[typingKey]?.user?.id) {
+    if (!typing[typingKey]) return;
+
+    /** removes own typing events */
+    if (client.user?.id === typing[typingKey].user?.id) {
       return;
     }
 
-    const isRegularEvent = !typing?.[typingKey].parent_id && !thread?.id;
-    const isCurrentThreadEvent = typing?.[typingKey].parent_id === thread?.id;
+    const isRegularEvent = !typing[typingKey].parent_id && !thread?.id;
+    const isCurrentThreadEvent = typing[typingKey].parent_id === thread?.id;
 
-    // filters different threads events
+    /** filters different threads events */
     if (!isRegularEvent && !isCurrentThreadEvent) {
       return;
     }
 
-    const user =
-      typing?.[typingKey]?.user?.name || typing?.[typingKey]?.user?.id;
+    const user = typing[typingKey].user?.name || typing[typingKey].user?.id;
     if (user) {
       nonSelfUsers.push(user);
     }