Skip to content

Commit 40bac0e

Browse files
committed
fix: performance issue with quoted message checks
1 parent f137f01 commit 40bac0e

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

package/src/utils/utils.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -334,15 +334,20 @@ export const checkQuotedMessageEquality = (
334334
prevQuotedMessage?: LocalMessage,
335335
nextQuotedMessage?: LocalMessage,
336336
): boolean => {
337-
if (!prevQuotedMessage || !nextQuotedMessage) {
337+
const prevQuotedMessageExists = !!prevQuotedMessage;
338+
const nextQuotedMessageExists = !!nextQuotedMessage;
339+
if (!prevQuotedMessageExists && !nextQuotedMessageExists) {
340+
return true;
341+
}
342+
if (prevQuotedMessageExists !== nextQuotedMessageExists) {
338343
return false;
339344
}
340-
const isPrevQuotedMessageTypeDeleted = prevQuotedMessage.type === 'deleted';
341-
const isNextQuotedMessageTypeDeleted = nextQuotedMessage.type === 'deleted';
345+
const isPrevQuotedMessageTypeDeleted = prevQuotedMessage?.type === 'deleted';
346+
const isNextQuotedMessageTypeDeleted = nextQuotedMessage?.type === 'deleted';
342347
const quotedMessageEqual =
343348
isPrevQuotedMessageTypeDeleted === isNextQuotedMessageTypeDeleted &&
344-
prevQuotedMessage.type === nextQuotedMessage.type &&
345-
prevQuotedMessage.text === nextQuotedMessage.text &&
349+
prevQuotedMessage?.type === nextQuotedMessage?.type &&
350+
prevQuotedMessage?.text === nextQuotedMessage?.text &&
346351
`${prevQuotedMessage?.updated_at}` === `${nextQuotedMessage?.updated_at}` &&
347352
`${prevQuotedMessage?.deleted_at}` === `${nextQuotedMessage?.deleted_at}`;
348353

0 commit comments

Comments
 (0)