Skip to content

Commit 4b45d80

Browse files
authored
Merge pull request #1398 from GetStream/steve/sample-app-crashes-blur
fix: solves multiple crashes in the Sample app, that were related to setBlurType
2 parents cbcd50c + e10abfd commit 4b45d80

File tree

8 files changed

+7
-26
lines changed

8 files changed

+7
-26
lines changed

docusaurus/docs/reactnative/common-content/contexts/overlay-context/set_blur_type.mdx

Lines changed: 0 additions & 5 deletions
This file was deleted.

docusaurus/docs/reactnative/common-content/contexts/overlay-context/set_overlay.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Setter for [`overlay`](../../../contexts/overlay_context.mdx#overlay). You can use this setter to show the overlay. Please make sure to explicitely relevant blur background type for overlay by using [`setBlurType`](../../../contexts/overlay_context.mdx#setblurtype).
1+
Setter for [`overlay`](../../../contexts/overlay_context.mdx#overlay). You can use this setter to show the overlay.
22

33
| Type |
44
| ------------------- |

docusaurus/docs/reactnative/contexts/image_gallery_context.mdx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@ You can use this `ImageGalleryContext` in combination with `OverlayContext` to o
3131

3232
```tsx
3333
const { images, setImages } = useImageGalleryContext();
34-
const { setBlurType, setOverlay } = useOverlayContext();
34+
const { setOverlay } = useOverlayContext();
3535

3636
onPress={() => {
3737
setImages(messagesWithImage);
3838
setImage({
3939
messageId: selectedItem.messageId,
4040
url: selectedItem.uri,
4141
});
42-
setBlurType('dark');
4342
setOverlay('gallery');
4443
}}
4544
```

docusaurus/docs/reactnative/contexts/overlay_context.mdx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ id: overlay-context
33
title: OverlayContext
44
---
55

6-
import SetBlurType from '../common-content/contexts/overlay-context/set_blur_type.mdx';
76
import SetOverlay from '../common-content/contexts/overlay-context/set_overlay.mdx';
87

98
`OverlayContext` is provided by [`OverlayProvider`](../core-components/overlay_provider.mdx) component. If you are not familiar with React Context API, please read about it on [React docs](https://reactjs.org/docs/context.html).
@@ -16,15 +15,15 @@ import SetOverlay from '../common-content/contexts/overlay-context/set_overlay.m
1615
import { useContext } from 'react';
1716
import { OverlayContext } from 'stream-chat-react-native';
1817

19-
const { setBlurType, setOverlay } = useContext(OverlayContext);
18+
const { setOverlay } = useContext(OverlayContext);
2019
```
2120

2221
Alternatively, you can also use `useOverlayContext` hook provided by library to consume OverlayContext.
2322

2423
```tsx
2524
import { useOverlayContext } from 'stream-chat-react-native';
2625

27-
const { setBlurType, setOverlay } = useOverlayContext();
26+
const { setOverlay } = useOverlayContext();
2827
```
2928

3029
## Value
@@ -42,10 +41,6 @@ Current active overlay. Overlay gets rendered in following cases
4241
| ------------------------------------------- |
4342
| enum('alert', 'gallery', 'message', 'none') |
4443

45-
### setBlurType
46-
47-
<SetBlurType />
48-
4944
### setOverlay
5045

5146
<SetOverlay />

docusaurus/docs/reactnative/ui-components/gallery.mdx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import OnlyEmojis from '../common-content/contexts/message-context/only_emojis.m
2121
import OtherAttachments from '../common-content/contexts/message-context/other_attachments.mdx';
2222
import ThreadList from '../common-content/contexts/message-context/thread_list.mdx';
2323

24-
import SetBlurType from '../common-content/contexts/overlay-context/set_blur_type.mdx';
2524
import SetOverlay from '../common-content/contexts/overlay-context/set_overlay.mdx';
2625

2726
import AdditionalTouchableProps from '../common-content/core-components/channel/props/additional_touchable_props.mdx';
@@ -105,10 +104,6 @@ If true, onPress handler will be disabled.
105104
| ------- | ------- |
106105
| boolean | false |
107106

108-
### <div class="label description">_overrides the value from [OverlayContext](../contexts/overlay_context.mdx#setblurtype)_</div> setBlurType {#setblurtype}
109-
110-
<SetBlurType />
111-
112107
### <div class="label description">_overrides the value from [ImageGalleryContext](../contexts/image_gallery_context.mdx#setimage)_</div> setImage {#setimage}
113108

114109
<SetImage />

examples/SampleApp/ios/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,4 +848,4 @@ SPEC CHECKSUMS:
848848

849849
PODFILE CHECKSUM: a640bd2ecc4e73329d8379590f3ee5bc09ecba5f
850850

851-
COCOAPODS: 1.11.3
851+
COCOAPODS: 1.11.2

examples/SampleApp/src/screens/ChannelImagesScreen.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export const ChannelImagesScreen: React.FC<ChannelImagesScreenProps> = ({
6767
},
6868
}) => {
6969
const { images, setImage, setImages } = useImageGalleryContext<StreamChatGenerics>();
70-
const { setBlurType, setOverlay } = useOverlayContext();
70+
const { setOverlay } = useOverlayContext();
7171
const { loading, loadMore, messages } = usePaginatedAttachments(channel, 'image');
7272
const {
7373
theme: {
@@ -179,7 +179,6 @@ export const ChannelImagesScreen: React.FC<ChannelImagesScreenProps> = ({
179179
messageId: item.messageId,
180180
url: item.uri,
181181
});
182-
setBlurType('dark');
183182
setOverlay('gallery');
184183
}}
185184
>

examples/SampleApp/src/screens/GroupChannelDetailsScreen.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export const GroupChannelDetailsScreen: React.FC<GroupChannelDetailsProps> = ({
162162
const { setData: setBottomSheetOverlayData } = useBottomSheetOverlayContext();
163163
const { setData: setUserInfoOverlayData } = useUserInfoOverlayContext();
164164
const navigation = useNavigation<GroupChannelDetailsScreenNavigationProp>();
165-
const { setBlurType, setOverlay } = useOverlayContext();
165+
const { setOverlay } = useOverlayContext();
166166
const {
167167
theme: {
168168
colors: { accent_blue, accent_green, black, border, grey, white, white_smoke },
@@ -225,8 +225,6 @@ export const GroupChannelDetailsScreen: React.FC<GroupChannelDetailsProps> = ({
225225
if (chatClient?.user?.id) {
226226
await channel.removeMembers([chatClient?.user?.id]);
227227
}
228-
229-
setBlurType(undefined);
230228
setAppOverlay('none');
231229
setOverlay('none');
232230

0 commit comments

Comments
 (0)