feat: move app settings logic to LLC

Author: isekovanic

package/src/components/Chat/hooks/useAppSettings.ts

@@ -3,7 +3,6 @@ import { useEffect, useState } from 'react';
 import type { AppSettingsAPIResponse, StreamChat } from 'stream-chat';
 
 import { useIsMountedRef } from '../../../hooks/useIsMountedRef';
-import * as dbApi from '../../../store/apis';
 
 export const useAppSettings = (
   client: StreamChat,
@@ -18,70 +17,37 @@ export const useAppSettings = (
     /**
      * Fetches app settings from the backend when offline support is disabled.
      */
-    const enforceAppSettingsWithoutOfflineSupport = async () => {
-      if (!client.userID) {
-        return;
-      }
-
-      try {
-        const appSettings = await client.getAppSettings();
-        if (isMounted.current) {
-          setAppSettings(appSettings);
-        }
-      } catch (error: unknown) {
-        if (error instanceof Error) {
-          console.error(`An error occurred while getting app settings: ${error}`);
-        }
-      }
-    };
 
     /**
      * Fetches app settings from the local database when offline support is enabled if internet is off else fetches from the backend.
      * Note: We need to set the app settings from the local database when offline as the client will not have the app settings in memory. For this we store it for the `client.userID`.
      *
      * TODO: Remove client.userID usage for offline support case.
      */
-    const enforceAppSettingsWithOfflineSupport = async () => {
+
+    async function enforceAppSettings() {
       if (!client.userID) {
         return;
       }
-      if (!initialisedDatabase) {
-        return;
-      }
 
-      if (!isOnline) {
-        const appSettings = await dbApi.getAppSettings({ currentUserId: client.userID });
-        setAppSettings(appSettings);
+      if (enableOfflineSupport && !initialisedDatabase) {
         return;
       }
 
       try {
-        const appSettings = await client.getAppSettings();
+        const appSettings = (await client.getAppSettings()) as AppSettingsAPIResponse;
         if (isMounted.current) {
           setAppSettings(appSettings);
-          await dbApi.upsertAppSettings({
-            appSettings,
-            currentUserId: client.userID as string,
-          });
         }
       } catch (error: unknown) {
         if (error instanceof Error) {
           console.error(`An error occurred while getting app settings: ${error}`);
         }
       }
-    };
-
-    async function enforeAppSettings() {
-      if (enableOfflineSupport) {
-        await enforceAppSettingsWithOfflineSupport();
-      } else {
-        await enforceAppSettingsWithoutOfflineSupport();
-      }
     }
 
-    enforeAppSettings();
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [client, isOnline, initialisedDatabase]);
+    enforceAppSettings();
+  }, [client, isOnline, initialisedDatabase, enableOfflineSupport, isMounted]);
 
   return appSettings;
 };

package/src/store/OfflineDB.ts

@@ -1,4 +1,9 @@
-import { AbstractOfflineDB, StreamChat } from 'stream-chat';
+import {
+  AbstractOfflineDB,
+  GetAppSettingsType,
+  StreamChat,
+  UpsertAppSettingsType,
+} from 'stream-chat';
 import type {
   GetChannelsForQueryType,
   GetChannelsType,
@@ -15,10 +20,21 @@ export class OfflineDB extends AbstractOfflineDB {
   }
 
   upsertCidsForQuery = api.upsertCidsForQuery;
+
   upsertChannels = api.upsertChannels;
+
+  // FIXME
+  upsertUserSyncStatus = ({ userId, lastSyncedAt }: UpsertUserSyncStatusType) =>
+    api.upsertUserSyncStatus({ currentUserId: userId, lastSyncedAt });
+
+  // FIXME
+  upsertAppSettings = ({ appSettings, userId, flush }: UpsertAppSettingsType) =>
+    api.upsertAppSettings({ appSettings, currentUserId: userId, flush });
+
   // FIXME
   getChannels = ({ cids, userId }: GetChannelsType) =>
     api.getChannels({ channelIds: cids, currentUserId: userId });
+
   // FIXME
   getChannelsForQuery = ({ userId, filters, sort }: GetChannelsForQueryType) =>
     api.getChannelsForFilterSort({ currentUserId: userId, filters, sort });
@@ -27,9 +43,9 @@ export class OfflineDB extends AbstractOfflineDB {
   // FIXME
   getLastSyncedAt = ({ userId }: GetLastSyncedAtType) =>
     api.getLastSyncedAt({ currentUserId: userId });
-  // FIXME
-  upsertUserSyncStatus = ({ userId, lastSyncedAt }: UpsertUserSyncStatusType) =>
-    api.upsertUserSyncStatus({ currentUserId: userId, lastSyncedAt });
+
+  getAppSettings = ({ userId }: GetAppSettingsType) =>
+    api.getAppSettings({ currentUserId: userId });
 
   addPendingTask = api.addPendingTask;