Skip to content

Commit 80e54a0

Browse files
committed
fix: makefile was not installing all dependencies by default
also did not force usage of ruby version
1 parent e421464 commit 80e54a0

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

package/Makefile

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,16 @@ LIB_SOURCES = $(wildcard *.js) $(wildcard */*.js) $(wildcard */*.scss) $(wildcar
1818

1919
CHAT_DEPS = ../client/package.json
2020

21+
22+
# By default, we install all dependencies for all the example apps
23+
.DEFAULT_GOAL = all-example-deps
24+
2125
native-example-deps: $(NATIVE_EXAMPLES_APPS_DEPS)
2226
expo-example-deps: $(EXPO_EXAMPLES_APPS_DEPS)
27+
all-example-deps: $(NATIVE_EXAMPLES_APPS_DEPS) $(EXPO_EXAMPLES_APPS_DEPS)
2328

2429
$(NATIVE_EXAMPLES_APPS_DEPS): %/node_modules/installed_dependencies: %/yarn.lock %/package.json $(SOURCES) $(WRAPPER_PACKAGES_DEPS)
25-
cd $* && yarn install && npx pod-install
30+
cd $* && bundle install && yarn install && cd ios && bundle exec pod install
2631
touch $@
2732

2833
$(EXPO_EXAMPLES_APPS_DEPS): %/node_modules/installed_dependencies: %/yarn.lock %/package.json $(SOURCES) $(WRAPPER_PACKAGES_DEPS)
@@ -42,7 +47,8 @@ dist/built: $(LIB_SOURCES) node_modules/installed_dependencies
4247
touch $@ q
4348

4449
clean:
45-
rm -rf $(addsuffix /node_modules,$(EXAMPLES_APPS)) || true
50+
rm -rf $(addsuffix /node_modules,$(NATIVE_EXAMPLES_APPS)) || true
51+
rm -rf $(addsuffix /node_modules,$(EXPO_EXAMPLES_APPS)) || true
4652
rm -rf $(addsuffix /node_modules,$(WRAPPER_PACKAGES)) || true
4753
rm -rf dist || true
4854
rm -rf node_modules || true

0 commit comments

Comments
 (0)