chore: fix all lint issues with new versions and update rules

Author: isekovanic

package/.eslintrc.json

@@ -18,9 +18,7 @@ import tsEslint from 'typescript-eslint';
  * the new config. All globals which were previously set to true are now readonly.
  */
 const reactNativeGlobals = Object.keys(eslintReactNativeConfig.globals).reduce((acc, key) => {
-  if (eslintReactNativeConfig.globals[key]) {
-    acc[key] = 'readonly';
-  }
+  acc[key] = 'readonly';
   return acc;
 }, {});
 
@@ -51,13 +49,11 @@ export default tsEslint.config(
     ],
   },
   {
+    name: 'default',
     files: ['**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx'],
     languageOptions: {
       ecmaVersion: 2020,
-      globals: {
-        ...reactNativeGlobals,
-        console: 'readonly',
-      },
+      globals: reactNativeGlobals,
       parser: tsEslint.parser,
       parserOptions: {
         ecmaFeatures: {
@@ -79,7 +75,6 @@ export default tsEslint.config(
     },
     settings: {
       'import/resolver': {
-        // 'babel-module': {},
         node: {
           extensions: ['.js', '.jsx', '.ts', '.tsx'],
           paths: ['src'],
@@ -163,7 +158,9 @@ export default tsEslint.config(
         'warn',
         { ignoreRestSiblings: false, caughtErrors: 'none' },
       ],
+      '@typescript-eslint/no-unused-expressions': 'off',
       '@typescript-eslint/no-var-requires': 0,
+      '@typescript-eslint/no-require-imports': 'off',
       'react-hooks/exhaustive-deps': 1,
       'react-native/no-inline-styles': 0,
       'babel/no-invalid-this': 0,
@@ -173,20 +170,24 @@ export default tsEslint.config(
   },
   {
     name: 'jest',
-    files: ['src/**/__tests__/**'],
+    files: ['src/**/__tests__/**', '**/*.test.*', 'src/mock-builders/**'],
     plugins: { jest: eslintPluginJest },
     languageOptions: {
-      globals: eslintPluginJest.environments.globals.globals,
+      globals: {
+        ...eslintPluginJest.environments.globals.globals,
+        jest: 'readonly',
+      },
     },
     rules: {
+      'react-hooks/rules-of-hooks': 'off',
       'jest/expect-expect': 'off',
       'jest/no-conditional-expect': 'off',
       'jest/prefer-inline-snapshots': 'off',
       'jest/lowercase-name': 'off',
       'jest/prefer-expect-assertions': 'off',
       'jest/no-hooks': 'off',
       'jest/no-if': 'off',
-      'jest/prefer-spy-on': 'warn',
+      'jest/prefer-spy-on': 'off',
     },
   },
 );

package/eslint.config.mjs

@@ -26,12 +26,12 @@
     "build-translations": "i18next",
     "copy-translations": "echo '\u001b[34mℹ\u001b[0m Copying translation files to \u001b[34mlib/typescript/i18n\u001b[0m' && cp -R -f ./src/i18n ./lib/typescript/i18n && echo '\u001b[32m✓\u001b[0m Done Copying Translations'",
     "eslint": "eslint 'src/**/*.{js,md,ts,jsx,tsx}' --max-warnings 0",
-    "lint": "prettier --ignore-path ../.prettierignore --list-different 'src/**/*.{js,ts,tsx,md,json}' .eslintrc.json ../.prettierrc babel.config.js && eslint 'src/**/*.{js,ts,tsx,md}' --max-warnings 0 && yarn run validate-translations",
-    "lint-fix": "prettier --ignore-path ../.prettierignore --write 'src/**/*.{js,ts,tsx,md,json}' .eslintrc.json ../.prettierrc babel.config.js && eslint --fix 'src/**/*.{js,ts,tsx,md}' --max-warnings 0",
+    "lint": "prettier --ignore-path ../.prettierignore --list-different 'src/**/*.{js,ts,tsx,md,json}' eslint.config.mjs ../.prettierrc babel.config.js && eslint 'src/**/*.{js,ts,tsx,md}' --max-warnings 0 && yarn run validate-translations",
+    "lint-fix": "prettier --ignore-path ../.prettierignore --write 'src/**/*.{js,ts,tsx,md,json}' eslint.config.mjs ../.prettierrc babel.config.js && eslint --fix 'src/**/*.{js,ts,tsx,md}' --max-warnings 0",
     "prepare": "yarn run build",
     "prepare-distribution": "cd examples/SampleApp && npm version patch && react-native-version && git add ./ && git commit -m 'Bump build version' --no-verify",
-    "prettier": "prettier --list-different '**/*.{js,ts,tsx,md,json}' .eslintrc.json ../.prettierrc babel.config.js",
-    "prettier-fix": "prettier --write '**/*.{js,ts,tsx,md,json}' .eslintrc.json ../.prettierrc babel.config.js",
+    "prettier": "prettier --list-different '**/*.{js,ts,tsx,md,json}' eslint.config.mjs ../.prettierrc babel.config.js",
+    "prettier-fix": "prettier --write '**/*.{js,ts,tsx,md,json}' eslint.config.mjs ../.prettierrc babel.config.js",
     "test:coverage": "yarn test:unit --coverage",
     "test:unit": "TZ=UTC jest",
     "validate-translations": "node bin/validate-translations.js",

package/package.json

@@ -1,5 +1,5 @@
 /* eslint-disable no-underscore-dangle */
-/* eslint-disable jest/no-export */
+
 import React from 'react';
 import { Text, View } from 'react-native';
 
@@ -53,7 +53,9 @@ const ChannelPreviewComponent = ({ channel, setActiveChannel }) => (
 
 const ChannelListComponent = (props) => {
   const { channels, onSelect } = useChannelsContext();
-  if (!channels) return null;
+  if (!channels) {
+    return null;
+  }
 
   return (
     <View testID='channel-list'>
@@ -92,7 +94,7 @@ export const Generic = () => {
     it('should NOT create tables on first load if offline feature is disabled', async () => {
       render(
         <Chat client={chatClient}>
-          <View testID='test-child'></View>
+          <View testID='test-child' />
         </Chat>,
       );
       await waitFor(() => expect(screen.getByTestId('test-child')).toBeTruthy());
@@ -294,7 +296,7 @@ export const Generic = () => {
     it('should create tables on first load if offline feature is enabled', async () => {
       render(
         <Chat client={chatClient} enableOfflineSupport>
-          <View testID='test-child'></View>
+          <View testID='test-child' />
         </Chat>,
       );
 

package/src/__tests__/offline-support/offline-feature.js

@@ -1,5 +1,3 @@
-/* eslint-disable jest/no-export */
-/* eslint-disable no-underscore-dangle */
 import React, { useContext, useEffect, useState } from 'react';
 import { View } from 'react-native';
 
@@ -137,9 +135,11 @@ export const OptimisticUpdates = () => {
         };
 
         call();
-      }, []);
+      }, [callback, ctx]);
 
-      if (!ready) return null;
+      if (!ready) {
+        return null;
+      }
 
       return children;
     };
@@ -364,8 +364,8 @@ export const OptimisticUpdates = () => {
         expect(pendingTasksRows.length).toBe(2);
       });
 
-      chatClient.deleteMessage = jest.fn();
-      channel.sendReaction = jest.fn();
+      jest.spyOn(chatClient, 'deleteMessage').mockImplementation();
+      jest.spyOn(channel, 'sendReaction').mockImplementation();
 
       act(() => dispatchConnectionChangedEvent(chatClient, true));
 

package/src/__tests__/offline-support/optimistic-update.js

@@ -123,15 +123,19 @@ const areEqual = <StreamChatGenerics extends DefaultStreamChatGenerics = Default
     prevAttachment.image_url === nextAttachment.image_url &&
     prevAttachment.thumb_url === nextAttachment.thumb_url &&
     prevAttachment.type === nextAttachment.type;
-  if (!attachmentEqual) return false;
+  if (!attachmentEqual) {
+    return false;
+  }
 
   if (isAttachmentEqual) {
     return isAttachmentEqual(prevAttachment, nextAttachment);
   }
 
   const messageThemeEqual =
     JSON.stringify(prevMyMessageTheme) === JSON.stringify(nextMyMessageTheme);
-  if (!messageThemeEqual) return false;
+  if (!messageThemeEqual) {
+    return false;
+  }
 
   return true;
 };

package/src/components/Attachment/Attachment.tsx

@@ -298,7 +298,9 @@ const areEqual = <StreamChatGenerics extends DefaultStreamChatGenerics = Default
 
   const messageThemeEqual =
     JSON.stringify(prevMyMessageTheme) === JSON.stringify(nextMyMessageTheme);
-  if (!messageThemeEqual) return false;
+  if (!messageThemeEqual) {
+    return false;
+  }
 
   return true;
 };

package/src/components/Attachment/Card.tsx

@@ -183,7 +183,9 @@ export const FileAttachment = <
 };
 
 export const getFileSizeDisplayText = (size?: number | string) => {
-  if (!size) return;
+  if (!size) {
+    return;
+  }
   if (typeof size === 'string') {
     size = parseFloat(size);
   }

package/src/components/Attachment/FileAttachment.tsx

@@ -178,7 +178,9 @@ export const FileAttachmentGroup = <
 
   const files = propFiles || contextFiles;
 
-  if (!files.length) return null;
+  if (!files.length) {
+    return null;
+  }
 
   return (
     <MemoizedFileAttachmentGroup

package/src/components/Attachment/FileAttachmentGroup.tsx

@@ -417,10 +417,14 @@ for (const type of videoFileTypes) {
 }
 
 function mimeTypeToIcon(mimeType?: string): React.ComponentType<IconProps> {
-  if (!mimeType) return GenericFile;
+  if (!mimeType) {
+    return GenericFile;
+  }
 
   const Icon = mimeTypeToIconMap[mimeType];
-  if (Icon) return Icon;
+  if (Icon) {
+    return Icon;
+  }
 
   return GenericFile;
 }