fix: attachment send while offline support is enabled

Author: khushal87

package/src/components/Channel/Channel.tsx

@@ -1203,15 +1203,18 @@ const ChannelWithContext = (props: PropsWithChildren<ChannelPropsWithContext>) =
     if (updatedMessage.attachments?.length) {
       for (let i = 0; i < updatedMessage.attachments?.length; i++) {
         const attachment = updatedMessage.attachments[i];
-        const image = attachment.originalFile;
-        const file = attachment.originalFile;
-        // check if image_url is not a remote url
+
+        // If the attachment is already uploaded, skip it.
         if (
-          attachment.type === FileTypes.Image &&
-          image?.uri &&
-          attachment.image_url &&
-          isLocalUrl(attachment.image_url)
+          (attachment.image_url && !isLocalUrl(attachment.image_url)) ||
+          (attachment.asset_url && !isLocalUrl(attachment.asset_url))
         ) {
+          continue;
+        }
+
+        const image = attachment.originalFile;
+        const file = attachment.originalFile;
+        if (attachment.type === FileTypes.Image && image?.uri) {
           const filename = image.name ?? getFileNameFromPath(image.uri);
           // if any upload is in progress, cancel it
           const controller = uploadAbortControllerRef.current.get(filename);
@@ -1234,12 +1237,7 @@ const ChannelWithContext = (props: PropsWithChildren<ChannelPropsWithContext>) =
           });
         }
 
-        if (
-          attachment.type !== FileTypes.Image &&
-          attachment.asset_url &&
-          isLocalUrl(attachment.asset_url) &&
-          file?.uri
-        ) {
+        if (attachment.type !== FileTypes.Image && file?.uri) {
           // if any upload is in progress, cancel it
           const controller = uploadAbortControllerRef.current.get(file.name);
           if (controller) {

package/src/middlewares/attachments.ts

@@ -13,13 +13,21 @@ import {
 
 const localAttachmentToAttachment = (localAttachment: LocalAttachment) => {
   const { localMetadata, ...attachment } = localAttachment;
+
   if (isLocalImageAttachment(localAttachment)) {
+    const isRemoteUri = !!attachment.image_url;
+
+    if (isRemoteUri) return attachment as Attachment;
+
     return {
       ...attachment,
       image_url: localMetadata?.previewUri,
       originalFile: localMetadata.file,
     } as Attachment;
   } else {
+    const isRemoteUri = !!attachment.asset_url;
+    if (isRemoteUri) return attachment as Attachment;
+
     return {
       ...attachment,
       asset_url: (localMetadata.file as FileReference).uri,

package/src/utils/utils.ts

@@ -112,7 +112,7 @@ export const getUrlWithoutParams = (url?: string) => {
   return url.substring(0, url.indexOf('?'));
 };
 
-export const isLocalUrl = (url: string) => url.includes('http');
+export const isLocalUrl = (url: string) => !url.includes('http');
 
 export const generateRandomId = (a = ''): string =>
   a