fix: refactor photo resolution to native level

Author: isekovanic

package/native-package/src/optionalDependencies/getLocalAssetUri.ts

@@ -14,12 +14,11 @@ try {
 export const getLocalAssetUri = CameraRollDependency
   ? async (remoteUri: string) => {
       try {
-        let localUri = remoteUri;
         if (Platform.OS === 'ios') {
           const imageData = await CameraRollDependency.CameraRoll.iosGetImageDataById(remoteUri);
-          localUri = imageData?.node?.image?.filepath;
+          return imageData?.node?.image?.filepath;
         }
-        return localUri;
+        return remoteUri;
       } catch {
         throw new Error('getLocalAssetUri Error');
       }

package/native-package/src/optionalDependencies/getPhotos.ts

@@ -13,6 +13,8 @@ try {
 
 import type { Asset } from 'stream-chat-react-native-core';
 
+import { getLocalAssetUri } from './getLocalAssetUri';
+
 type ReturnType = {
   assets: Array<Omit<Asset, 'source'> & { source: 'picker' }>;
   endCursor: string | undefined;
@@ -82,15 +84,23 @@ export const getPhotos = CameraRollDependency
           first,
           include: ['fileSize', 'filename', 'imageSize', 'playableDuration'],
         });
-        const assets = results.edges.map((edge) => ({
-          ...edge.node.image,
-          duration: edge.node.image.playableDuration * 1000,
-          // since we include filename, fileSize in the query, we can safely assume it will be defined
-          name: edge.node.image.filename as string,
-          size: edge.node.image.fileSize as number,
-          source: 'picker' as const,
-          type: edge.node.type,
-        }));
+        const assets = await Promise.all(
+          results.edges.map(async (edge) => {
+            const originalUri = edge.node?.image?.uri;
+            const uri = getLocalAssetUri ? await getLocalAssetUri(originalUri) : originalUri;
+            return {
+              ...edge.node.image,
+              duration: edge.node.image.playableDuration * 1000,
+              // since we include filename, fileSize in the query, we can safely assume it will be defined
+              name: edge.node.image.filename as string,
+              originalUri,
+              size: edge.node.image.fileSize as number,
+              source: 'picker' as const,
+              type: edge.node.type,
+              uri,
+            };
+          }),
+        );
         const hasNextPage = results.page_info.has_next_page;
         const endCursor = results.page_info.end_cursor;
         return { assets, endCursor, hasNextPage, iOSLimited: !!results.limited };

package/src/components/AttachmentPicker/components/AttachmentPickerItem.tsx

@@ -158,33 +158,12 @@ const AttachmentImage = (props: AttachmentImageProps) => {
 
   const { uri } = asset;
 
-  /* Patches image files with uri */
-  const patchImageFile = async (images: Asset[]) => {
-    // For the case of Expo CLI where you need to fetch the file uri from file id. Here it is only done for iOS since for android the file.uri is fine.
-    const identifier = asset.id || asset.uri;
-    const localAssetURI =
-      Platform.OS === 'ios' &&
-      identifier &&
-      getLocalAssetUri &&
-      (await getLocalAssetUri(identifier));
-    const uri = localAssetURI || asset.uri || '';
-    return [
-      ...images,
-      {
-        ...asset,
-        originalUri: asset.uri,
-        uri,
-      },
-    ];
-  };
-
-  const updateSelectedImages = async () => {
+  const updateSelectedImages = () => {
     if (numberOfUploads >= maxNumberOfFiles) {
       Alert.alert(t('Maximum number of files reached'));
       return;
     }
-    const images = await patchImageFile(selectedImages);
-    setSelectedImages(images);
+    setSelectedImages([...selectedImages, asset]);
   };
 
   const onPressImage = () => {