Skip to content

Commit aed51af

Browse files
committed
fix: pr remarks
1 parent 97c1292 commit aed51af

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

package/src/components/ChannelList/hooks/usePaginatedChannels.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export const usePaginatedChannels = ({
6666

6767
const queryChannels: QueryChannels = async (
6868
queryType: QueryType = 'loadChannels',
69-
// retryCount = 0,
7069
): Promise<void> => {
7170
if (!client || !isMountedRef.current) {
7271
return;
@@ -95,7 +94,6 @@ export const usePaginatedChannels = ({
9594
filtersRef.current = filters;
9695
sortRef.current = sort;
9796
isQueryingRef.current = true;
98-
// setError(undefined);
9997
activeRequestId.current++;
10098
const currentRequestId = activeRequestId.current;
10199
setActiveQueryType(queryType);

package/src/store/OfflineDB.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ export class OfflineDB extends AbstractOfflineDB {
2020

2121
upsertChannels = api.upsertChannels;
2222

23-
// FIXME
23+
// TODO: Rename currentUserId -> userId in the next major version as it is technically breaking.
2424
upsertUserSyncStatus = ({ userId, lastSyncedAt, execute }: UpsertUserSyncStatusType) =>
2525
api.upsertUserSyncStatus({ currentUserId: userId, execute, lastSyncedAt });
2626

27-
// FIXME
27+
// TODO: Rename currentUserId -> userId in the next major version as it is technically breaking.
2828
upsertAppSettings = ({ appSettings, userId, execute }: UpsertAppSettingsType) =>
2929
api.upsertAppSettings({ appSettings, currentUserId: userId, execute });
3030

@@ -40,16 +40,17 @@ export class OfflineDB extends AbstractOfflineDB {
4040

4141
updateMessage = api.updateMessage;
4242

43-
// FIXME
43+
// TODO: Rename currentUserId -> userId in the next major version as it is technically breaking.
4444
getChannels = ({ cids, userId }: GetChannelsType) =>
4545
api.getChannels({ channelIds: cids, currentUserId: userId });
4646

47-
// FIXME
47+
// TODO: Rename currentUserId -> userId in the next major version as it is technically breaking.
4848
getChannelsForQuery = ({ userId, filters, sort }: GetChannelsForQueryType) =>
4949
api.getChannelsForFilterSort({ currentUserId: userId, filters, sort });
5050

5151
getAllChannelCids = api.getAllChannelIds;
52-
// FIXME
52+
53+
// TODO: Rename currentUserId -> userId in the next major version as it is technically breaking.
5354
getLastSyncedAt = ({ userId }: GetLastSyncedAtType) =>
5455
api.getLastSyncedAt({ currentUserId: userId });
5556

0 commit comments

Comments
 (0)