Skip to content

Commit b2c54ad

Browse files
committed
move reply to quoted reply
1 parent 677c1ba commit b2c54ad

File tree

9 files changed

+54
-46
lines changed

9 files changed

+54
-46
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## [3.5.0]
4+
5+
### Bug fixes
6+
- Mute status updates on every message
7+
8+
### **🛑 BREAKING**
9+
- `reply`, `handleReply`, and `handleReplyMessage` have now all been shifted to `quotedReply`, `handleQuotedReply`, and `handleQuotedReplyMessage` respectively.
10+
311
## [3.4.0] (2021-05-14)
412

513
### Features

src/components/Channel/Channel.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ export type ChannelPropsWithContext<
255255
| 'handleFlag'
256256
| 'handleMute'
257257
| 'handleReaction'
258-
| 'handleReply'
258+
| 'handleQuotedReply'
259259
| 'handleRetry'
260260
| 'handleThreadReply'
261261
| 'InlineDateSeparator'
@@ -283,9 +283,9 @@ export type ChannelPropsWithContext<
283283
| 'onPressInMessage'
284284
| 'onPressMessage'
285285
| 'OverlayReactionList'
286+
| 'quotedReply'
286287
| 'ReactionList'
287288
| 'Reply'
288-
| 'reply'
289289
| 'retry'
290290
| 'ScrollToBottomButton'
291291
| 'selectReaction'
@@ -456,8 +456,8 @@ const ChannelWithContext = <
456456
handleEdit,
457457
handleFlag,
458458
handleMute,
459+
handleQuotedReply,
459460
handleReaction,
460-
handleReply,
461461
handleRetry,
462462
handleThreadReply,
463463
hasCommands = true,
@@ -512,11 +512,11 @@ const ChannelWithContext = <
512512
openSuggestions,
513513
OverlayReactionList = OverlayReactionListDefault,
514514
quotedRepliesEnabled: quotedRepliesEnabledProp,
515+
quotedReply,
515516
ReactionList = ReactionListDefault,
516517
reactionsEnabled: reactionsEnabledProp,
517518
readEventsEnabled: readEventsEnabledProp,
518519
Reply = ReplyDefault,
519-
reply,
520520
retry,
521521
ScrollToBottomButton = ScrollToBottomButtonDefault,
522522
selectReaction,
@@ -1729,8 +1729,8 @@ const ChannelWithContext = <
17291729
handleEdit,
17301730
handleFlag,
17311731
handleMute,
1732+
handleQuotedReply,
17321733
handleReaction,
1733-
handleReply,
17341734
handleRetry,
17351735
handleThreadReply,
17361736
initialScrollToFirstUnreadMessage,
@@ -1759,10 +1759,10 @@ const ChannelWithContext = <
17591759
onPressInMessage,
17601760
onPressMessage,
17611761
OverlayReactionList,
1762+
quotedReply,
17621763
ReactionList,
17631764
removeMessage,
17641765
Reply,
1765-
reply,
17661766
retry,
17671767
retrySendMessage,
17681768
ScrollToBottomButton,

src/components/Channel/hooks/useCreateMessagesContext.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ export const useCreateMessagesContext = <
5252
handleEdit,
5353
handleFlag,
5454
handleMute,
55+
handleQuotedReply,
5556
handleReaction,
56-
handleReply,
5757
handleRetry,
5858
handleThreadReply,
5959
initialScrollToFirstUnreadMessage,
@@ -83,11 +83,11 @@ export const useCreateMessagesContext = <
8383
onPressMessage,
8484
OverlayReactionList,
8585
quotedRepliesEnabled,
86+
quotedReply,
8687
ReactionList,
8788
reactionsEnabled,
8889
removeMessage,
8990
Reply,
90-
reply,
9191
retry,
9292
retrySendMessage,
9393
ScrollToBottomButton,
@@ -154,8 +154,8 @@ export const useCreateMessagesContext = <
154154
handleEdit,
155155
handleFlag,
156156
handleMute,
157+
handleQuotedReply,
157158
handleReaction,
158-
handleReply,
159159
handleRetry,
160160
handleThreadReply,
161161
initialScrollToFirstUnreadMessage,
@@ -185,11 +185,11 @@ export const useCreateMessagesContext = <
185185
onPressMessage,
186186
OverlayReactionList,
187187
quotedRepliesEnabled,
188+
quotedReply,
188189
ReactionList,
189190
reactionsEnabled,
190191
removeMessage,
191192
Reply,
192-
reply,
193193
retry,
194194
retrySendMessage,
195195
ScrollToBottomButton,

src/components/Message/Message.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export type MessageTouchableHandlerPayload<
157157
export type MessageActionHandlers = {
158158
deleteMessage: () => Promise<void>;
159159
editMessage: () => void;
160-
reply: () => void;
160+
quotedReply: () => void;
161161
resendMessage: () => Promise<void>;
162162
showMessageOverlay: () => void;
163163
toggleBanUser: () => Promise<void>;
@@ -211,8 +211,8 @@ export type MessagePropsWithContext<
211211
| 'handleEdit'
212212
| 'handleFlag'
213213
| 'handleMute'
214+
| 'handleQuotedReply'
214215
| 'handleReaction'
215-
| 'handleReply'
216216
| 'handleRetry'
217217
| 'handleThreadReply'
218218
| 'messageActions'
@@ -225,9 +225,9 @@ export type MessagePropsWithContext<
225225
| 'onPressMessage'
226226
| 'OverlayReactionList'
227227
| 'quotedRepliesEnabled'
228+
| 'quotedReply'
228229
| 'reactionsEnabled'
229230
| 'removeMessage'
230-
| 'reply'
231231
| 'retry'
232232
| 'retrySendMessage'
233233
| 'selectReaction'
@@ -340,8 +340,8 @@ const MessageWithContext = <
340340
handleEdit,
341341
handleFlag,
342342
handleMute,
343+
handleQuotedReply,
343344
handleReaction: handleReactionProp,
344-
handleReply,
345345
handleRetry,
346346
handleThreadReply,
347347
isAdmin,
@@ -369,7 +369,7 @@ const MessageWithContext = <
369369
reactionsEnabled,
370370
readEventsEnabled,
371371
removeMessage,
372-
reply: replyProp,
372+
quotedReply: quotedReplyProp,
373373
retry: retryProp,
374374
retrySendMessage,
375375
selectReaction,
@@ -671,7 +671,7 @@ const MessageWithContext = <
671671
const handleResendMessage = () =>
672672
retrySendMessage(message as MessageResponse<At, Ch, Co, Me, Re, Us>);
673673

674-
const handleReplyMessage = () => {
674+
const handleQuotedReplyMessage = () => {
675675
setQuotedMessageState(message);
676676
};
677677

@@ -894,17 +894,17 @@ const MessageWithContext = <
894894
title: isMuted ? t('Unmute User') : t('Mute User'),
895895
};
896896

897-
const reply = replyProp
898-
? replyProp(message)
899-
: replyProp === null
897+
const quotedReply = quotedReplyProp
898+
? quotedReplyProp(message)
899+
: quotedReplyProp === null
900900
? null
901901
: {
902902
action: () => {
903903
setOverlay('none');
904-
if (handleReply) {
905-
handleReply(message);
904+
if (handleQuotedReply) {
905+
handleQuotedReply(message);
906906
}
907-
handleReplyMessage();
907+
handleQuotedReplyMessage();
908908
},
909909
icon: <CurveLineLeftUp pathFill={grey} />,
910910
title: t('Reply'),
@@ -963,7 +963,7 @@ const MessageWithContext = <
963963
messageReactions,
964964
muteUser,
965965
quotedRepliesEnabled,
966-
reply,
966+
quotedReply,
967967
retry,
968968
threadRepliesEnabled,
969969
threadReply,
@@ -996,7 +996,7 @@ const MessageWithContext = <
996996
const actionHandlers: MessageActionHandlers = {
997997
deleteMessage: handleDeleteMessage,
998998
editMessage: handleEditMessage,
999-
reply: handleReplyMessage,
999+
quotedReply: handleQuotedReplyMessage,
10001000
resendMessage: handleResendMessage,
10011001
showMessageOverlay,
10021002
toggleBanUser: handleToggleBanUser,
@@ -1046,7 +1046,7 @@ const MessageWithContext = <
10461046
handleAction,
10471047
handleDeleteMessage,
10481048
handleEditMessage,
1049-
handleReplyMessage,
1049+
handleQuotedReplyMessage,
10501050
handleResendMessage,
10511051
handleToggleBanUser,
10521052
handleToggleMuteUser,

src/components/Message/hooks/useCreateMessageContext.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const useCreateMessageContext = <
3434
handleAction,
3535
handleDeleteMessage,
3636
handleEditMessage,
37-
handleReplyMessage,
37+
handleQuotedReplyMessage,
3838
handleResendMessage,
3939
handleToggleBanUser,
4040
handleToggleMuteUser,
@@ -98,7 +98,7 @@ export const useCreateMessageContext = <
9898
handleAction,
9999
handleDeleteMessage,
100100
handleEditMessage,
101-
handleReplyMessage,
101+
handleQuotedReplyMessage,
102102
handleResendMessage,
103103
handleToggleBanUser,
104104
handleToggleMuteUser,

src/components/Message/utils/messageActions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const messageActions = <
3434
messageReactions,
3535
muteUser,
3636
quotedRepliesEnabled,
37-
reply,
37+
quotedReply,
3838
retry,
3939
threadRepliesEnabled,
4040
threadReply,
@@ -51,7 +51,7 @@ export const messageActions = <
5151
message: MessageType<At, Ch, Co, Ev, Me, Re, Us>;
5252
messageReactions: boolean;
5353
muteUser: MessageAction | null;
54-
reply: MessageAction | null;
54+
quotedReply: MessageAction | null;
5555
retry: MessageAction | null;
5656
threadReply: MessageAction | null;
5757
quotedRepliesEnabled?: boolean;
@@ -68,7 +68,7 @@ export const messageActions = <
6868
}
6969

7070
if (quotedRepliesEnabled && !isThreadMessage && !error) {
71-
actions.push(reply);
71+
actions.push(quotedReply);
7272
}
7373

7474
if (threadRepliesEnabled && !isThreadMessage && !error) {

src/contexts/messageContext/MessageContext.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const SomeChildComponent = () => {
1111
const {
1212
handleDeleteMessage,
1313
handleEditMessage,
14-
handleReplyMessage,
14+
handleQuotedReplyMessage,
1515
handleResendMessage,
1616
handleToggleBanUser,
1717
handleToggleMuteUser,

src/contexts/messageContext/MessageContext.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export type MessageContextValue<
6060
handleAction: ActionHandler;
6161
handleDeleteMessage: () => Promise<void>;
6262
handleEditMessage: () => void;
63-
handleReplyMessage: () => void;
63+
handleQuotedReplyMessage: () => void;
6464
handleResendMessage: () => Promise<void>;
6565
handleToggleBanUser: () => Promise<void>;
6666
handleToggleMuteUser: () => Promise<void>;

0 commit comments

Comments
 (0)