Skip to content

Commit ba9bccd

Browse files
authored
fix: disable typing events when offline (#2753)
* fix: disable typing events when offline * fix: failing test
1 parent c5a3046 commit ba9bccd

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

package/src/contexts/messageInputContext/MessageInputContext.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,8 @@ export const MessageInputProvider = <
538538
setSelectedImages,
539539
setSelectedPicker,
540540
} = useAttachmentPickerContext();
541-
const { appSettings, client, enableOfflineSupport } = useChatContext<StreamChatGenerics>();
541+
const { appSettings, client, enableOfflineSupport, isOnline } =
542+
useChatContext<StreamChatGenerics>();
542543
const { removeMessage } = useMessagesContext();
543544

544545
const getFileUploadConfig = () => {
@@ -652,7 +653,7 @@ export const MessageInputProvider = <
652653
}
653654
setText(newText);
654655

655-
if (newText && channel && channelCapabities.sendTypingEvents) {
656+
if (newText && channel && channelCapabities.sendTypingEvents && isOnline) {
656657
logChatPromiseExecution(channel.keystroke(thread?.id), 'start typing event');
657658
}
658659

package/src/contexts/messageInputContext/__tests__/pickFile.test.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe("MessageInputContext's pickFile", () => {
6161
maxNumberOfFiles: 2,
6262
};
6363

64-
it.each([[3, 2]])(
64+
it.each([[3, 1]])(
6565
'run pickFile when numberOfUploads is %d and alert is triggered %d number of times',
6666
async (numberOfUploads, numberOfTimesCalled) => {
6767
const { rerender, result } = renderHook(() => useMessageInputContext(), {
@@ -87,6 +87,7 @@ describe("MessageInputContext's pickFile", () => {
8787
});
8888

8989
expect(Alert.alert).toHaveBeenCalledTimes(numberOfTimesCalled);
90+
expect(Alert.alert).toHaveBeenCalledWith('Maximum number of files reached');
9091
},
9192
);
9293

package/src/contexts/messageInputContext/hooks/useCreateMessageInputContext.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ export const useCreateMessageInputContext = <
258258
text,
259259
threadId,
260260
showPollCreationDialog,
261+
onChange,
261262
],
262263
);
263264

0 commit comments

Comments
 (0)