fix: remove unused values from message input context

Author: khushal87

package/src/components/MessageInput/MessageInput.tsx

@@ -136,7 +136,6 @@ type MessageInputPropsWithContext = Pick<
     | 'InputReplyStateHeader'
     | 'isValidMessage'
     | 'maxNumberOfFiles'
-    | 'mentionedUsers'
     | 'numberOfUploads'
     | 'quotedMessage'
     | 'resetInput'
@@ -163,6 +162,7 @@ type MessageInputPropsWithContext = Pick<
   Pick<TranslationContextValue, 't'>;
 
 const textComposerStateSelector = (state: TextComposerState) => ({
+  mentionedUsers: state.mentionedUsers,
   suggestions: state.suggestions,
   text: state.text,
 });
@@ -209,7 +209,6 @@ const MessageInputWithContext = (props: MessageInputPropsWithContext) => {
     isValidMessage,
     maxNumberOfFiles,
     members,
-    mentionedUsers,
     numberOfUploads,
     quotedMessage,
     removeFile,
@@ -233,7 +232,7 @@ const MessageInputWithContext = (props: MessageInputPropsWithContext) => {
 
   const messageComposer = useMessageComposer();
   const { customDataManager, textComposer } = messageComposer;
-  const { text } = useStateStore(textComposer.state, textComposerStateSelector);
+  const { mentionedUsers, text } = useStateStore(textComposer.state, textComposerStateSelector);
   const { command } = useStateStore(customDataManager.state, customComposerDataSelector);
 
   const [height, setHeight] = useState(0);
@@ -899,7 +898,6 @@ const areEqual = (
     imageUploads: prevImageUploads,
     isOnline: prevIsOnline,
     isValidMessage: prevIsValidMessage,
-    mentionedUsers: prevMentionedUsers,
     openPollCreationDialog: prevOpenPollCreationDialog,
     quotedMessage: prevQuotedMessage,
     sending: prevSending,
@@ -923,7 +921,6 @@ const areEqual = (
     imageUploads: nextImageUploads,
     isOnline: nextIsOnline,
     isValidMessage: nextIsValidMessage,
-    mentionedUsers: nextMentionedUsers,
     openPollCreationDialog: nextOpenPollCreationDialog,
     quotedMessage: nextQuotedMessage,
     sending: nextSending,
@@ -1036,11 +1033,6 @@ const areEqual = (
     return false;
   }
 
-  const mentionedUsersEqual = prevMentionedUsers.length === nextMentionedUsers.length;
-  if (!mentionedUsersEqual) {
-    return false;
-  }
-
   const threadEqual =
     prevThread?.id === nextThread?.id &&
     prevThread?.text === nextThread?.text &&
@@ -1116,7 +1108,6 @@ export const MessageInput = (props: MessageInputProps) => {
     InputReplyStateHeader,
     isValidMessage,
     maxNumberOfFiles,
-    mentionedUsers,
     numberOfUploads,
     openPollCreationDialog,
     quotedMessage,
@@ -1194,7 +1185,6 @@ export const MessageInput = (props: MessageInputProps) => {
         isValidMessage,
         maxNumberOfFiles,
         members,
-        mentionedUsers,
         numberOfUploads,
         openPollCreationDialog,
         quotedMessage,

package/src/contexts/messageInputContext/MessageInputContext.tsx

@@ -143,7 +143,6 @@ export type LocalMessageInputContext = {
    *
    */
   fileUploads: FileUpload[];
-  hasText: boolean;
   /**
    * An array of image objects which are set for upload. It has the following structure:
    *
@@ -166,7 +165,6 @@ export type LocalMessageInputContext = {
   imageUploads: FileUpload[];
   inputBoxRef: React.MutableRefObject<TextInput | null>;
   isValidMessage: () => boolean;
-  mentionedUsers: string[];
   numberOfUploads: number;
   openAttachmentPicker: () => void;
   openFilePicker: () => void;
@@ -217,7 +215,6 @@ export type LocalMessageInputContext = {
    * Function for taking a photo and uploading it
    */
   takeAndUploadImage: (mediaType?: MediaTypes) => Promise<void>;
-  text: string;
   toggleAttachmentPicker: () => void;
   updateMessage: () => Promise<void>;
   /** Function for attempting to upload a file */
@@ -1389,7 +1386,6 @@ export const MessageInputProvider = ({
     inputBoxRef,
     isCommandUIEnabled,
     isValidMessage,
-    mentionedUsers: mentionedUsers.map((user) => user.id),
     numberOfUploads,
     openAttachmentPicker,
     openFilePicker: pickFile,
@@ -1413,7 +1409,6 @@ export const MessageInputProvider = ({
     setShowMoreOptions,
     showMoreOptions,
     takeAndUploadImage,
-    text,
     thread,
     toggleAttachmentPicker,
     updateMessage,
@@ -1423,7 +1418,6 @@ export const MessageInputProvider = ({
     uploadNewImage,
     ...value,
     closePollCreationDialog,
-    hasText: !!text,
     openPollCreationDialog,
     sendMessage, // overriding the originally passed in sendMessage
     showPollCreationDialog,

package/src/contexts/messageInputContext/hooks/useCreateMessageInputContext.ts

@@ -45,7 +45,6 @@ export const useCreateMessageInputContext = ({
   hasCommands,
   hasFilePicker,
   hasImagePicker,
-  hasText,
   ImageUploadPreview,
   imageUploads,
   initialValue,
@@ -59,7 +58,6 @@ export const useCreateMessageInputContext = ({
   maxNumberOfFiles,
   mentionAllAppUsersEnabled,
   mentionAllAppUsersQuery,
-  mentionedUsers,
   MoreOptionsButton,
   numberOfLines,
   numberOfUploads,
@@ -98,7 +96,6 @@ export const useCreateMessageInputContext = ({
   StartAudioRecordingButton,
   StopMessageStreamingButton,
   takeAndUploadImage,
-  text,
   thread,
   toggleAttachmentPicker,
   updateMessage,
@@ -112,7 +109,6 @@ export const useCreateMessageInputContext = ({
   const fileUploadsValue = fileUploads.map(({ state }) => state).join();
   const imageUploadsValue = imageUploads.map(({ state }) => state).join();
   const asyncUploadsValue = Object.keys(asyncUploads).join();
-  const mentionedUsersLength = mentionedUsers.length;
   const quotedMessageId = quotedMessage ? quotedMessage.id : '';
   const threadId = thread?.id;
   const asyncIdsLength = asyncIds.length;
@@ -159,7 +155,6 @@ export const useCreateMessageInputContext = ({
       hasCommands,
       hasFilePicker,
       hasImagePicker,
-      hasText,
       ImageUploadPreview,
       imageUploads,
       initialValue,
@@ -174,7 +169,6 @@ export const useCreateMessageInputContext = ({
       maxNumberOfFiles,
       mentionAllAppUsersEnabled,
       mentionAllAppUsersQuery,
-      mentionedUsers,
       MoreOptionsButton,
       numberOfLines,
       numberOfUploads,
@@ -213,7 +207,6 @@ export const useCreateMessageInputContext = ({
       StartAudioRecordingButton,
       StopMessageStreamingButton,
       takeAndUploadImage,
-      text,
       toggleAttachmentPicker,
       updateMessage,
       uploadFile,
@@ -230,15 +223,12 @@ export const useCreateMessageInputContext = ({
       editingdep,
       fileUploadsValue,
       isCommandUIEnabled,
-      hasText,
       imageUploadsValue,
       maxMessageLength,
-      mentionedUsersLength,
       quotedMessageId,
       selectedPicker,
       sendThreadMessageInChannel,
       showMoreOptions,
-      text,
       threadId,
       showPollCreationDialog,
     ],