Skip to content

Commit c2583cd

Browse files
Fixing ChannelList UX
1 parent a9e181c commit c2583cd

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/components/ChannelList/ChannelListMessenger.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,10 @@ const ChannelListMessenger = (props) => {
115115
);
116116
};
117117

118-
if (error && !refreshing && !(channels && channels.length)) {
119-
return renderLoadingError();
120-
} else if (loadingChannels) {
118+
if (loadingChannels) {
121119
return renderLoading();
120+
} else if (error && !refreshing && !(channels && channels.length)) {
121+
return renderLoadingError();
122122
} else {
123123
return renderChannels();
124124
}

src/components/ChannelList/hooks/usePaginatedChannels.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@ import { useEffect, useState } from 'react';
22

33
import { MAX_QUERY_CHANNELS_LIMIT } from '../utils';
44

5-
const wait = (ms) => {
5+
const wait = (ms) =>
66
new Promise((resolve) => {
77
setTimeout(resolve, ms);
88
});
9-
};
109

1110
export const usePaginatedChannels = ({
1211
client,
@@ -26,7 +25,6 @@ export const usePaginatedChannels = ({
2625
if (loadingChannels || loadingNextPage || refreshing) return;
2726

2827
if (queryType === 'reload') {
29-
setChannels([]);
3028
setLoadingChannels(true);
3129
} else if (queryType === 'refresh') {
3230
setRefreshing(true);
@@ -58,12 +56,12 @@ export const usePaginatedChannels = ({
5856
setHasNextPage(channelQueryResponse.length >= newOptions.limit);
5957
setOffset(newChannels.length);
6058
} catch (e) {
61-
setLoadingChannels(false);
62-
setLoadingNextPage(false);
63-
setRefreshing(false);
6459
await wait(2000);
6560

6661
if (retryCount === 3) {
62+
setLoadingChannels(false);
63+
setLoadingNextPage(false);
64+
setRefreshing(false);
6765
console.warn(e);
6866
return setError(true);
6967
}

0 commit comments

Comments
 (0)