fix: handle edge cases

Author: khushal87

package/expo-package/src/optionalDependencies/takePhoto.ts

@@ -21,8 +21,8 @@ type Size = {
 
 // Media type mapping for iOS and Android
 const mediaTypeMap = {
-  mixed: ['images', 'videos'],
   image: 'images',
+  mixed: ['images', 'videos'],
   video: 'videos',
 };
 
@@ -42,27 +42,28 @@ export const takePhoto = ImagePicker
         }
 
         if (permissionGranted) {
-          const imagePickerSuccessResult = await ImagePicker.launchCameraAsync({
+          const result = await ImagePicker.launchCameraAsync({
             mediaTypes: mediaTypeMap[mediaType],
             quality: Math.min(Math.max(0, compressImageQuality), 1),
           });
-          const canceled = imagePickerSuccessResult.canceled;
-          const assets = imagePickerSuccessResult.assets;
-          if (canceled || !assets.length) {
+          if (!result || !result.assets || !result.assets.length || result.canceled) {
             return { cancelled: true };
           }
           // since we only support single photo upload for now we will only be focusing on 0'th element.
-          const photo = assets[0];
+          const photo = result.assets[0];
+          if (!photo) {
+            return { cancelled: true };
+          }
           if (photo.mimeType.includes('video')) {
             const clearFilter = new RegExp('[.:]', 'g');
             const date = new Date().toISOString().replace(clearFilter, '_');
             return {
               ...photo,
               cancelled: false,
               duration: photo.duration, // in milliseconds
-              source: 'camera',
               name: 'video_recording_' + date + photo.uri.split('.').pop(),
               size: photo.fileSize,
+              source: 'camera',
               type: photo.mimeType,
               uri: photo.uri,
             };
@@ -94,8 +95,8 @@ export const takePhoto = ImagePicker
               return {
                 cancelled: false,
                 size: photo.fileSize,
-                type: photo.mimeType,
                 source: 'camera',
+                type: photo.mimeType,
                 uri: photo.uri,
                 ...size,
               };

package/native-package/src/optionalDependencies/takePhoto.ts

@@ -32,25 +32,30 @@ export const takePhoto = ImagePicker
       }
       try {
         const result = await ImagePicker.launchCamera({
-          mediaType: mediaType,
+          mediaType,
           quality: Math.min(Math.max(0, compressImageQuality), 1),
         });
-        if (!result.assets.length || result.didCancel) {
+        if (!result || !result.assets || !result.assets.length || result.didCancel) {
           return {
             cancelled: true,
           };
         }
         const asset = result.assets[0];
+        if (!asset) {
+          return {
+            cancelled: true,
+          };
+        }
         if (asset.type.includes('video')) {
           const clearFilter = new RegExp('[.:]', 'g');
           const date = new Date().toISOString().replace(clearFilter, '_');
           return {
             ...asset,
             cancelled: false,
             duration: asset.duration * 1000,
-            source: 'camera',
             name: 'video_recording_' + date + asset.fileName.split('.').pop(),
             size: asset.fileSize,
+            source: 'camera',
             type: asset.type,
             uri: asset.uri,
           };
@@ -82,9 +87,9 @@ export const takePhoto = ImagePicker
             }
             return {
               cancelled: false,
-              type: asset.type,
               size: asset.size,
               source: 'camera',
+              type: asset.type,
               uri: asset.uri,
               ...size,
             };