Skip to content

Commit c7a83b8

Browse files
authored
Merge pull request #550 from GetStream/overlay-reactions-customization-fix
change ordering of spread to account for undefined in props
2 parents 6d2c60c + 22ecc4b commit c7a83b8

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

src/components/MessageOverlay/MessageOverlay.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ import {
3131
import { OverlayReactionList as OverlayReactionListDefault } from './OverlayReactionList';
3232

3333
import { MessageTextContainer } from '../Message/MessageSimple/MessageTextContainer';
34+
import { MessageActions as DefaultMessageActions } from '../MessageOverlay/MessageActions';
35+
import { OverlayReactions as DefaultOverlayReactions } from '../MessageOverlay/OverlayReactions';
3436

3537
import {
3638
MessageOverlayContextValue,
@@ -131,15 +133,15 @@ const MessageOverlayWithContext = <
131133
images,
132134
message,
133135
messageActions,
134-
MessageActions,
136+
MessageActions = DefaultMessageActions,
135137
messageReactionTitle,
136138
messagesContext,
137139
onlyEmojis,
138140
otherAttachments,
139141
overlay,
140142
overlayOpacity,
141143
OverlayReactionList = OverlayReactionListDefault,
142-
OverlayReactions,
144+
OverlayReactions = DefaultOverlayReactions,
143145
reset,
144146
setOverlay,
145147
threadList,
@@ -687,18 +689,25 @@ export const MessageOverlay = <
687689
} = useMessageOverlayContext<At, Ch, Co, Ev, Me, Re, Us>();
688690
const { overlay, setOverlay } = useOverlayContext();
689691

692+
const componentProps = {
693+
MessageActions: props.MessageActions || MessageActions,
694+
OverlayReactionList:
695+
props.OverlayReactionList ||
696+
OverlayReactionList ||
697+
data?.OverlayReactionList,
698+
OverlayReactions: props.OverlayReactions || OverlayReactions,
699+
};
700+
690701
return (
691702
<MemoizedMessageOverlay
692703
{...(data || {})}
693704
{...{
694-
MessageActions,
695705
overlay,
696-
OverlayReactionList,
697-
OverlayReactions,
698706
reset,
699707
setOverlay,
700708
}}
701709
{...props}
710+
{...componentProps}
702711
/>
703712
);
704713
};

src/components/Thread/Thread.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ const ThreadWithContext = <
178178

179179
const replyCount = thread.reply_count;
180180

181-
const footerComponent = (
181+
const FooterComponent = () => (
182182
<View style={styles.threadHeaderContainer}>
183183
<View style={styles.messagePadding}>
184184
<Message
@@ -237,7 +237,7 @@ const ThreadWithContext = <
237237
return (
238238
<React.Fragment key={`thread-${thread.id}-${channel?.cid || ''}`}>
239239
<MessageList
240-
FooterComponent={footerComponent}
240+
FooterComponent={FooterComponent}
241241
threadList
242242
{...additionalMessageListProps}
243243
/>

src/contexts/overlayContext/OverlayProvider.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ import { FileSelectorIcon as DefaultFileSelectorIcon } from '../../components/At
3131
import { ImageOverlaySelectedComponent as DefaultImageOverlaySelectedComponent } from '../../components/AttachmentPicker/components/ImageOverlaySelectedComponent';
3232
import { ImageSelectorIcon as DefaultImageSelectorIcon } from '../../components/AttachmentPicker/components/ImageSelectorIcon';
3333
import { ImageGallery } from '../../components/ImageGallery/ImageGallery';
34-
import { MessageActions as DefaultMessageActions } from '../../components/MessageOverlay/MessageActions';
3534
import { MessageOverlay } from '../../components/MessageOverlay/MessageOverlay';
36-
import { OverlayReactionList as DefaultOverlayReactionList } from '../../components/MessageOverlay/OverlayReactionList';
37-
import { OverlayReactions as DefaultOverlayReactions } from '../../components/MessageOverlay/OverlayReactions';
3835
import { BlurView } from '../../native';
3936
import { useStreami18n } from '../../utils/useStreami18n';
4037

@@ -112,7 +109,7 @@ export const OverlayProvider = <
112109
imageGalleryGridSnapPoints,
113110
ImageOverlaySelectedComponent = DefaultImageOverlaySelectedComponent,
114111
ImageSelectorIcon = DefaultImageSelectorIcon,
115-
MessageActions = DefaultMessageActions,
112+
MessageActions,
116113
numberOfAttachmentImagesToLoadPerCall,
117114
numberOfAttachmentPickerImageColumns,
118115
numberOfImageGalleryGridColumns,
@@ -126,8 +123,8 @@ export const OverlayProvider = <
126123
}
127124
},
128125
topInset,
129-
OverlayReactionList = DefaultOverlayReactionList,
130-
OverlayReactions = DefaultOverlayReactions,
126+
OverlayReactionList,
127+
OverlayReactions,
131128
value,
132129
} = props;
133130

0 commit comments

Comments
 (0)