Skip to content

Commit 96f3aa9

Browse files
Revert package.json changes, adjust existing
1 parent e568a3e commit 96f3aa9

File tree

4 files changed

+54
-58
lines changed

4 files changed

+54
-58
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
"esbuild-plugin-replace": "^1.4.0",
226226
"eslint": "7.14.0",
227227
"eslint-config-airbnb": "^18.2.1",
228-
"eslint-config-prettier": "^9.1.0",
228+
"eslint-config-prettier": "^6.15.0",
229229
"eslint-config-react-app": "^6.0.0",
230230
"eslint-import-resolver-alias": "^1.1.2",
231231
"eslint-import-resolver-babel-module": "^5.2.0",
@@ -236,7 +236,7 @@
236236
"eslint-plugin-jest-dom": "^3.3.0",
237237
"eslint-plugin-jsx-a11y": "^6.4.1",
238238
"eslint-plugin-node": "^11.1.0",
239-
"eslint-plugin-prettier": "^5.2.1",
239+
"eslint-plugin-prettier": "^3.1.4",
240240
"eslint-plugin-promise": "^4.2.1",
241241
"eslint-plugin-react": "^7.21.5",
242242
"eslint-plugin-react-hooks": "^4.2.0",
@@ -252,7 +252,7 @@
252252
"jsdom": "^24.1.1",
253253
"lint-staged": "^15.2.1",
254254
"moment-timezone": "^0.5.43",
255-
"prettier": "^3.3.3",
255+
"prettier": "^2.2.0",
256256
"react": "^18.1.0",
257257
"react-dom": "^18.1.0",
258258
"react-test-renderer": "^18.1.0",

src/components/ChannelList/ChannelList.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const DEFAULT_OPTIONS = {};
3535
const DEFAULT_SORT = {};
3636

3737
export type ChannelListProps<
38-
StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics,
38+
StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics
3939
> = {
4040
/** Additional props for underlying ChannelSearch component and channel search controller, [available props](https://getstream.io/chat/docs/sdk/react/utility-components/channel_search/#props) */
4141
additionalChannelSearchProps?: Omit<ChannelSearchProps<StreamChatGenerics>, 'setChannels'>;
@@ -280,10 +280,9 @@ const UnMemoizedChannelList = <SCG extends DefaultStreamChatGenerics = DefaultSt
280280

281281
useMobileNavigation(channelListRef, navOpen, closeMobileNav);
282282

283-
const { customFn, defaultFn } = usePrepareShapeHandlers<SCG>({
283+
const { customHandler, defaultHandler } = usePrepareShapeHandlers<SCG>({
284284
allowNewMessagesFromUnfilteredChannels,
285285
filters,
286-
sort,
287286
lockChannelOrder,
288287
onAddedToChannel,
289288
onChannelDeleted,
@@ -295,11 +294,12 @@ const UnMemoizedChannelList = <SCG extends DefaultStreamChatGenerics = DefaultSt
295294
onMessageNewHandler,
296295
onRemovedFromChannel,
297296
setChannels,
297+
sort,
298298
// TODO: implement
299299
// customHandleChannelListShape
300300
});
301301

302-
useChannelListShape<SCG>(customFn ?? defaultFn);
302+
useChannelListShape<SCG>(customHandler ?? defaultHandler);
303303

304304
// TODO: maybe move this too
305305
useConnectionRecoveredListener(forceUpdate);

src/components/ChannelList/hooks/useChannelListShape.ts

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,17 @@ type HandleNotificationMessageNewParameters<SCG extends ExtendableGenerics> = Ba
4242
lockChannelOrder: boolean;
4343
} & Required<Pick<ChannelListProps<SCG>, 'filters' | 'sort'>>;
4444

45-
type HandleNotificationRemovedFromChannelParameters<SCG extends ExtendableGenerics> =
46-
BaseParameters<SCG> & RepeatedParameters<SCG>;
45+
type HandleNotificationRemovedFromChannelParameters<
46+
SCG extends ExtendableGenerics
47+
> = BaseParameters<SCG> & RepeatedParameters<SCG>;
4748

48-
type HandleNotificationAddedToChannelParameters<SCG extends ExtendableGenerics> =
49-
BaseParameters<SCG> &
50-
RepeatedParameters<SCG> & {
51-
allowNewMessagesFromUnfilteredChannels: boolean;
52-
lockChannelOrder: boolean;
53-
} & Required<Pick<ChannelListProps<SCG>, 'sort'>>;
49+
type HandleNotificationAddedToChannelParameters<
50+
SCG extends ExtendableGenerics
51+
> = BaseParameters<SCG> &
52+
RepeatedParameters<SCG> & {
53+
allowNewMessagesFromUnfilteredChannels: boolean;
54+
lockChannelOrder: boolean;
55+
} & Required<Pick<ChannelListProps<SCG>, 'sort'>>;
5456

5557
type HandleMemberUpdatedParameters<SCG extends ExtendableGenerics> = BaseParameters<SCG> & {
5658
lockChannelOrder: boolean;
@@ -99,12 +101,12 @@ export const useChannelListShapeDefaults = <SCG extends ExtendableGenerics>() =>
99101
const handleMessageNew = useCallback(
100102
({
101103
allowNewMessagesFromUnfilteredChannels,
102-
filters,
103-
sort,
104104
customHandler,
105105
event,
106+
filters,
106107
lockChannelOrder,
107108
setChannels,
109+
sort,
108110
}: HandleMessageNewParameters<SCG>) => {
109111
if (typeof customHandler === 'function') {
110112
return customHandler(setChannels, event);
@@ -159,11 +161,11 @@ export const useChannelListShapeDefaults = <SCG extends ExtendableGenerics>() =>
159161
const handleNotificationMessageNew = useCallback(
160162
async ({
161163
allowNewMessagesFromUnfilteredChannels,
162-
sort,
163-
filters,
164164
customHandler,
165165
event,
166+
filters,
166167
setChannels,
168+
sort,
167169
}: HandleNotificationMessageNewParameters<SCG>) => {
168170
if (typeof customHandler === 'function') {
169171
return customHandler(setChannels, event);
@@ -246,7 +248,7 @@ export const useChannelListShapeDefaults = <SCG extends ExtendableGenerics>() =>
246248
);
247249

248250
const handleMemberUpdated = useCallback(
249-
({ sort, event, lockChannelOrder, setChannels }: HandleMemberUpdatedParameters<SCG>) => {
251+
({ event, lockChannelOrder, setChannels, sort }: HandleMemberUpdatedParameters<SCG>) => {
250252
if (!event.member?.user || event.member.user.id !== client.userID || !event.channel_type) {
251253
return;
252254
}
@@ -258,7 +260,7 @@ export const useChannelListShapeDefaults = <SCG extends ExtendableGenerics>() =>
258260
const considerPinnedChannels = shouldConsiderPinnedChannels(sort);
259261

260262
// TODO: extract this and consider single property sort object too
261-
const pinnedAtSort = Array.isArray(sort) ? (sort[0]?.pinned_at ?? null) : null;
263+
const pinnedAtSort = Array.isArray(sort) ? sort[0]?.pinned_at ?? null : null;
262264

263265
setChannels((currentChannels) => {
264266
const targetChannel = client.channel(channelType, channelId);
@@ -448,17 +450,18 @@ type UseDefaultHandleChannelListShapeParameters<SCG extends ExtendableGenerics>
448450
| 'onMessageNewHandler'
449451
| 'onRemovedFromChannel'
450452
> & {
453+
setChannels: SetChannels<SCG>;
451454
customHandleChannelListShape?: (data: {
452-
defaults: ReturnType<typeof useChannelListShapeDefaults<SCG>>;
455+
defaults: ReturnType<typeof useChannelListShapeDefaults>;
453456
event: Event<SCG>;
454457
setChannels: SetChannels<SCG>;
455458
}) => void;
456-
setChannels: SetChannels<SCG>;
457459
};
458460

459461
export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
460462
allowNewMessagesFromUnfilteredChannels,
461463
customHandleChannelListShape,
464+
filters,
462465
lockChannelOrder,
463466
onAddedToChannel,
464467
onChannelDeleted,
@@ -470,7 +473,6 @@ export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
470473
onMessageNewHandler,
471474
onRemovedFromChannel,
472475
setChannels,
473-
filters,
474476
sort,
475477
}: UseDefaultHandleChannelListShapeParameters<SCG>) => {
476478
const defaults = useChannelListShapeDefaults<SCG>();
@@ -480,6 +482,7 @@ export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
480482
const customHandleChannelListShapeRef = useRef<(e: Event<SCG>) => void>();
481483

482484
customHandleChannelListShapeRef.current = (event: Event<SCG>) => {
485+
// @ts-expect-error can't use ReturnType<typeof useChannelListShapeDefaults<SCG>> until we upgrade prettier to at least v2.7.0
483486
customHandleChannelListShape?.({ defaults, event, setChannels });
484487
};
485488

@@ -488,33 +491,33 @@ export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
488491
case 'message.new':
489492
defaults.handleMessageNew({
490493
allowNewMessagesFromUnfilteredChannels,
491-
sort,
492-
filters,
493494
customHandler: onMessageNewHandler,
494495
event,
496+
filters,
495497
lockChannelOrder,
496498
setChannels,
499+
sort,
497500
});
498501
break;
499502
case 'notification.message_new':
500503
defaults.handleNotificationMessageNew({
501504
allowNewMessagesFromUnfilteredChannels,
502-
sort,
503-
filters,
504505
customHandler: onMessageNew,
505506
event,
507+
filters,
506508
lockChannelOrder,
507509
setChannels,
510+
sort,
508511
});
509512
break;
510513
case 'notification.added_to_channel':
511514
defaults.handleNotificationAddedToChannel({
512515
allowNewMessagesFromUnfilteredChannels,
513-
sort,
514516
customHandler: onAddedToChannel,
515517
event,
516518
lockChannelOrder,
517519
setChannels,
520+
sort,
518521
});
519522
break;
520523
case 'notification.removed_from_channel':
@@ -548,10 +551,10 @@ export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
548551
break;
549552
case 'member.updated':
550553
defaults.handleMemberUpdated({
551-
sort,
552554
event,
553555
lockChannelOrder,
554556
setChannels,
557+
sort,
555558
});
556559
break;
557560
default:
@@ -572,8 +575,8 @@ export const usePrepareShapeHandlers = <SCG extends ExtendableGenerics>({
572575
}, [customHandleChannelListShape]);
573576

574577
return {
575-
defaultFn,
576-
customFn,
578+
customHandler: customFn,
579+
defaultHandler: defaultFn,
577580
};
578581
};
579582

yarn.lock

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2114,11 +2114,6 @@
21142114
dependencies:
21152115
"@octokit/openapi-types" "^16.0.0"
21162116

2117-
"@pkgr/core@^0.1.0":
2118-
version "0.1.1"
2119-
resolved "https://registry.yarnpkg.com/@pkgr/core/-/core-0.1.1.tgz#1ec17e2edbec25c8306d424ecfbf13c7de1aaa31"
2120-
integrity sha512-cq8o4cWH0ibXh9VGi5P20Tu9XF/0fFXl9EUinr9QfTM7a7p0oTA4iJRCQWppXR1Pg8dSM0UCItCkPwsk9qWWYA==
2121-
21222117
"@playwright/test@^1.42.1":
21232118
version "1.42.1"
21242119
resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.42.1.tgz#9eff7417bcaa770e9e9a00439e078284b301f31c"
@@ -5653,10 +5648,12 @@ eslint-config-airbnb@^18.2.1:
56535648
object.assign "^4.1.2"
56545649
object.entries "^1.1.2"
56555650

5656-
eslint-config-prettier@^9.1.0:
5657-
version "9.1.0"
5658-
resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-9.1.0.tgz#31af3d94578645966c082fcb71a5846d3c94867f"
5659-
integrity sha512-NSWl5BFQWEPi1j4TjVNItzYV7dZXZ+wP6I6ZhrBGpChQhZRUaElihE9uRRkcbRnNb76UMKDF3r+WTmNcGPKsqw==
5651+
eslint-config-prettier@^6.15.0:
5652+
version "6.15.0"
5653+
resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-6.15.0.tgz#7f93f6cb7d45a92f1537a70ecc06366e1ac6fed9"
5654+
integrity sha512-a1+kOYLR8wMGustcgAjdydMsQ2A/2ipRPwRKUmfYaSxc9ZPcrku080Ctl6zrZzZNs/U82MjSv+qKREkoq3bJaw==
5655+
dependencies:
5656+
get-stdin "^6.0.0"
56605657

56615658
eslint-config-react-app@^6.0.0:
56625659
version "6.0.0"
@@ -5781,13 +5778,12 @@ eslint-plugin-node@^11.1.0:
57815778
resolve "^1.10.1"
57825779
semver "^6.1.0"
57835780

5784-
eslint-plugin-prettier@^5.2.1:
5785-
version "5.2.1"
5786-
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-5.2.1.tgz#d1c8f972d8f60e414c25465c163d16f209411f95"
5787-
integrity sha512-gH3iR3g4JfF+yYPaJYkN7jEl9QbweL/YfkoRlNnuIEHEz1vHVlCmWOS+eGGiRuzHQXdJFCOTxRgvju9b8VUmrw==
5781+
eslint-plugin-prettier@^3.1.4:
5782+
version "3.3.1"
5783+
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.3.1.tgz#7079cfa2497078905011e6f82e8dd8453d1371b7"
5784+
integrity sha512-Rq3jkcFY8RYeQLgk2cCwuc0P7SEFwDravPhsJZOQ5N4YI4DSg50NyqJ/9gdZHzQlHf8MvafSesbNJCcP/FF6pQ==
57885785
dependencies:
57895786
prettier-linter-helpers "^1.0.0"
5790-
synckit "^0.9.1"
57915787

57925788
eslint-plugin-promise@^4.2.1:
57935789
version "4.3.1"
@@ -6575,6 +6571,11 @@ get-port@^5.0.0:
65756571
resolved "https://registry.yarnpkg.com/get-port/-/get-port-5.1.1.tgz#0469ed07563479de6efb986baf053dcd7d4e3193"
65766572
integrity sha512-g/Q1aTSDOxFpchXC4i8ZWvxA1lnPqx/JHqcpIw0/LX9T8x/GBbi6YnlN5nhaKIFkT8oFsscUKgDJYxfwfS6QsQ==
65776573

6574+
get-stdin@^6.0.0:
6575+
version "6.0.0"
6576+
resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-6.0.0.tgz#9e09bf712b360ab9225e812048f71fde9c89657b"
6577+
integrity sha512-jp4tHawyV7+fkkSKyvjuLZswblUtz+SQKzSWnBbii16BuZksJlU1wuBYXY75r+duh/llF1ur6oNwi+2ZzjKZ7g==
6578+
65786579
get-stream@^6.0.0:
65796580
version "6.0.1"
65806581
resolved "https://registry.yarnpkg.com/get-stream/-/get-stream-6.0.1.tgz#a262d8eef67aced57c2852ad6167526a43cbf7b7"
@@ -10788,10 +10789,10 @@ prettier-linter-helpers@^1.0.0:
1078810789
dependencies:
1078910790
fast-diff "^1.1.2"
1079010791

10791-
prettier@^3.3.3:
10792-
version "3.3.3"
10793-
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.3.3.tgz#30c54fe0be0d8d12e6ae61dbb10109ea00d53105"
10794-
integrity sha512-i2tDNA0O5IrMO757lfrdQZCc2jPNDVntV0m/+4whiDfWaTKfMNgR7Qz0NAeGz/nRqF4m5/6CLzbP4/liHt12Ew==
10792+
prettier@^2.2.0:
10793+
version "2.2.1"
10794+
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.2.1.tgz#795a1a78dd52f073da0cd42b21f9c91381923ff5"
10795+
integrity sha512-PqyhM2yCjg/oKkFPtTGUojv7gnZAoG80ttl45O6x2Ug/rMJw4wcc9k6aaf2hibP7BGVCCM33gZoGjyvt9mm16Q==
1079510796

1079610797
pretty-format@^26.6.2:
1079710798
version "26.6.2"
@@ -12494,14 +12495,6 @@ symlink-or-copy@^1.1.8, symlink-or-copy@^1.2.0, symlink-or-copy@^1.3.1:
1249412495
resolved "https://registry.yarnpkg.com/symlink-or-copy/-/symlink-or-copy-1.3.1.tgz#9506dd64d8e98fa21dcbf4018d1eab23e77f71fe"
1249512496
integrity sha512-0K91MEXFpBUaywiwSSkmKjnGcasG/rVBXFLJz5DrgGabpYD6N+3yZrfD6uUIfpuTu65DZLHi7N8CizHc07BPZA==
1249612497

12497-
synckit@^0.9.1:
12498-
version "0.9.2"
12499-
resolved "https://registry.yarnpkg.com/synckit/-/synckit-0.9.2.tgz#a3a935eca7922d48b9e7d6c61822ee6c3ae4ec62"
12500-
integrity sha512-vrozgXDQwYO72vHjUb/HnFbQx1exDjoKzqx23aXEg2a9VIg2TSFZ8FmeZpTjUCFMYw7mpX4BE2SFu8wI7asYsw==
12501-
dependencies:
12502-
"@pkgr/core" "^0.1.0"
12503-
tslib "^2.6.2"
12504-
1250512498
table@^5.2.3:
1250612499
version "5.4.6"
1250712500
resolved "https://registry.yarnpkg.com/table/-/table-5.4.6.tgz#1292d19500ce3f86053b05f0e8e7e4a3bb21079e"

0 commit comments

Comments
 (0)