Skip to content

Commit ba0cd88

Browse files
committed
general clean up
1 parent 8fd5072 commit ba0cd88

File tree

7 files changed

+21
-21
lines changed

7 files changed

+21
-21
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,6 @@ Common mistakes that hurt performance are:
164164
- Mistake: Passing an object {} or an array [] that's not using seamless-immutable
165165
- Solution: Use an immutable type (i.e., a number or a string) or use a seamless immutable version of an object or an array
166166

167-
## Bundle Size
168-
169167
## Internationalisation
170168

171169
Instance of class `Streami18n` should be provided to the Chat component to handle translations.

emojiMartDataParser.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,19 @@ const defaultDataSetJson = fs.readFileSync(
1111
path.join(__dirname, 'node_modules', 'emoji-mart', 'data', 'facebook.json'),
1212
'utf8',
1313
);
14+
1415
const dataSet = JSON.parse(defaultDataSetJson);
16+
1517
const removeSkinTonesInfo = (emojiKey) => {
1618
if (dataSet.emojis[emojiKey].skin_variations) {
1719
delete dataSet.emojis[emojiKey].skin_variations;
1820
}
1921
};
22+
2023
Object.keys(dataSet.emojis).map(removeSkinTonesInfo);
24+
2125
const newDataSetJson = JSON.stringify(dataSet);
26+
2227
fs.writeFileSync(
2328
path.join(__dirname, 'src', 'stream-emoji.json'),
2429
newDataSetJson,

src/components/Chat/__tests__/Chat.test.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const TranslationContextConsumer = ({ fn }) => {
2222
fn(useContext(TranslationContext));
2323
return <div data-testid="children" />;
2424
};
25+
2526
describe('Chat', () => {
2627
afterEach(cleanup);
2728
const chatClient = getTestClient();
@@ -182,9 +183,7 @@ describe('Chat', () => {
182183

183184
describe('mutes', () => {
184185
it('init the mute state with client data', async () => {
185-
const chatClientWithUser = await getTestClientWithUser({
186-
id: 'user_x',
187-
});
186+
const chatClientWithUser = await getTestClientWithUser({ id: 'user_x' });
188187
// First load, mutes are initialized empty
189188
chatClientWithUser.user.mutes = [];
190189
let context;
@@ -215,9 +214,7 @@ describe('Chat', () => {
215214
});
216215

217216
it('chat client listens and updates the state on mute event', async () => {
218-
const chatClientWithUser = await getTestClientWithUser({
219-
id: 'user_x',
220-
});
217+
const chatClientWithUser = await getTestClientWithUser({ id: 'user_x' });
221218

222219
let context;
223220
render(

src/mock-builders/emojiContext.js renamed to src/mock-builders/generator/emoji.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import {
55
commonEmoji,
66
defaultMinimalEmojis,
77
emojiSetDef,
8-
} from '../components/Channel/emojiData';
9-
import emojiData from '../stream-emoji.json';
8+
} from '../../components/Channel/emojiData';
9+
import emojiData from '../../stream-emoji.json';
1010

1111
export const emojiMockConfig = {
1212
emojiData,
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
export * from './attachment';
12
export * from './channel';
2-
export * from './message';
3-
export * from './user';
3+
export * from './emoji';
44
export * from './member';
5+
export * from './message';
56
export * from './reaction';
6-
export * from './attachment';
7+
export * from './user';

src/mock-builders/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,3 @@ export const getRandomInt = (min, max) => {
5050
export * from './api';
5151
export * from './event';
5252
export * from './generator';
53-
export * from './emojiContext';

types/index.d.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ export interface EmojiConfig {
9191
emojiData: EmojiMartData;
9292
commonEmoji: commonEmojiInterface;
9393
defaultMinimalEmojis: MinimalEmojiInterface[];
94-
EmojiPicker: React.ElementType<NimblePickerProps> | null;
95-
EmojiIndex: NimbleEmojiIndex | null;
96-
Emoji: React.ElementType<NimbleEmojiProps> | null;
94+
EmojiPicker: React.ElementType<NimblePickerProps>;
95+
EmojiIndex: NimbleEmojiIndex;
96+
Emoji: React.ElementType<NimbleEmojiProps>;
9797
emojiSetDef: {
9898
spriteUrl: string;
9999
size: number;
@@ -189,10 +189,10 @@ export interface ChatProps {
189189

190190
export interface ChannelProps {
191191
channel?: Client.Channel;
192-
Emoji: React.ElementType<NimbleEmojiProps> | null;
193-
emojiData: EmojiMartData;
194-
EmojiIndex: NimbleEmojiIndex | null;
195-
EmojiPicker: React.ElementType<NimblePickerProps> | null;
192+
Emoji?: React.ElementType<NimbleEmojiProps>;
193+
emojiData?: EmojiMartData;
194+
EmojiIndex?: NimbleEmojiIndex;
195+
EmojiPicker?: React.ElementType<NimblePickerProps>;
196196
/** The loading indicator to use */
197197
LoadingIndicator?: React.ElementType<LoadingIndicatorProps>;
198198
LoadingErrorIndicator?: React.ElementType<LoadingErrorIndicatorProps>;

0 commit comments

Comments
 (0)