fix: remove messageDraftsEnabled flag from Channel props

Author: MartinCupela

src/components/Channel/Channel.tsx

@@ -157,7 +157,7 @@ type ChannelPropsForwardedToComponentContext = Pick<
 >;
 
 export type ChannelProps = ChannelPropsForwardedToComponentContext & {
-  // todo: move to MessageComposer configuration
+  // todo: X document the use of config.attachments.fileUploadFilter to replace acceptedFiles prop
   /** List of accepted file types */
   acceptedFiles?: string[];
   /** Custom handler function that runs when the active channel has unread messages and the app is running on a separate browser tab */
@@ -208,11 +208,10 @@ export type ChannelProps = ChannelPropsForwardedToComponentContext & {
   LoadingErrorIndicator?: React.ComponentType<LoadingErrorIndicatorProps>;
   /** Configuration parameter to mark the active channel as read when mounted (opened). By default, the channel is marked read on mount. */
   markReadOnMount?: boolean;
+  // todo: X document how maxNumberOfFiles can be customized with message composer
   /** Maximum number of attachments allowed per message */
   maxNumberOfFiles?: number;
-  /** Enables storing message drafts on the server. */
-  messageDraftsEnabled?: boolean;
-  // todo: document that multipleUploads is redundant and ignored with message composer
+  // todo: X document that multipleUploads is redundant and ignored with message composer
   /** Whether to allow multiple attachment uploads */
   multipleUploads?: boolean;
   /** Custom action handler function to run on click of an @mention in a message */
@@ -305,7 +304,6 @@ const ChannelInner = (
     LoadingIndicator = DefaultLoadingIndicator,
     markReadOnMount = true,
     maxNumberOfFiles,
-    messageDraftsEnabled,
     multipleUploads = true,
     onMentionsClick,
     onMentionsHover,
@@ -555,7 +553,7 @@ const ChannelInner = (
       }
 
       if (maxNumberOfFiles) {
-        // todo: this has to be configured via a template
+        // todo: X this has to be configured via a template
         channel.messageComposer.attachmentManager.config.maxNumberOfFilesPerMessage =
           maxNumberOfFiles;
       }
@@ -1081,8 +1079,6 @@ const ChannelInner = (
 
   const openThread = (message: LocalMessage, event?: React.BaseSyntheticEvent) => {
     event?.preventDefault();
-    // todo: revisit how to open a thread
-
     dispatch({ channel, message, type: 'openThread' });
   };
 
@@ -1161,7 +1157,6 @@ const ChannelInner = (
     imageAttachmentSizeHandler:
       props.imageAttachmentSizeHandler || getImageAttachmentConfiguration,
     maxNumberOfFiles,
-    messageDraftsEnabled,
     multipleUploads,
     mutes,
     notifications,

src/components/Channel/__tests__/Channel.test.js

@@ -597,7 +597,7 @@ describe('Channel', () => {
       });
       getThreadSpy.mockRestore();
     });
-
+    // todo: remove messageDraftsEnabled tests
     it('uses Thread instance when messageDraftsEnabled is true', async () => {
       const { channel, chatClient } = await initClient();
       const threadMessage = messages[0];

src/components/Channel/hooks/useCreateChannelStateContext.ts

@@ -27,7 +27,6 @@ export const useCreateChannelStateContext = (
     loadingMore,
     maxNumberOfFiles,
     members,
-    messageDraftsEnabled,
     messages = [],
     multipleUploads,
     mutes,
@@ -118,7 +117,6 @@ export const useCreateChannelStateContext = (
       loadingMore,
       maxNumberOfFiles,
       members,
-      messageDraftsEnabled,
       messages,
       multipleUploads,
       mutes,
@@ -151,7 +149,6 @@ export const useCreateChannelStateContext = (
       membersLength,
       memoizedMessageData,
       memoizedThreadMessageData,
-      messageDraftsEnabled,
       notificationsLength,
       readUsersLength,
       readUsersLastReads,

src/context/ChannelStateContext.tsx

@@ -22,18 +22,6 @@ export type ChannelNotifications = Array<{
   type: 'success' | 'error';
 }>;
 
-// todo: 1. create LocalMessage that would contain the below in stream-chat
-// todo: 2. move errorStatusCode, error to stream-chat
-// export type StreamMessage =
-//   // FIXME: we should use only one of the two (either formatted or unformatted)
-//   (ReturnType<StreamChannelState['formatMessage']> | MessageResponse) & {
-//     customType?: string;
-//     errorStatusCode?: number;
-//     error?: ErrorFromResponse<APIErrorResponse>;
-//     // editing?: boolean;
-//     // date?: Date;
-//   };
-
 export type ChannelState = {
   suppressAutoscroll: boolean;
   error?: Error | null;
@@ -71,7 +59,6 @@ export type ChannelStateContextValue = Omit<ChannelState, 'typing'> & {
   dragAndDropWindow?: boolean;
   giphyVersion?: GiphyVersions;
   maxNumberOfFiles?: number;
-  messageDraftsEnabled?: boolean;
   mutes?: Array<Mute>;
   watcher_count?: number;
 };