Skip to content

Commit e81fc69

Browse files
chore: update ESLint, migrate configuration file (#2574)
### 🎯 Goal Time to UPGRADE and migrate. :) PR is divided into multiple commits, ESLint changes, Prettier changes and manual changes - we can drop Prettier changes for `master` merges (so that I don't have to deal with merge conflicts) and merge this PR once our PR backlog is somewhat empty. #### Notable Changes - changed CI to run on Node@lts/* instead of v16 and v18 - adjusted `bundle-cjs.mjs` and `getPackageVersion.mjs` to use import for `package.json` instead (`with` assertion) - reduced Prettier print-width to 90 (from 100, default is 80) as some new formattings are just weird - omitted `eslint-plugin-prettier` as Prettier format step is included in CI anyway - explicitly installed `@testing-library/dom` as it's required by our tests and is no longer installed with `eslint-plugin-jest-dom` - `noUnusedParameters` and `noUnusedLocals` (`tsconfig.json`) are now set to `false` to not fail build steps, developers are still warned through ESLint - omitted certain other plugins since those weren't used apparently, compare against these old configs - [generated against Attachment.test.js](https://gist.github.com/arnautov-anton/9bdce867ed1ddf2b82a6f3f7a5bd9e04) and [against Attachment.tsx](https://gist.github.com/arnautov-anton/ee8dbdb8fda4906a0c436c21686e2105)
1 parent a4d6d83 commit e81fc69

File tree

399 files changed

+7309
-4966
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

399 files changed

+7309
-4966
lines changed

β€Ž.eslintignoreβ€Ž

Lines changed: 0 additions & 22 deletions
This file was deleted.

β€Ž.eslintrc.jsonβ€Ž

Lines changed: 0 additions & 230 deletions
This file was deleted.

β€Ž.github/workflows/ci.ymlβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
runs-on: ubuntu-latest
2828
strategy:
2929
matrix:
30-
node: [16, 18]
30+
node: [lts/*]
3131
name: Test with Node ${{ matrix.node }}
3232
steps:
3333
- uses: actions/checkout@v3

β€Ž.prettierrcβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"arrowParens": "always",
33
"jsxSingleQuote": true,
4-
"printWidth": 100,
4+
"printWidth": 90,
55
"singleQuote": true,
66
"tabWidth": 2,
77
"trailingComma": "all"

β€Že2e/fixtures/data/attachment.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable sort-keys */
1+
22
const smallImageAttachment = [
33
{
44
type: 'image',

0 commit comments

Comments
Β (0)