Skip to content

Commit ff4f6d3

Browse files
authored
refactor: make openThread and closeThread usable outside event listener context (#1923)
1 parent 62de38f commit ff4f6d3

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

docusaurus/docs/React/components/contexts/channel-action-context.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ The function to execute when @mention is hovered in a `message`, takes a DOM cli
146146

147147
### openThread
148148

149-
The function to execute when replies count button is clicked, takes the parent message of the `Thread` to be opened and a DOM click event.
149+
The function to execute when replies count button is clicked, takes the parent message of the `Thread` to be opened and optionally a DOM click event.
150150

151151
| Type |
152152
|----------|

docusaurus/docs/React/guides/customization/thread-header.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const CustomThreadHeader = ({ closeThread, thread }) => {
2727
))}
2828
<div className='reply-count'>{replyCount} Replies</div>
2929
</div>
30-
<div onClick={(event) => closeThread(event)} className='close-button'>
30+
<div onClick={closeThread} className='close-button'>
3131
<div className='left'>
3232
<div className='right'></div>
3333
</div>

src/components/Channel/Channel.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -748,9 +748,9 @@ const ChannelInner = <
748748

749749
const openThread = (
750750
message: StreamMessage<StreamChatGenerics>,
751-
event: React.BaseSyntheticEvent,
751+
event?: React.BaseSyntheticEvent,
752752
) => {
753-
event.preventDefault();
753+
event?.preventDefault();
754754
setQuotedMessage((current) => {
755755
if (current?.parent_id !== message?.parent_id) {
756756
return undefined;
@@ -761,8 +761,8 @@ const ChannelInner = <
761761
dispatch({ channel, message, type: 'openThread' });
762762
};
763763

764-
const closeThread = (event: React.BaseSyntheticEvent) => {
765-
event.preventDefault();
764+
const closeThread = (event?: React.BaseSyntheticEvent) => {
765+
event?.preventDefault();
766766
dispatch({ type: 'closeThread' });
767767
};
768768

src/components/Thread/ThreadHeader.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export type ThreadHeaderProps<
1515
StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics
1616
> = {
1717
/** Callback for closing the thread */
18-
closeThread: (event: React.BaseSyntheticEvent) => void;
18+
closeThread: (event?: React.BaseSyntheticEvent) => void;
1919
/** The thread parent message */
2020
thread: StreamMessage<StreamChatGenerics>;
2121
};
@@ -46,7 +46,7 @@ export const ThreadHeader = <
4646
aria-label='Close thread'
4747
className='str-chat__square-button str-chat__close-thread-button'
4848
data-testid='close-button'
49-
onClick={(event) => closeThread(event)}
49+
onClick={closeThread}
5050
>
5151
<CloseIcon />
5252
</button>

src/context/ChannelActionContext.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export type ChannelActionContextValue<
4343
StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics
4444
> = {
4545
addNotification: (text: string, type: 'success' | 'error') => void;
46-
closeThread: (event: React.BaseSyntheticEvent) => void;
46+
closeThread: (event?: React.BaseSyntheticEvent) => void;
4747
dispatch: React.Dispatch<ChannelStateReducerAction<StreamChatGenerics>>;
4848
editMessage: (
4949
message: UpdatedMessage<StreamChatGenerics>,

0 commit comments

Comments
 (0)