Skip to content

Commit 7c2d14a

Browse files
author
Daksh
committed
fix robocop
1 parent 68e2fd4 commit 7c2d14a

File tree

2 files changed

+25
-24
lines changed

2 files changed

+25
-24
lines changed

lib/stream-chat/client.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ def hard_delete_message(message_id)
441441
sig { params(message_id: String, user_id: String).returns(StreamChat::StreamResponse) }
442442
def delete_message_for_me(message_id, user_id)
443443
raise ArgumentError, 'user_id must not be empty for delete_for_me functionality' if user_id.to_s.empty?
444-
444+
445445
delete_message(message_id, delete_for_me: true, deleted_by: user_id)
446446
end
447447

@@ -450,13 +450,14 @@ def delete_message_for_me(message_id, user_id)
450450
def delete_message_with_options(message_id, hard: nil, delete_for_me: nil, user_id: nil)
451451
options = {}
452452
options[:hard] = true if hard
453-
453+
454454
if delete_for_me
455455
raise ArgumentError, 'user_id must not be empty for delete_for_me functionality' if user_id.to_s.empty?
456+
456457
options[:delete_for_me] = true
457458
options[:deleted_by] = user_id
458459
end
459-
460+
460461
delete_message(message_id, **options)
461462
end
462463

@@ -1102,7 +1103,7 @@ def make_http_request(method, relative_url, params: nil, data: nil)
11021103
headers['Authorization'] = @auth_token
11031104
headers['stream-auth-type'] = 'jwt'
11041105
params = {} if params.nil?
1105-
params = (get_default_params.merge(params).sort_by { |k, _v| k.to_s }).to_h
1106+
params = get_default_params.merge(params).sort_by { |k, _v| k.to_s }.to_h
11061107
url = "#{relative_url}?#{URI.encode_www_form(params)}"
11071108

11081109
body = data.to_json if %w[patch post put].include? method.to_s

spec/client_spec.rb

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ def loop_times(times)
425425

426426
it 'hard deletes a message using hard_delete_message method' do
427427
msg_id = SecureRandom.uuid
428-
428+
429429
# Try to send message, but don't fail if channel doesn't exist
430430
begin
431431
@channel.send_message({
@@ -436,20 +436,20 @@ def loop_times(times)
436436
# Skip test if channel doesn't exist in CI environment
437437
skip "Channel not available in CI environment: #{e.message}"
438438
end
439-
439+
440440
# Test the delete method - it may fail if message doesn't exist, but that's expected
441441
begin
442442
@client.hard_delete_message(msg_id)
443443
rescue StreamChat::StreamAPIException => e
444444
# This is expected if the message doesn't exist
445-
expect(e.message).to include("DeleteMessage failed")
445+
expect(e.message).to include('DeleteMessage failed')
446446
end
447447
end
448448

449449
it 'deletes a message for me using delete_message_for_me method' do
450450
msg_id = SecureRandom.uuid
451451
user_id = @random_user[:id]
452-
452+
453453
# Try to send message, but don't fail if channel doesn't exist
454454
begin
455455
@channel.send_message({
@@ -460,20 +460,20 @@ def loop_times(times)
460460
# Skip test if channel doesn't exist in CI environment
461461
skip "Channel not available in CI environment: #{e.message}"
462462
end
463-
463+
464464
# Test the delete method - it may fail if message doesn't exist, but that's expected
465465
begin
466466
@client.delete_message_for_me(msg_id, user_id)
467467
rescue StreamChat::StreamAPIException => e
468468
# This is expected if the message doesn't exist
469-
expect(e.message).to include("DeleteMessage failed")
469+
expect(e.message).to include('DeleteMessage failed')
470470
end
471471
end
472472

473473
it 'deletes a message with options using delete_message_with_options method' do
474474
msg_id = SecureRandom.uuid
475475
user_id = @random_user[:id]
476-
476+
477477
# Try to send message, but don't fail if channel doesn't exist
478478
begin
479479
@channel.send_message({
@@ -484,19 +484,19 @@ def loop_times(times)
484484
# Skip test if channel doesn't exist in CI environment
485485
skip "Channel not available in CI environment: #{e.message}"
486486
end
487-
487+
488488
# Test the delete method - it may fail if message doesn't exist, but that's expected
489489
begin
490490
@client.delete_message_with_options(msg_id, delete_for_me: true, user_id: user_id)
491491
rescue StreamChat::StreamAPIException => e
492492
# This is expected if the message doesn't exist
493-
expect(e.message).to include("DeleteMessage failed")
493+
expect(e.message).to include('DeleteMessage failed')
494494
end
495495
end
496496

497497
it 'hard deletes a message with options using delete_message_with_options method' do
498498
msg_id = SecureRandom.uuid
499-
499+
500500
# Try to send message, but don't fail if channel doesn't exist
501501
begin
502502
@channel.send_message({
@@ -507,19 +507,19 @@ def loop_times(times)
507507
# Skip test if channel doesn't exist in CI environment
508508
skip "Channel not available in CI environment: #{e.message}"
509509
end
510-
510+
511511
# Test the delete method - it may fail if message doesn't exist, but that's expected
512512
begin
513513
@client.delete_message_with_options(msg_id, hard: true)
514514
rescue StreamChat::StreamAPIException => e
515515
# This is expected if the message doesn't exist
516-
expect(e.message).to include("DeleteMessage failed")
516+
expect(e.message).to include('DeleteMessage failed')
517517
end
518518
end
519519

520520
it 'raises error when delete_for_me is true but user_id is empty' do
521521
msg_id = SecureRandom.uuid
522-
522+
523523
# Try to send message, but don't fail if channel doesn't exist
524524
begin
525525
@channel.send_message({
@@ -530,15 +530,15 @@ def loop_times(times)
530530
# Skip test if channel doesn't exist in CI environment
531531
skip "Channel not available in CI environment: #{e.message}"
532532
end
533-
534-
expect {
533+
534+
expect do
535535
@client.delete_message_for_me(msg_id, '')
536-
}.to raise_error(ArgumentError, 'user_id must not be empty for delete_for_me functionality')
536+
end.to raise_error(ArgumentError, 'user_id must not be empty for delete_for_me functionality')
537537
end
538538

539539
it 'raises error when delete_for_me is true but user_id is nil in delete_message_with_options' do
540540
msg_id = SecureRandom.uuid
541-
541+
542542
# Try to send message, but don't fail if channel doesn't exist
543543
begin
544544
@channel.send_message({
@@ -549,10 +549,10 @@ def loop_times(times)
549549
# Skip test if channel doesn't exist in CI environment
550550
skip "Channel not available in CI environment: #{e.message}"
551551
end
552-
553-
expect {
552+
553+
expect do
554554
@client.delete_message_with_options(msg_id, delete_for_me: true, user_id: nil)
555-
}.to raise_error(ArgumentError, 'user_id must not be empty for delete_for_me functionality')
555+
end.to raise_error(ArgumentError, 'user_id must not be empty for delete_for_me functionality')
556556
end
557557

558558
it 'undeletes a message' do

0 commit comments

Comments
 (0)