Fix minor issues (#53)

* Fix rubocop linting error

* Fix channel export test.

* Update Github action

Author: Eugene

.github/workflows/ci.yml

@@ -1,9 +1,9 @@
-name: build
+name: test
 
 on: [pull_request]
 
 jobs:
-  build:
+  test:
     runs-on: ubuntu-latest
     strategy:
       max-parallel: 1
@@ -12,15 +12,14 @@ jobs:
     name: Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
 
       - env:
           STREAM_CHAT_API_KEY: ${{ secrets.STREAM_CHAT_API_KEY }}
           STREAM_CHAT_API_SECRET: ${{ secrets.STREAM_CHAT_API_SECRET }}
         run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
           bundle exec rake rubocop
           bundle exec rake test

lib/stream-chat/client.rb

@@ -413,7 +413,7 @@ def make_http_request(method, relative_url, params: nil, data: nil)
       headers['Authorization'] = @auth_token
       headers['stream-auth-type'] = 'jwt'
       url = [@base_url, relative_url].join('/')
-      params = params.nil? ? {} : params
+      params = {} if params.nil?
       params = (get_default_params.merge(params).sort_by { |k, _v| k.to_s }).to_h
       url = "#{url}?#{URI.encode_www_form(params)}"
 

spec/client_spec.rb

@@ -364,7 +364,6 @@
 
     it 'should not block messages anymore' do
       resp = @channel.send_message({ text: 'put some sugar and fudge on that!' }, @random_user[:id])
-      puts resp
       expect(resp['message']['text']).to eq 'put some sugar and fudge on that!'
     end
 
@@ -414,7 +413,7 @@
       if resp['status'] == 'completed'
         expect(resp['result']).not_to be_empty
         expect(resp['result']['url']).not_to be_empty
-        expect(resp['error']).not_to be_empty
+        expect(resp).not_to include 'error'
         break
       end
       sleep(0.5)