Fix/pin unpin not working for messages with attachments (#842)

Author: nuno-vieira

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageContainerView.swift

@@ -296,6 +296,8 @@ public struct MessageContainerView<Factory: ViewFactory>: View {
         // This is needed for the LinkDetectionTextView to work properly.
         // TODO: This should be refactored on v5 so the TextView does not depend directly on the view model.
         .environment(\.messageViewModel, messageViewModel)
+        .onChange(of: message, perform: { message in messageViewModel.message = message })
+        .onChange(of: channel) { channel in messageViewModel.channel = channel }
     }
 
     private var maximumHorizontalSwipeDisplacement: CGFloat {

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageListHelperViews.swift

@@ -112,7 +112,7 @@ public struct MessageReadIndicatorView: View {
 
     public var body: some View {
         HStack(spacing: 2) {
-            if showReadCount && !readUsers.isEmpty {
+            if showReadCount && shouldShowReads {
                 Text("\(readUsers.count)")
                     .font(fonts.footnoteBold)
                     .foregroundColor(colors.tintColor)
@@ -122,7 +122,7 @@ public struct MessageReadIndicatorView: View {
                 uiImage: image
             )
             .customizable()
-            .foregroundColor(!readUsers.isEmpty ? colors.tintColor : Color(colors.textLowEmphasis))
+            .foregroundColor(shouldShowReads ? colors.tintColor : Color(colors.textLowEmphasis))
             .frame(height: 16)
             .opacity(localState == .sendingFailed || localState == .syncingFailed ? 0.0 : 1)
             .accessibilityLabel(
@@ -137,12 +137,16 @@ public struct MessageReadIndicatorView: View {
     }
 
     private var image: UIImage {
-        !readUsers.isEmpty ? images.readByAll : (isMessageSending ? images.messageReceiptSending : images.messageSent)
+        shouldShowReads ? images.readByAll : (isMessageSending ? images.messageReceiptSending : images.messageSent)
     }
 
     private var isMessageSending: Bool {
         localState == .sending || localState == .pendingSend || localState == .syncing
     }
+
+    private var shouldShowReads: Bool {
+        !readUsers.isEmpty && !isMessageSending
+    }
 }
 
 /// Message spacer view, used for adding space depending on who sent the message..

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageViewModel.swift

@@ -11,7 +11,7 @@ open class MessageViewModel: ObservableObject {
     @Injected(\.chatClient) private var chatClient
 
     @Published public internal(set) var message: ChatMessage
-    public private(set) var channel: ChatChannel?
+    @Published public internal(set) var channel: ChatChannel?
     private var cancellables = Set<AnyCancellable>()
 
     public init(

Sources/StreamChatSwiftUI/DefaultViewFactory.swift

@@ -1012,7 +1012,7 @@ extension ViewFactory {
             currentUserId: chatClient.currentUserId,
             message: message
         )
-        let showReadCount = channel.memberCount > 2
+        let showReadCount = channel.memberCount > 2 && !message.isLastActionFailed
         return MessageReadIndicatorView(
             readUsers: readUsers,
             showReadCount: showReadCount,

StreamChatSwiftUITests/Tests/ChatChannel/MessageReadIndicatorView_Tests.swift

@@ -85,6 +85,19 @@ class MessageReadIndicatorView_Tests: StreamChatTestCase {
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
     }
 
+    func test_messageReadIndicatorView_snapshotSyncing_whenShowReadCount() {
+        // Given
+        let view = MessageReadIndicatorView(
+            readUsers: [.mock(id: .unique)],
+            showReadCount: true,
+            localState: .syncing
+        )
+        .frame(width: 50, height: 16)
+
+        // Then
+        assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
+    }
+
     func test_messageReadIndicatorView_snapshotMessageFailed() {
         // Given
         let view = MessageReadIndicatorView(