Skip to content

Commit 0f23bb9

Browse files
committed
Fix tests issues
1 parent 1c141ee commit 0f23bb9

File tree

1 file changed

+2
-39
lines changed

1 file changed

+2
-39
lines changed

StreamChatSwiftUITests/Tests/ChatChannel/ChatChannelViewModel_Tests.swift

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ class ChatChannelViewModel_Tests: StreamChatTestCase {
598598
XCTAssertEqual(viewModel.scrolledId, message2.messageId)
599599
}
600600

601-
func test_chatChannelVM_selectedMessageThread_setsJumpToReplyId() {
601+
func test_chatChannelVM_selectedMessageThread_opensThread() {
602602
// Given
603603
let channelController = makeChannelController()
604604
let viewModel = ChatChannelViewModel(channelController: channelController)
@@ -619,10 +619,9 @@ class ChatChannelViewModel_Tests: StreamChatTestCase {
619619
// Then
620620
XCTAssertEqual(viewModel.threadMessage, message)
621621
XCTAssertTrue(viewModel.threadMessageShown)
622-
XCTAssertEqual(viewModel.messageCachingUtils.jumpToReplyId, message.messageId)
623622
}
624623

625-
func test_chatChannelVM_selectedMessageThread_withThreadReplyMessage() {
624+
func test_chatChannelVM_selectedMessageThread_withThreadReplyMessage_opensThread() {
626625
// Given
627626
let channelController = makeChannelController()
628627
let viewModel = ChatChannelViewModel(channelController: channelController)
@@ -653,42 +652,6 @@ class ChatChannelViewModel_Tests: StreamChatTestCase {
653652
// Then
654653
XCTAssertEqual(viewModel.threadMessage, parentMessage)
655654
XCTAssertTrue(viewModel.threadMessageShown)
656-
XCTAssertEqual(viewModel.messageCachingUtils.jumpToReplyId, replyMessage.messageId)
657-
}
658-
659-
func test_chatChannelVM_threadViewHighlightsMessage() {
660-
// Given
661-
let channelController = makeChannelController()
662-
let messageController = ChatMessageControllerSUI_Mock.mock(
663-
chatClient: chatClient,
664-
cid: .unique,
665-
messageId: .unique
666-
)
667-
let viewModel = ChatChannelViewModel(
668-
channelController: channelController,
669-
messageController: messageController
670-
)
671-
let replyMessageId = "reply-message-id"
672-
viewModel.messageCachingUtils.jumpToReplyId = replyMessageId
673-
let testExpectation = XCTestExpectation(description: "Highlight should be set in thread")
674-
testExpectation.assertForOverFulfill = false
675-
676-
// When - simulate the initialization path that checks jumpToReplyId
677-
DispatchQueue.main.asyncAfter(deadline: .now() + 0.6) {
678-
// Simulate thread view appearing and checking jumpToReplyId
679-
if let jumpToReplyId = viewModel.messageCachingUtils.jumpToReplyId {
680-
viewModel.scrolledId = jumpToReplyId
681-
DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
682-
viewModel.highlightedMessageId = jumpToReplyId
683-
testExpectation.fulfill()
684-
}
685-
}
686-
}
687-
688-
// Then
689-
wait(for: [testExpectation], timeout: 1.0)
690-
XCTAssertEqual(viewModel.highlightedMessageId, replyMessageId)
691-
XCTAssertEqual(viewModel.scrolledId, replyMessageId)
692655
}
693656

694657
func test_chatChannelVM_crashWhenIndexAccess() {

0 commit comments

Comments
 (0)