Fix updating bottom reactions (#557)

martinmitrevski · web-flow · commit 1db476bf32f2 · 2024-07-25T09:34:41.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 # Upcoming
 
 ### 🐞 Fixed
-- Media and files attachments not showing in channel info view [#552](https://github.com/GetStream/stream-chat-swiftui/pull/552)
+- Media and files attachments not showing in channel info view [#554](https://github.com/GetStream/stream-chat-swiftui/pull/554)
+- Bottom reactions configuration not always updating reactions [#557](https://github.com/GetStream/stream-chat-swiftui/pull/557)
 
 # [4.60.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.60.0)
 _July 19, 2024_
diff --git a/Sources/StreamChatSwiftUI/DefaultViewFactory.swift b/Sources/StreamChatSwiftUI/DefaultViewFactory.swift
@@ -823,6 +823,7 @@ extension ViewFactory {
             onTap: onTap,
             onLongPress: onLongPress
         )
+        .id(message.reactionScoresId)
     }
     
     public func makeMessageReactionView(
diff --git a/StreamChatSwiftUITests/Tests/Utils/ViewFactory_Tests.swift b/StreamChatSwiftUITests/Tests/Utils/ViewFactory_Tests.swift
@@ -861,9 +861,10 @@ class ViewFactory_Tests: StreamChatTestCase {
             onTap: {},
             onLongPress: {}
         )
-        
+        let name = String(describing: type(of: view))
+
         // Then
-        XCTAssert(view is BottomReactionsView)
+        XCTAssert(name.contains("BottomReactionsView"))
     }
     
     func test_viewFactory_makeCustomAttachmentQuotedView() {

Original file line number	Diff line number	Diff line change
`@@ -823,6 +823,7 @@ extension ViewFactory {`
`823`	`823`	`onTap: onTap,`
`824`	`824`	`onLongPress: onLongPress`
`825`	`825`	`)`
	`826`	`+ .id(message.reactionScoresId)`
`826`	`827`	`}`
`827`	`828`
`828`	`829`	`public func makeMessageReactionView(`
Original file line number	Diff line number	Diff line change
`@@ -861,9 +861,10 @@ class ViewFactory_Tests: StreamChatTestCase {`
`861`	`861`	`onTap: {},`
`862`	`862`	`onLongPress: {}`
`863`	`863`	`)`
`864`		`-`
	`864`	`+ let name = String(describing: type(of: view))`
	`865`	`+`
`865`	`866`	`// Then`
`866`		`- XCTAssert(view is BottomReactionsView)`
	`867`	`+ XCTAssert(name.contains("BottomReactionsView"))`
`867`	`868`	`}`
`868`	`869`
`869`	`870`	`func test_viewFactory_makeCustomAttachmentQuotedView() {`