[CI] Improve linters and git hooks (#880)

Author: testableapple

.github/workflows/cron-checks.yml

@@ -142,7 +142,7 @@ jobs:
     - uses: actions/[email protected]
     - uses: ./.github/actions/bootstrap
     - run: bundle exec fastlane rubocop
-    - run: ./Scripts/run-linter.sh
+    - run: bundle exec fastlane run_swift_format strict:true
     - run: bundle exec fastlane pod_lint
 
   slack:

.github/workflows/smoke-checks.yml

@@ -53,15 +53,11 @@ jobs:
     steps:
     - uses: actions/[email protected]
     - uses: ./.github/actions/bootstrap
-    - name: Run Danger
-      run: bundle exec fastlane lint_pr
-    - name: Run Fastlane Linting
-      run: bundle exec fastlane rubocop
-    - name: Run SwiftFormat Linting
-      run: ./Scripts/run-linter.sh
-    - name: Run Podspec Linting
+    - run: bundle exec fastlane lint_pr
+    - run: bundle exec fastlane rubocop
+    - run: bundle exec fastlane run_swift_format strict:true
+    - run: bundle exec fastlane pod_lint
       if: startsWith(github.event.pull_request.head.ref, 'release/')
-      run: bundle exec fastlane pod_lint
 
   build-xcode15:
     name: Build SDKs (Xcode 15)

.swiftformat

@@ -6,7 +6,10 @@
 --disable redundantType
 --disable extensionAccessControl
 --disable andOperator
---disable blankLinesAtStartOfScope
+--disable hoistPatternLet
+--disable typeSugar
+
+--disable redundantGet # it removes get async throws from getters
 
 # Rules inferred from Swift Standard Library:
 --disable anyObjectProtocol, wrapMultilineStatementBraces
@@ -18,7 +21,6 @@
 --commas inline
 --trimwhitespace nonblank-lines
 --stripunusedargs closure-only
---maxwidth 132
 
 --binarygrouping 4,7
 --octalgrouping none

.swiftlint.yml

@@ -0,0 +1,56 @@
+included:
+  - Sources
+  - DemoAppSwiftUI
+excluded:
+  - Sources/StreamChatSwiftUI/Generated
+  - Sources/StreamChatSwiftUI/StreamSwiftyGif
+  - Sources/StreamChatSwiftUI/StreamNuke
+
+only_rules:
+  # Currently enabled autocorrectable rules
+  - attribute_name_spacing
+  - closing_brace
+  - colon
+  - comma
+  - comment_spacing
+  - control_statement
+  - custom_rules
+  - duplicate_imports
+  - empty_enum_arguments
+  - empty_parameters
+  - empty_parentheses_with_trailing_closure
+  - explicit_init
+  - joined_default_parameter
+  - leading_whitespace
+  - legacy_cggeometry_functions
+  - legacy_constant
+  - legacy_constructor
+  - legacy_nsgeometry_functions
+  - mark
+  - no_space_in_method_call
+  - prefer_type_checking
+  - private_over_fileprivate
+  - private_unit_test
+  - protocol_property_accessors_order
+  - redundant_discardable_let
+  - redundant_objc_attribute
+  - redundant_optional_initialization
+  - redundant_sendable
+  - redundant_void_return
+  - return_arrow_whitespace
+  - syntactic_sugar
+  - toggle_bool
+  - trailing_comma
+  - trailing_newline
+  - trailing_semicolon
+  - trailing_whitespace
+  - unneeded_break_in_switch
+  - unneeded_override
+  - unused_closure_parameter
+  - unused_control_flow_label
+  - unused_import
+  - vertical_whitespace
+  - void_return
+
+trailing_whitespace:
+  ignores_empty_lines: true

DemoAppSwiftUI/AppDelegate.swift

@@ -10,7 +10,6 @@ import SwiftUI
 import UIKit
 
 class AppDelegate: NSObject, UIApplicationDelegate {
-
     var streamChat: StreamChat?
 
     var chatClient: ChatClient = {

DemoAppSwiftUI/AppleMessageComposerView.swift

@@ -8,7 +8,6 @@ import SwiftUI
 
 @available(iOS 15.0, *)
 struct AppleMessageComposerView<Factory: ViewFactory>: View, KeyboardReadable {
-        
     @State var text = ""
     @State var shouldShow = false
 
@@ -214,7 +213,7 @@ struct BlurredBackground: View {
 }
 
 struct HeightPreferenceKey: PreferenceKey {
-    static var defaultValue: CGFloat? = nil
+    static var defaultValue: CGFloat?
 
     static func reduce(value: inout CGFloat?, nextValue: () -> CGFloat?) {
         value = value ?? nextValue()
@@ -241,7 +240,6 @@ struct ComposerAction: Equatable, Identifiable {
 
 @available(iOS 15.0, *)
 struct ComposerActionsView: View {
-    
     @ObservedObject var viewModel: MessageComposerViewModel
 
     @State var composerActions: [ComposerAction] = []
@@ -346,7 +344,6 @@ struct ComposerActionsView: View {
 }
 
 struct ComposerActionView: View {
-    
     private let imageSize: CGFloat = 34
 
     var composerAction: ComposerAction

DemoAppSwiftUI/ChannelHeader/BlockedUsersView.swift

@@ -6,7 +6,6 @@ import StreamChatSwiftUI
 import SwiftUI
 
 struct BlockedUsersView: View {
-    
     @StateObject var viewModel = BlockedUsersViewModel()
 
     var body: some View {

DemoAppSwiftUI/ChannelHeader/BlockedUsersViewModel.swift

@@ -7,7 +7,6 @@ import StreamChatSwiftUI
 import SwiftUI
 
 class BlockedUsersViewModel: ObservableObject {
-    
     @Injected(\.chatClient) var chatClient
 
     @Published var blockedUsers = [ChatUser]()

DemoAppSwiftUI/ChannelHeader/CustomChannelHeader.swift

@@ -7,7 +7,6 @@ import StreamChatSwiftUI
 import SwiftUI
 
 public struct CustomChannelHeader: ToolbarContent {
-
     @Injected(\.fonts) var fonts
     @Injected(\.images) var images
     @Injected(\.colors) var colors
@@ -51,7 +50,6 @@ public struct CustomChannelHeader: ToolbarContent {
 }
 
 struct CustomChannelModifier: ChannelListHeaderViewModifier {
-
     @Injected(\.chatClient) var chatClient
 
     var title: String

DemoAppSwiftUI/ChannelHeader/NewChatView.swift

@@ -7,7 +7,6 @@ import StreamChatSwiftUI
 import SwiftUI
 
 struct NewChatView: View, KeyboardReadable {
-
     @Injected(\.fonts) var fonts
     @Injected(\.colors) var colors
 
@@ -106,7 +105,6 @@ struct NewChatView: View, KeyboardReadable {
 }
 
 struct TabBarVisibilityModifier: ViewModifier {
-    
     func body(content: Content) -> some View {
         if #available(iOS 16.0, *) {
             content.toolbar(.hidden, for: .tabBar)
@@ -117,7 +115,6 @@ struct TabBarVisibilityModifier: ViewModifier {
 }
 
 struct SelectedUserView: View {
-
     @Injected(\.colors) var colors
 
     var user: ChatUser
@@ -140,7 +137,6 @@ struct SelectedUserView: View {
 }
 
 struct SearchUsersView: View {
-
     @StateObject var viewModel: NewChatViewModel
 
     var body: some View {
@@ -160,7 +156,6 @@ struct SearchUsersView: View {
 }
 
 struct VerticallyCenteredView<Content: View>: View {
-
     var content: () -> Content
 
     var body: some View {
@@ -173,7 +168,6 @@ struct VerticallyCenteredView<Content: View>: View {
 }
 
 struct CreateGroupButton: View {
-
     @Injected(\.colors) var colors
     @Injected(\.fonts) var fonts
 
@@ -201,7 +195,6 @@ struct CreateGroupButton: View {
 }
 
 struct ChatUserView: View {
-
     @Injected(\.colors) var colors
     @Injected(\.fonts) var fonts
 
@@ -235,7 +228,6 @@ struct ChatUserView: View {
 }
 
 struct UsersHeaderView: View {
-
     @Injected(\.colors) var colors
     @Injected(\.fonts) var fonts