performance improvements

Author: martinmitrevski

Sources/StreamChatSwiftUI/ChatChannel/ChatChannelView.swift

@@ -36,6 +36,7 @@ public struct ChatChannelView<Factory: ViewFactory>: View {
                 currentDateString: viewModel.currentDateString,
                 isGroup: !viewModel.channel.isDirectMessageChannel,
                 unreadCount: viewModel.channel.unreadCount.messages,
+                listId: viewModel.listId,
                 onMessageAppear: viewModel.handleMessageAppear(index:),
                 onScrollToBottom: viewModel.scrollToLastMessage,
                 onLongPress: { displayInfo in

Sources/StreamChatSwiftUI/ChatChannel/ChatChannelViewModel.swift

@@ -12,6 +12,8 @@ public class ChatChannelViewModel: ObservableObject, ChatChannelControllerDelega
     @Injected(\.utils) var utils
 
     private var cancellables = Set<AnyCancellable>()
+    private var lastRefreshThreshold = 200
+    private let refreshThreshold = 200
     private var timer: Timer?
     private var currentDate: Date? {
         didSet {
@@ -38,6 +40,7 @@ public class ChatChannelViewModel: ObservableObject, ChatChannelControllerDelega
     var channelController: ChatChannelController
 
     @Published var scrolledId: String?
+    @Published var listId = UUID().uuidString
 
     @Published var showScrollToLatestButton = false
     @Published var currentDateString: String?
@@ -120,6 +123,12 @@ public class ChatChannelViewModel: ObservableObject, ChatChannelControllerDelega
     ) {
         messages = channelController.messages
 
+        let count = channelController.messages.count
+        if count > lastRefreshThreshold {
+            lastRefreshThreshold = lastRefreshThreshold + refreshThreshold
+            listId = UUID().uuidString
+        }
+        
         if !showScrollToLatestButton {
             scrollToLastMessage()
         }
@@ -168,10 +177,13 @@ public class ChatChannelViewModel: ObservableObject, ChatChannelControllerDelega
         }
 
         if _loadingPreviousMessages.compareAndSwap(old: false, new: true) {
-            channelController.loadPreviousMessages(limit: 250, completion: { [weak self] _ in
-                guard let self = self else { return }
-                self.loadingPreviousMessages = false
-            })
+            channelController.loadPreviousMessages(
+                limit: refreshThreshold,
+                completion: { [weak self] _ in
+                    guard let self = self else { return }
+                    self.loadingPreviousMessages = false
+                }
+            )
         }
     }
 

Sources/StreamChatSwiftUI/ChatChannel/MessageList/LinkAttachmentView.swift

@@ -63,6 +63,7 @@ public struct LinkAttachmentView: View {
             if !imageHidden {
                 ZStack {
                     LazyImage(source: linkAttachment.previewURL!)
+                        .onDisappear(.reset)
                         .processors([ImageProcessors.Resize(width: width)])
                         .priority(.high)
                         .frame(width: width - 2 * padding, height: (width - 2 * padding) / 2)

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageAvatarView.swift

@@ -23,20 +23,20 @@ public struct MessageAvatarView: View {
             )
 
             LazyImage(source: adjustedURL)
+                .onDisappear(.reset)
                 .clipShape(Circle())
                 .frame(
                     width: CGSize.messageAvatarSize.width,
                     height: CGSize.messageAvatarSize.height
                 )
-                .id(url)
+            
         } else {
             Image(systemName: "person.circle")
                 .resizable()
                 .frame(
                     width: CGSize.messageAvatarSize.width,
                     height: CGSize.messageAvatarSize.height
                 )
-                .id("placeholder")
         }
     }
 }

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageListView.swift

@@ -16,6 +16,7 @@ struct MessageListView<Factory: ViewFactory>: View, KeyboardReadable {
     var currentDateString: String?
     var isGroup: Bool
     var unreadCount: Int
+    var listId: String
 
     var onMessageAppear: (Int) -> Void
     var onScrollToBottom: () -> Void
@@ -89,6 +90,7 @@ struct MessageListView<Factory: ViewFactory>: View, KeyboardReadable {
                                 }
                             }
                         }
+                        .id(listId)
                     }
                 }
                 .coordinateSpace(name: scrollAreaId)