Fixed PR remarks

Author: martinmitrevski

Sources/StreamChatSwiftUI/ChatChannel/ChannelHeader/ChatChannelHeaderViewModifier.swift

@@ -25,6 +25,19 @@ public struct DefaultChatChannelHeader: ToolbarContent {
         chatClient.currentUserId ?? ""
     }
 
+    private var shouldShowTypingIndicator: Bool {
+        !channel.currentlyTypingUsersFiltered(currentUserId: currentUserId).isEmpty
+            && utils.typingIndicatorPlacement == .navigationBar
+            && channel.config.typingEventsEnabled
+    }
+    
+    private var onlineIndicatorShown: Bool {
+        !channel.lastActiveMembers.filter { member in
+            member.id != chatClient.currentUserId && member.isOnline
+        }
+        .isEmpty
+    }
+    
     public var channel: ChatChannel
     public var headerImage: UIImage
 
@@ -55,19 +68,6 @@ public struct DefaultChatChannelHeader: ToolbarContent {
             .offset(x: 8)
         }
     }
-    
-    private var shouldShowTypingIndicator: Bool {
-        !channel.currentlyTypingUsersFiltered(currentUserId: currentUserId).isEmpty
-            && utils.typingIndicatorPlacement == .navigationBar
-            && channel.config.typingEventsEnabled
-    }
-    
-    private var onlineIndicatorShown: Bool {
-        !channel.lastActiveMembers.filter { member in
-            member.id != chatClient.currentUserId && member.isOnline
-        }
-        .isEmpty
-    }
 }
 
 /// The default header modifier.

Sources/StreamChatSwiftUI/ChatChannel/Composer/AttachmentPickerTypeView.swift

@@ -33,6 +33,10 @@ public struct AttachmentPickerTypeView: View {
     @Binding var pickerTypeState: PickerTypeState
     var channelConfig: ChannelConfig?
 
+    private var commandsAvailable: Bool {
+        channelConfig?.commands.count ?? 0 > 0
+    }
+    
     public var body: some View {
         HStack(spacing: 16) {
             switch pickerTypeState {
@@ -45,7 +49,7 @@ public struct AttachmentPickerTypeView: View {
                     )
                 }
 
-                if channelConfig?.commands.count ?? 0 > 0 {
+                if commandsAvailable {
                     PickerTypeButton(
                         pickerTypeState: $pickerTypeState,
                         pickerType: .instantCommands,

Sources/StreamChatSwiftUI/ChatChannel/Composer/ComposerTextInputView.swift

@@ -63,7 +63,8 @@ struct ComposerTextInputView: UIViewRepresentable {
             replacementText text: String
         ) -> Bool {
             guard let maxMessageLength = maxMessageLength else { return true }
-            return textView.text.count + (text.count - range.length) <= maxMessageLength
+            let newMessageLength = textView.text.count + (text.count - range.length)
+            return newMessageLength <= maxMessageLength
         }
 
         func layoutManager(

Sources/StreamChatSwiftUI/ChatChannel/Composer/MessageComposerViewModel.swift

@@ -240,7 +240,9 @@ open class MessageComposerViewModel: ObservableObject {
     }
 
     public var showCommandsOverlay: Bool {
-        composerCommand != nil && channelController.channel?.config.commands.count ?? 0 > 0
+        let commandAvailable = composerCommand != nil
+        let configuredCommandsAvailable = channelController.channel?.config.commands.count ?? 0 > 0
+        return commandAvailable && configuredCommandsAvailable
     }
 
     public func change(pickerState: AttachmentPickerState) {

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageListView.swift

@@ -35,6 +35,12 @@ struct MessageListView<Factory: ViewFactory>: View, KeyboardReadable {
         utils.dateFormatter
     }
 
+    private var shouldShowTypingIndicator: Bool {
+        !channel.currentlyTypingUsersFiltered(currentUserId: chatClient.currentUserId).isEmpty
+            && utils.typingIndicatorPlacement == .bottomOverlay
+            && channel.config.typingEventsEnabled
+    }
+    
     private let scrollAreaId = "scrollArea"
 
     var body: some View {
@@ -168,12 +174,6 @@ struct MessageListView<Factory: ViewFactory>: View, KeyboardReadable {
         .modifier(HideKeyboardOnTapGesture(shouldAdd: keyboardShown))
     }
 
-    private var shouldShowTypingIndicator: Bool {
-        !channel.currentlyTypingUsersFiltered(currentUserId: chatClient.currentUserId).isEmpty
-            && utils.typingIndicatorPlacement == .bottomOverlay
-            && channel.config.typingEventsEnabled
-    }
-    
     private func showsAllData(for message: ChatMessage) -> Bool {
         let dateString = dateFormatter.string(from: message.createdAt)
         let prefix = message.author.id

docusaurus/docs/iOS/swiftui/components/message-composer.md

@@ -17,7 +17,7 @@ You can completely swap the leading composer view with your own implementation.
 
 In order to do this, you need to implement the `makeLeadingComposerView`, which receives a binding of the `PickerTypeState`. Having the `PickerTypeState` as a parameter allows you to control the visibility of the attachment picker view. The `PickerTypeState` has two states - expanded and collapsed. If the state is collapsed, the composer is in the minimal mode (only the text input and leading and trailing areas are shown). If the enum state is expanded, it has associated value with it, which is of type `AttachmentPickerType`. This defines the type of picker which is currently displayed in the attachment picker view. The possible states are `none` (nothing is selected), `media` (media picker is selected), `giphy` (giphy commands picker is shown) and custom (for your own custom pickers).
 
-Apart from the `PickerTypeState`, you also receive the `ChannelConfig` as a parameter. This config allows you to control the display of some elements from the channel response from the backend, such as enabling / disabling of the attachments, max message length, typing indicators, etc.
+Apart from the `PickerTypeState`, you also receive the `ChannelConfig` as a parameter. This config allows you to control the display of some elements from the channel response from the backend, such as enabling / disabling of the attachments, max message length, typing indicators, etc. More details about the available settings in the channel config can be found [here](https://getstream.io/chat/docs/ios-swift/channel_features/?language=swift).
 
 Here's an example on how to provide a view for the leading composer view: