CI adjustments (#537)

Author: testableapple

.github/workflows/smoke-checks.yml

@@ -44,6 +44,53 @@ jobs:
           derived_data/Build/**/*.xctestrun
           derived_data/Build/**/*.framework
 
+  automated-code-review:
+    name: Automated Code Review
+    runs-on: macos-13
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      GITHUB_PR_NUM: ${{ github.event.number }}
+      XCODE_VERSION: "15.0.1"
+    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
+    steps:
+    - uses: actions/[email protected]
+    - uses: ./.github/actions/bootstrap
+    - name: Run Danger
+      run: bundle exec danger
+    - name: Run Fastlane Linting
+      run: bundle exec fastlane rubocop
+    - name: Run SwiftFormat Linting
+      run: ./Scripts/run-linter.sh
+    - name: Run Podspec Linting
+      if: startsWith(github.event.pull_request.head.ref, 'release/')
+      run: bundle exec fastlane pod_lint
+
+  build-xcode15:
+    name: Build SDKs (Xcode 15.0)
+    runs-on: macos-13
+    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
+    env:
+      XCODE_VERSION: "15.0.1"
+    steps:
+    - uses: actions/[email protected]
+    - uses: ./.github/actions/ruby-cache
+    - name: List Xcode versions
+      run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"
+      timeout-minutes: 25
+    - name: Build SwiftUI
+      run: bundle exec fastlane test_ui device:"iPhone 15" build_for_testing:true
+      timeout-minutes: 25
+    - name: Install Bot SSH Key
+      uses: webfactory/[email protected]
+      with:
+        ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }}
+    - name: Build XCFrameworks
+      run: bundle exec fastlane build_xcframeworks
+      timeout-minutes: 25
+      env:
+        MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
+        APPSTORE_API_KEY: ${{ secrets.APPSTORE_API_KEY }}
+
   test-ui-debug:
     name: Test SwiftUI (Debug)
     runs-on: macos-14
@@ -103,12 +150,33 @@ jobs:
           fastlane/test_output/logs/*/Diagnostics/**/*.txt
           fastlane/test_output/logs/*/Diagnostics/simctl_diagnostics/DiagnosticReports/*
 
+  allure_testops_launch:
+    name: Launch Allure TestOps
+    runs-on: macos-13
+    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
+    needs: test-ui-debug
+    outputs:
+      launch_id: ${{ steps.get_launch_id.outputs.launch_id }}
+    steps:
+    - uses: actions/[email protected]
+    - uses: ./.github/actions/ruby-cache
+    - name: Launch Allure TestOps
+      run: bundle exec fastlane allure_launch
+      env:
+        ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }}
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GITHUB_EVENT: ${{ toJson(github.event) }}
+    - id: get_launch_id
+      run: echo "launch_id=${{env.LAUNCH_ID}}" >> $GITHUB_OUTPUT
+      if: env.LAUNCH_ID != ''
+
   test-e2e-debug:
     name: Test E2E UI (Debug)
     runs-on: macos-14
     if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
     needs:
       - allure_testops_launch
+      - test-ui-debug
       - build-test-app-and-frameworks
     env:
       LAUNCH_ID: ${{ needs.allure_testops_launch.outputs.launch_id }}
@@ -164,29 +232,12 @@ jobs:
           fastlane/test_output/logs/*/Diagnostics/**/*.txt
           fastlane/test_output/logs/*/Diagnostics/simctl_diagnostics/DiagnosticReports/*
 
-  allure_testops_launch:
-    name: Launch Allure TestOps
-    runs-on: macos-13
-    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
-    outputs:
-      launch_id: ${{ steps.get_launch_id.outputs.launch_id }}
-    steps:
-    - uses: actions/[email protected]
-    - uses: ./.github/actions/ruby-cache
-    - name: Launch Allure TestOps
-      run: bundle exec fastlane allure_launch
-      env:
-        ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }}
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        GITHUB_EVENT: ${{ toJson(github.event) }}
-    - id: get_launch_id
-      run: echo "launch_id=${{env.LAUNCH_ID}}" >> $GITHUB_OUTPUT
-      if: env.LAUNCH_ID != ''
-
   build-apps:
     name: Build Demo App
     runs-on: macos-14
-    needs: build-test-app-and-frameworks
+    needs:
+      - build-test-app-and-frameworks
+      - test-ui-debug
     if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
     steps:
     - uses: actions/[email protected]
@@ -198,49 +249,3 @@ jobs:
     - uses: ./.github/actions/xcode-cache
     - name: Build Demo App
       run: bundle exec fastlane build_demo
-
-  build-xcode15:
-    name: Build SDKs (Xcode 15.0)
-    runs-on: macos-13
-    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
-    env:
-      XCODE_VERSION: "15.0.1"
-    steps:
-    - uses: actions/[email protected]
-    - uses: ./.github/actions/ruby-cache
-    - name: List Xcode versions
-      run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"
-      timeout-minutes: 25
-    - name: Build SwiftUI
-      run: bundle exec fastlane test_ui device:"iPhone 15" build_for_testing:true
-      timeout-minutes: 25
-    - name: Install Bot SSH Key
-      uses: webfactory/[email protected]
-      with:
-        ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }}
-    - name: Build XCFrameworks
-      run: bundle exec fastlane build_xcframeworks
-      timeout-minutes: 25
-      env:
-        MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
-        APPSTORE_API_KEY: ${{ secrets.APPSTORE_API_KEY }}
-
-  automated-code-review:
-    name: Automated Code Review
-    runs-on: macos-13
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      GITHUB_PR_NUM: ${{ github.event.number }}
-      XCODE_VERSION: "15.0.1"
-    if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }}
-    steps:
-    - uses: actions/[email protected]
-    - uses: ./.github/actions/bootstrap
-    - name: Run Danger
-      run: bundle exec danger
-    - name: Run Fastlane Linting
-      run: bundle exec fastlane rubocop
-    - name: Run SwiftFormat Linting
-      run: ./Scripts/run-linter.sh
-    - name: Run Podspec Linting
-      run: bundle exec fastlane pod_lint