Fixes to the channel list item

Author: martinmitrevski

Sources/StreamChatSwiftUI/ChatChannelList/ChatChannelList.swift

@@ -54,7 +54,7 @@ public struct ChannelList<Factory: ViewFactory>: View {
 
     public var body: some View {
         ScrollView {
-            LazyVStack {
+            LazyVStack(spacing: 0) {
                 ForEach(channels) { channel in
                     factory.makeChannelListItem(
                         channel: channel,
@@ -70,7 +70,6 @@ public struct ChannelList<Factory: ViewFactory>: View {
                         trailingSwipeLeftButtonTapped: trailingSwipeLeftButtonTapped,
                         leadingSwipeButtonTapped: leadingSwipeButtonTapped
                     )
-                    .frame(height: 48)
                     .onAppear {
                         if let index = channels.firstIndex(where: { chatChannel in
                             chatChannel.id == channel.id

Sources/StreamChatSwiftUI/ChatChannelList/ChatChannelListItem.swift

@@ -22,54 +22,52 @@ public struct ChatChannelListItem: View {
     var onItemTap: (ChatChannel) -> Void
 
     public var body: some View {
-        ZStack {
-            Button {
-                onItemTap(channel)
-            } label: {
-                HStack {
-                    ChannelAvatarView(
-                        avatar: avatar,
-                        showOnlineIndicator: onlineIndicatorShown
-                    )
-                    
-                    VStack(alignment: .leading, spacing: 4) {
-                        HStack {
-                            titleView
-                            
-                            Spacer()
-                            
-                            if channel.unreadCount != .noUnread {
-                                UnreadIndicatorView(
-                                    unreadCount: channel.unreadCount.messages
-                                )
-                            }
+        Button {
+            onItemTap(channel)
+        } label: {
+            HStack {
+                ChannelAvatarView(
+                    avatar: avatar,
+                    showOnlineIndicator: onlineIndicatorShown
+                )
+                
+                VStack(alignment: .leading, spacing: 4) {
+                    HStack {
+                        titleView
+                        
+                        Spacer()
+                        
+                        if channel.unreadCount != .noUnread {
+                            UnreadIndicatorView(
+                                unreadCount: channel.unreadCount.messages
+                            )
                         }
+                    }
+                    
+                    HStack {
+                        subtitleView
 
-                        HStack {
-                            subtitleView
-                            
-                            Spacer()
-                            
-                            HStack(spacing: 4) {
-                                if shouldShowReadEvents {
-                                    MessageReadIndicatorView(
-                                        readUsers: channel.readUsers(
-                                            currentUserId: chatClient.currentUserId,
-                                            message: channel.latestMessages.first
-                                        ),
-                                        showReadCount: false
-                                    )
-                                }
-                                SubtitleText(text: timestampText)
+                        Spacer()
+                        
+                        HStack(spacing: 4) {
+                            if shouldShowReadEvents {
+                                MessageReadIndicatorView(
+                                    readUsers: channel.readUsers(
+                                        currentUserId: chatClient.currentUserId,
+                                        message: channel.latestMessages.first
+                                    ),
+                                    showReadCount: false
+                                )
                             }
+                            SubtitleText(text: timestampText)
                         }
                     }
                 }
-                .padding(.all, 8)
             }
-            .foregroundColor(.black)
-            .disabled(disabled)
+            .padding(.all, 8)
         }
+        .foregroundColor(.black)
+        .disabled(disabled)
         .id("\(channel.id)-base")
     }
 

StreamChatSwiftUITests/Tests/ChatChannelList/NoChannelsView_Tests.swift

@@ -25,6 +25,7 @@ class NoChannelsView_Tests: XCTestCase {
     func test_noChannelsView_snapshot() {
         // Given
         let view = NoChannelsView()
+            .frame(width: defaultScreenSize.width, height: defaultScreenSize.height)
 
         // Then
         assertSnapshot(matching: view, as: .image)