Show all members in direct message channel info view (#760)

Author: martinmitrevski

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### 🐞 Fixed
 - Fix visibility of tabbar when reactions are shown [#750](https://github.com/GetStream/stream-chat-swiftui/pull/750)
+- Show all members in direct message channel info view [#760](https://github.com/GetStream/stream-chat-swiftui/pull/760)
 ### 🔄 Changed
 - Only show "Pin/Unpin message" Action if user has permission [#749](https://github.com/GetStream/stream-chat-swiftui/pull/749)
 - Filter deactivated users in channel info view [#758](https://github.com/GetStream/stream-chat-swiftui/pull/758)

Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoHelperViews.swift

@@ -64,10 +64,10 @@ public struct ChatInfoOptionsView: View {
 
     public var body: some View {
         VStack(spacing: 0) {
-            if !viewModel.channel.isDirectMessageChannel {
-                ChannelNameUpdateView(viewModel: viewModel)
-            } else {
+            if viewModel.showSingleMemberDMView {
                 ChatInfoMentionText(participant: viewModel.displayedParticipants.first)
+            } else if !viewModel.channel.isDirectMessageChannel {
+                ChannelNameUpdateView(viewModel: viewModel)
             }
 
             Divider()

Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoView.swift

@@ -36,7 +36,7 @@ public struct ChatChannelInfoView: View, KeyboardReadable {
         ZStack {
             ScrollView {
                 LazyVStack(spacing: 0) {
-                    if viewModel.channel.isDirectMessageChannel {
+                    if viewModel.showSingleMemberDMView {
                         ChatInfoDirectChannelView(
                             participant: viewModel.displayedParticipants.first
                         )
@@ -125,7 +125,7 @@ public struct ChatChannelInfoView: View, KeyboardReadable {
         .toolbar {
             ToolbarItem(placement: .principal) {
                 Group {
-                    if viewModel.channel.isDirectMessageChannel {
+                    if viewModel.showSingleMemberDMView {
                         Text(viewModel.displayedParticipants.first?.chatUser.name ?? "")
                             .font(fonts.bodyBold)
                             .foregroundColor(Color(colors.text))

Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoViewModel.swift

@@ -59,9 +59,13 @@ public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDe
     var channelController: ChatChannelController!
     private var memberListController: ChatChannelMemberListController!
     private var loadingUsers = false
+    
+    public var showSingleMemberDMView: Bool {
+        channel.isDirectMessageChannel && participants.count <= 2
+    }
 
     public var displayedParticipants: [ParticipantInfo] {
-        if channel.isDirectMessageChannel,
+        if showSingleMemberDMView,
            let otherParticipant = participants.first(where: { info in
                info.id != chatClient.currentUserId
            }) {
@@ -110,7 +114,7 @@ public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDe
     }
 
     public var showMoreUsersButton: Bool {
-        !channel.isDirectMessageChannel && memberListCollapsed && notDisplayedParticipantsCount > 0
+        !showSingleMemberDMView && memberListCollapsed && notDisplayedParticipantsCount > 0
     }
 
     public init(channel: ChatChannel) {

StreamChatSwiftUITests/Tests/ChatChannel/ChannelInfo/ChatChannelInfoView_Tests.swift

@@ -49,6 +49,25 @@ class ChatChannelInfoView_Tests: StreamChatTestCase {
         // Then
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
     }
+    
+    func test_chatChannelInfoView_directChannelMoreMembersSnapshot() {
+        // Given
+        let members = ChannelInfoMockUtils.setupMockMembers(
+            count: 4,
+            currentUserId: chatClient.currentUserId!
+        )
+        let channel = ChatChannel.mockDMChannel(
+            name: "Direct channel",
+            lastActiveMembers: members
+        )
+
+        // When
+        let view = ChatChannelInfoView(channel: channel)
+            .applyDefaultSize()
+
+        // Then
+        assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
+    }
 
     func test_chatChannelInfoView_directChannelMutedSnapshot() {
         // Given