Only show "Add Users" button in ChannelInfoView if user has permissions (#651)

* Channel Info: Add Check for `update-channel-members` permission before showing "Add Users" button (#650)

* Update CHANGELOG.md

* Fix swiftformat

* Fix test on channel info view

---------

Co-authored-by: Ben Pollman <[email protected]>

Author: nuno-vieira

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### 🔄 Changed
 - Message composer now uses `.uploadFile` capability when showing attachment picker icon [#646](https://github.com/GetStream/stream-chat-swiftui/pull/646)
+- `ChannelInfoView` now uses `.updateChannelMembers` capability to show "Add Users" button [#651](https://github.com/GetStream/stream-chat-swiftui/pull/651)
 
 # [4.66.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.66.0)
 _November 06, 2024_

Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoView.swift

@@ -137,7 +137,7 @@ public struct ChatChannelInfoView: View, KeyboardReadable {
             }
 
             ToolbarItem(placement: .navigationBarTrailing) {
-                viewModel.channel.isDirectMessageChannel ? nil :
+                if viewModel.shouldShowAddUserButton {
                     Button {
                         viewModel.addUsersShown = true
                     } label: {
@@ -148,6 +148,7 @@ public struct ChatChannelInfoView: View, KeyboardReadable {
                             .background(colors.tintColor)
                             .clipShape(Circle())
                     }
+                }
             }
         }
         .onReceive(keyboardWillChangePublisher) { visible in

Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoViewModel.swift

@@ -48,6 +48,14 @@ public class ChatChannelInfoViewModel: ObservableObject, ChatChannelControllerDe
         channel.ownCapabilities.contains(.updateChannel)
     }
 
+    public var shouldShowAddUserButton: Bool {
+        if channel.isDirectMessageChannel {
+            return false
+        } else {
+            return channel.ownCapabilities.contains(.updateChannelMembers)
+        }
+    }
+
     var channelController: ChatChannelController!
     private var memberListController: ChatChannelMemberListController!
     private var loadingUsers = false

StreamChatSwiftUITests/Tests/ChatChannel/ChannelInfo/ChatChannelInfoViewModel_Tests.swift

@@ -262,6 +262,42 @@ class ChatChannelInfoViewModel_Tests: StreamChatTestCase {
         XCTAssert(leaveButton == false)
     }
 
+    func test_chatChannelInfoVM_addUserButtonShownInGroup() {
+        // Given
+        let channel = mockGroup(with: 5)
+        let viewModel = ChatChannelInfoViewModel(channel: channel)
+
+        // When
+        let leaveButton = viewModel.shouldShowAddUserButton
+
+        // Then
+        XCTAssert(leaveButton == true)
+    }
+
+    func test_chatChannelInfoVM_addUserButtonHiddenInGroup() {
+        // Given
+        let channel = mockGroup(with: 5, updateCapabilities: false)
+        let viewModel = ChatChannelInfoViewModel(channel: channel)
+
+        // When
+        let leaveButton = viewModel.shouldShowAddUserButton
+
+        // Then
+        XCTAssert(leaveButton == false)
+    }
+
+    func test_chatChannelInfoVM_addUserButtonHiddenInDM() {
+        // Given
+        let channel = ChatChannel.mockDMChannel()
+        let viewModel = ChatChannelInfoViewModel(channel: channel)
+
+        // When
+        let leaveButton = viewModel.shouldShowAddUserButton
+
+        // Then
+        XCTAssert(leaveButton == false)
+    }
+
     // MARK: - private
 
     private func mockGroup(with memberCount: Int, updateCapabilities: Bool = true) -> ChatChannel {
@@ -275,6 +311,7 @@ class ChatChannelInfoViewModel_Tests: StreamChatTestCase {
             capabilities.insert(.updateChannel)
             capabilities.insert(.deleteChannel)
             capabilities.insert(.leaveChannel)
+            capabilities.insert(.updateChannelMembers)
         }
         let channel = ChatChannel.mock(
             cid: cid,

StreamChatSwiftUITests/Tests/ChatChannel/ChannelInfo/ChatChannelInfoView_Tests.swift

@@ -151,7 +151,7 @@ class ChatChannelInfoView_Tests: StreamChatTestCase {
         let group = ChatChannel.mock(
             cid: .unique,
             name: "Test Group",
-            ownCapabilities: [.updateChannel, .leaveChannel],
+            ownCapabilities: [.updateChannel, .leaveChannel, .updateChannelMembers],
             lastActiveMembers: members,
             memberCount: members.count
         )