Fix accessibility button shapes shown in navigation link views (#800)

nuno-vieira · web-flow · commit c413786c5a5d · 2025-04-09T09:49:59.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix showing a double error indicator when sending attachments without any text [#799](https://github.com/GetStream/stream-chat-swiftui/pull/799)
 - Fix showing read indicator when message failed to be sent [#799](https://github.com/GetStream/stream-chat-swiftui/pull/799)
 - Fix not showing sending indicator when message is in sending state [#799](https://github.com/GetStream/stream-chat-swiftui/pull/799)
+- Fix empty accessibility button shapes shown in navigation link views [#800](https://github.com/GetStream/stream-chat-swiftui/pull/800)
 
 # [4.76.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.76.0)
 _March 31, 2025_
diff --git a/DemoAppSwiftUI/ChannelHeader/CustomChannelHeader.swift b/DemoAppSwiftUI/ChannelHeader/CustomChannelHeader.swift
@@ -78,13 +78,15 @@ struct CustomChannelModifier: ChannelListHeaderViewModifier {
             } label: {
                 EmptyView()
             }
+            .opacity(0) // Fixes showing accessibility button shape
 
             NavigationLink(isActive: $isNewChatShown) {
                 NewChatView(isNewChatShown: $isNewChatShown)
             } label: {
                 EmptyView()
             }
             .isDetailLink(UIDevice.current.userInterfaceIdiom == .pad)
+            .opacity(0) // Fixes showing accessibility button shape
             .alert(isPresented: $logoutAlertShown) {
                 Alert(
                     title: Text("Sign out"),
diff --git a/DemoAppSwiftUI/PinChannelHelpers.swift b/DemoAppSwiftUI/PinChannelHelpers.swift
@@ -169,6 +169,7 @@ struct DemoAppChatChannelNavigatableListItem<ChannelDestination: View>: View {
             } label: {
                 EmptyView()
             }
+            .opacity(0) // Fixes showing accessibility button shape
         }
     }
 
diff --git a/Sources/StreamChatSwiftUI/ChatChannel/ChatChannelView.swift b/Sources/StreamChatSwiftUI/ChatChannel/ChatChannelView.swift
@@ -134,6 +134,7 @@ public struct ChatChannelView<Factory: ViewFactory>: View, KeyboardReadable {
                     } label: {
                         EmptyView()
                     }
+                    .opacity(0) // Fixes showing accessibility button shape
                 }
                 .accentColor(colors.tintColor)
                 .overlay(
diff --git a/Sources/StreamChatSwiftUI/ChatChannelList/ChatChannelNavigatableListItem.swift b/Sources/StreamChatSwiftUI/ChatChannelList/ChatChannelNavigatableListItem.swift
@@ -61,6 +61,7 @@ public struct ChatChannelNavigatableListItem<Factory: ViewFactory, ChannelDestin
             } label: {
                 EmptyView()
             }
+            .opacity(0) // Fixes showing accessibility button shape
         }
     }
 
diff --git a/Sources/StreamChatSwiftUI/ChatChannelList/SearchResultsView.swift b/Sources/StreamChatSwiftUI/ChatChannelList/SearchResultsView.swift
@@ -113,6 +113,7 @@ struct SearchResultView<Factory: ViewFactory>: View {
             } label: {
                 EmptyView()
             }
+            .opacity(0) // Fixes showing accessibility button shape
         }
     }
 }
diff --git a/Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListNavigatableItem.swift b/Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListNavigatableItem.swift
@@ -44,6 +44,7 @@ public struct ChatThreadListNavigatableItem<ThreadListItem: View, ThreadDestinat
             } label: {
                 EmptyView()
             }
+            .opacity(0) // Fixes showing accessibility button shape
         }
         .foregroundColor(.black)
     }

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,7 @@ struct DemoAppChatChannelNavigatableListItem<ChannelDestination: View>: View {`
`169`	`169`	`} label: {`
`170`	`170`	`EmptyView()`
`171`	`171`	`}`
	`172`	`+ .opacity(0) // Fixes showing accessibility button shape`
`172`	`173`	`}`
`173`	`174`	`}`
`174`	`175`
Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ public struct ChatChannelView<Factory: ViewFactory>: View, KeyboardReadable {`
`134`	`134`	`} label: {`
`135`	`135`	`EmptyView()`
`136`	`136`	`}`
	`137`	`+ .opacity(0) // Fixes showing accessibility button shape`
`137`	`138`	`}`
`138`	`139`	`.accentColor(colors.tintColor)`
`139`	`140`	`.overlay(`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ public struct ChatChannelNavigatableListItem<Factory: ViewFactory, ChannelDestin`
`61`	`61`	`} label: {`
`62`	`62`	`EmptyView()`
`63`	`63`	`}`
	`64`	`+ .opacity(0) // Fixes showing accessibility button shape`
`64`	`65`	`}`
`65`	`66`	`}`
`66`	`67`
Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ struct SearchResultView<Factory: ViewFactory>: View {`
`113`	`113`	`} label: {`
`114`	`114`	`EmptyView()`
`115`	`115`	`}`
	`116`	`+ .opacity(0) // Fixes showing accessibility button shape`
`116`	`117`	`}`
`117`	`118`	`}`
`118`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ public struct ChatThreadListNavigatableItem<ThreadListItem: View, ThreadDestinat`
`44`	`44`	`} label: {`
`45`	`45`	`EmptyView()`
`46`	`46`	`}`
	`47`	`+ .opacity(0) // Fixes showing accessibility button shape`
`47`	`48`	`}`
`48`	`49`	`.foregroundColor(.black)`
`49`	`50`	`}`