[CI] Fix flaky tests (#654)

Author: testableapple

StreamChatSwiftUITestsAppTests/Pages/MessageListPage.swift

@@ -188,6 +188,10 @@ class MessageListPage {
         static func giphyCancelButton(in messageCell: XCUIElement) -> XCUIElement {
             attachmentActionButton(in: messageCell, label: "Cancel")
         }
+        
+        static func giphyImage(in messageCell: XCUIElement) -> XCUIElement {
+            messageCell.otherElements["GiphyAttachmentView"].images.firstMatch
+        }
 
         static func giphyLabel(in messageCell: XCUIElement) -> XCUIElement {
             messageCell.staticTexts["GiphyAttachmentView"]

StreamChatSwiftUITestsAppTests/Robots/UserRobot+Asserts.swift

@@ -866,7 +866,7 @@ extension UserRobot {
     ) -> Self {
         let cell = messageCell(withIndex: messageCellIndex, file: file, line: line).wait()
         XCTAssertTrue(attributes.giphyLabel(in: cell).wait().exists, "Giphy label does not exist")
-        XCTAssertEqual(0, attributes.giphyButtons(in: cell).count)
+        XCTAssertTrue(attributes.giphyImage(in: cell).exists, "Giphy image does not exist")
         return self
     }
 

StreamChatSwiftUITestsAppTests/Robots/UserRobot.swift

@@ -362,8 +362,8 @@ extension UserRobot {
             typeText("/giphy")
             sendMessage(text, waitForAppearance: false)
         }
-        if send { tapOnSendGiphyButton() }
         MessageListPage.Attributes.actionButtons().firstMatch.wait()
+        if send { tapOnSendGiphyButton() }
         return self
     }
 

StreamChatSwiftUITestsAppTests/Tests/Ephemeral_Messages_Tests.swift

@@ -13,19 +13,14 @@ final class Ephemeral_Messages_Tests: StreamTestCase {
 
     func test_userObservesAnimatedGiphy_whenUserAddsGiphyMessage() throws {
         linkToScenario(withId: 435)
-        
-        try XCTSkipIf(
-            ProcessInfo().operatingSystemVersion.majorVersion > 16,
-            "The test cannot tap on a `Send` button on iOS 17"
-        )
 
         GIVEN("user opens a channel") {
             userRobot
                 .login()
                 .openChannel()
         }
         WHEN("user sends a giphy using giphy command") {
-            userRobot.sendGiphy()
+            userRobot.sendGiphy(useComposerCommand: true)
         }
         THEN("user observes the animated gif") {
             userRobot.assertGiphyImage()
@@ -141,11 +136,6 @@ final class Ephemeral_Messages_Tests: StreamTestCase {
 
     func test_userObservesAnimatedGiphy_afterAddingGiphyThroughComposerMenu() throws {
         linkToScenario(withId: 441)
-        
-        try XCTSkipIf(
-            ProcessInfo().operatingSystemVersion.majorVersion > 16,
-            "The test cannot tap on a `Send` button on iOS 17"
-        )
 
         GIVEN("user opens a channel") {
             userRobot