Small performance improvements

Author: martinmitrevski

DemoAppSwiftUI/CustomChannelHeader.swift

@@ -35,7 +35,7 @@ public struct CustomChannelHeader: ToolbarContent {
                 logoutAlertShown = true
             } label: {
                 LazyImage(source: currentUserController.currentUser?.imageURL)
-                    .onDisappear(.reset)
+                    .onDisappear(.cancel)
                     .clipShape(Circle())
                     .frame(
                         width: 30,

DemoAppSwiftUI/LoginView.swift

@@ -58,7 +58,7 @@ struct DemoUserView: View {
     var body: some View {
         HStack {
             LazyImage(source: user.avatarURL)
-                .onDisappear(.reset)
+                .onDisappear(.cancel)
                 .clipShape(Circle())
                 .frame(
                     width: imageSize,

Sources/StreamChatSwiftUI/ChatChannel/ChatChannelViewModel.swift

@@ -18,8 +18,7 @@ open class ChatChannelViewModel: ObservableObject, MessagesDataSource {
     private var cancellables = Set<AnyCancellable>()
     private var lastRefreshThreshold = 200
     private let refreshThreshold = 200
-    private var timer: DispatchSourceTimer?
-    private let queue = DispatchQueue(label: "io.getstream.background.timer")
+    private var timer: Timer?
     private var currentDate: Date? {
         didSet {
             handleDateChange()
@@ -217,7 +216,7 @@ open class ChatChannelViewModel: ObservableObject, MessagesDataSource {
             loadingPreviousMessages = true
             channelDataSource.loadPreviousMessages(
                 before: nil,
-                limit: 50,
+                limit: utils.messageListConfig.pageSize,
                 completion: { [weak self] _ in
                     guard let self = self else { return }
                     self.loadingPreviousMessages = false
@@ -228,13 +227,14 @@ open class ChatChannelViewModel: ObservableObject, MessagesDataSource {
 
     private func save(lastDate: Date) {
         currentDate = lastDate
-        timer?.cancel()
-        timer = DispatchSource.makeTimerSource(queue: queue)
-        timer?.schedule(deadline: .now() + 0.5, repeating: .never)
-        timer?.setEventHandler(handler: { [weak self] in
-            self?.currentDate = nil
-        })
-        timer?.resume()
+        timer?.invalidate()
+        timer = Timer.scheduledTimer(
+            withTimeInterval: 0.5,
+            repeats: false,
+            block: { [weak self] _ in
+                self?.currentDate = nil
+            }
+        )
     }
 
     private func maybeSendReadEvent(for message: ChatMessage) {

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageContainerView.swift

@@ -136,7 +136,7 @@ struct MessageContainerView<Factory: ViewFactory>: View {
                         }
                     })
 
-                    if message.replyCount > 0 && !message.threadParticipants.isEmpty && !isInThread {
+                    if message.replyCount > 0 && !isInThread {
                         MessageRepliesView(
                             factory: factory,
                             channel: channel,

Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageListConfig.swift

@@ -13,14 +13,16 @@ public struct MessageListConfig {
         groupMessages: Bool = true,
         messageDisplayOptions: MessageDisplayOptions = MessageDisplayOptions(),
         messagePaddings: MessagePaddings = MessagePaddings(),
-        dateIndicatorPlacement: DateIndicatorPlacement = .overlay
+        dateIndicatorPlacement: DateIndicatorPlacement = .overlay,
+        pageSize: Int = 50
     ) {
         self.messageListType = messageListType
         self.typingIndicatorPlacement = typingIndicatorPlacement
         self.groupMessages = groupMessages
         self.messageDisplayOptions = messageDisplayOptions
         self.messagePaddings = messagePaddings
         self.dateIndicatorPlacement = dateIndicatorPlacement
+        self.pageSize = pageSize
     }
 
     let messageListType: MessageListType
@@ -29,6 +31,7 @@ public struct MessageListConfig {
     let messageDisplayOptions: MessageDisplayOptions
     let messagePaddings: MessagePaddings
     let dateIndicatorPlacement: DateIndicatorPlacement
+    let pageSize: Int
 }
 
 /// Contains information about the message paddings.

Sources/StreamChatSwiftUI/Utils/Common/ChatMessage+Extensions.swift

@@ -78,7 +78,7 @@ public extension ChatMessage {
     ///
     /// Note that for messages sent with attachments, large emojis aren's rendered
     var shouldRenderAsJumbomoji: Bool {
-        guard attachmentCounts.isEmpty, let textContent = textContent, !textContent.isEmpty else { return false }
+        guard let textContent = textContent, !textContent.isEmpty else { return false }
         return textContent.count <= 3 && textContent.containsOnlyEmoji
     }
 }