-
Notifications
You must be signed in to change notification settings - Fork 114
Fix reading messages from muted users #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| private func sendReadEventIfNeeded(for message: ChatMessage) { | ||
| guard let channel, channel.unreadCount.messages > 0 else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since unread count did not change when a muted user sent a message then we never called mark read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the same issue on UIKit? I think I introduced this logic recently in UIKit as well 🤔
SDK Size
|
Public Interface🚀 No changes affecting the public interface. |
StreamChatSwiftUI XCSize
|
|



🔗 Issue Links
Fixes: IOS-1238
🎯 Goal
Fix reading messages from muted users
📝 Summary
🧪 Manual Testing Notes
The message status is read and delivered
☑️ Contributor Checklist
docs-contentrepo