Fix polls background view not using correct color from palette #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
martinmitrevski
approved these changes
Nov 26, 2024
Collaborator
SDK Size
|
|
nuno-vieira
added a commit
that referenced
this pull request
Nov 26, 2024
* Record dark mode tests in create poll view * Fix Poll Creation View background color * Fix Poll Results background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Related to #661
🎯 Goal
Regression introduced by #661
@f3dm76 actually used the correct color from the palette. But since it broke the snapshot tests, I thought it was a different one. If we previously had a snapshot test for the dark colour variant, it would have caught this mistake, and it would be clear that the one I used was not correct. I've added the variant tests for the poll views in order to avoid any future regression.