Do not show giphy in channel's preview message #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list Channel preview message ignores giphy by default
laevandus
force-pushed
the
fix/channel-preview-message
branch
from
35b74be to
c150620
Compare
Collaborator
SDK Size
|
|
martinmitrevski
approved these changes
Nov 27, 2024
testableapple
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves IOS-564
🎯 Goal
Do not show Giphy in the channel preview
🛠 Implementation
LLC and UIKit use channel's preview message for showing the preview of the channel. SwiftUI was just using the latest message. This PR unifies the logic and starts using the channel's preview message as well. Channel preview explicitly filters out messages where the
typeisephemeral.🧪 Testing
☑️ Checklist