Fix message list scroll not working when drag gestured is initiated from a message #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
changed the title
Collaborator
SDK Size
|
martinmitrevski
approved these changes
Nov 29, 2024
|
nuno-vieira
deleted the
fix/scroll-not-working-when-gesture-hover-messag
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
#670
🎯 Goal
Fix message list scroll not working when drag gestured is initiated from a message.
🛠 Implementation
This was not caught because the issue only happens on TestFlight for some reason. Even when building in RELEASE mode, the issue it not reproducible, only on TestFlight 🤷♂️ It looks like it is a bug from Apple (here).
I've tried multiple ways to fix the issue, but really the only think that worked, was reverting to how it was before. I tried moving the gesture higher in the hierarchy and just use
gestureinstead ofhighPriorityGesturebut even this did not work.🧪 Testing
This needs to be tested from Testflight. Make sure to test 4.67.0 build 76. (I've deployed it from here)
☑️ Checklist