Skip to content

Allow customizing channel and message search #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laevandus merged 1 commit into from
Dec 16, 2024
Merged

Allow customizing channel and message search #690

laevandus merged 1 commit into from
Dec 16, 2024

Conversation

@laevandus
Copy link
Contributor

@laevandus laevandus commented Dec 13, 2024

🔗 Issue Link

Resolves: IOS-608

🎯 Goal

  • Allow customizing channel and message search in the ChatChannelListViewModel

🛠 Implementation

  • Allow overriding ChatChannelListViewModel.performChannelSearch and ChatChannelListViewModel.performMessageSearch
  • Make ChatChannelListViewModel.channelListSearchController and ChatChannelListViewModel.messageSearchController public

🧪 Testing

N/A

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner December 13, 2024 08:03
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 13, 2024

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.53 MB 7.53 MB 0 KB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit 5a1ec9a into develop Dec 16, 2024
11 of 12 checks passed
@laevandus laevandus deleted the allow-search-customisation branch December 16, 2024 10:54
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laevandus @Stream-SDK-Bot @martinmitrevski