Skip to content

Use bright color for typing indicator in dark mode #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laevandus merged 1 commit into from
Jan 2, 2025
Merged

Use bright color for typing indicator in dark mode #702

laevandus merged 1 commit into from
Jan 2, 2025

Conversation

@laevandus
Copy link
Contributor

@laevandus laevandus commented Jan 2, 2025 •
edited
Loading

🔗 Issue Link

Resolves IOS-463

🎯 Goal

  • Typing indicator's dots were not visible in dark mode

🎨 Changes

Before After
before after

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner January 2, 2025 10:43
@laevandus laevandus force-pushed the fix/typing-indicator-dark branch from 8fd427a to f5627cc Compare January 2, 2025 10:47
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 2, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.54 MB 7.54 MB 0 KB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
46.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit 3289fb3 into develop Jan 2, 2025
11 of 12 checks passed
@laevandus laevandus deleted the fix/typing-indicator-dark branch January 2, 2025 12:17
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees

No one assigned

Labels

swiftui-repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laevandus @Stream-SDK-Bot @martinmitrevski @nuno-vieira