Remove internal _isDatabaseObserverItemReusingEnabled check

[laevandus]

🎯 Goal

Remove _isDatabaseObserverItemReusingEnabled check which has been enabled for 6 months without any side-effects

🛠 Implementation

• Remove the check and delete any fallback code
• Remove message caching because it was turned off with that check before
• Deprecate public userDisplayInfo(from id: String) -> UserDisplayInfo? method which is not used and only accessed cached data

🧪 Testing

N/A

☑️ Checklist

• I have signed the Stream CLA (required)
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Affected documentation updated (docusaurus, tutorial, CMS (task created)

[github-actions]

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamChatSwiftUI	7.54 MB	7.55 MB	+15 KB	🟢

[martinmitrevski]

Would be great to do some performance checks before merging this.

[laevandus]

Would be great to do some performance checks before merging this.

Ran it with time profiler as well. Nothing shows up related to these changes. That said, I saw some DataStore accesses on the main thread, but this is a separate story.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud