Customizing the message avatar view is reflected in all views that use it #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SDK Size
|
laevandus
approved these changes
Mar 5, 2025
Contributor
laevandus
left a comment
laevandus
left a comment
There was a problem hiding this comment.
I think it makes sense to reuse the factory method. Leaving my approval here although it is in the draft state.
…iftui into polls-message-avatar
martinmitrevski
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves https://linear.app/stream/issue/IOS-727/polls-views-are-not-using-avatar-factory-methods.
🎯 Goal
Another option is to introduce new factory method.
🛠 Implementation
Provide a description of the implementation.
🧪 Testing
Describe the steps how this change can be tested (or why it can't be tested).
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist