Fix error that list got modified during iteration

sierpinskid · sierpinskid · commit 3246e60948da · 2025-10-31T21:56:57.000+01:00
diff --git a/Assets/Plugins/StreamChat/Tests/StatefulClient/PollsTests.cs b/Assets/Plugins/StreamChat/Tests/StatefulClient/PollsTests.cs
@@ -23,7 +23,7 @@ internal class PollsTests : BaseStateIntegrationTests
     {
         private readonly List<string> _tempPollIds = new List<string>();
 
-        [TearDown]
+        [OneTimeTearDown]
         public async void TearDown()
         {
             await DeleteTempPollsAsync();
@@ -36,8 +36,10 @@ private async Task DeleteTempPollsAsync()
                 return;
             }
 
-            foreach (var pollId in _tempPollIds)
+            // Iterate in reverse to avoid collection modification issues
+            for (int i = _tempPollIds.Count - 1; i >= 0; i--)
             {
+                var pollId = _tempPollIds[i];
                 try
                 {
                     await Client.Polls.DeletePollAsync(pollId);

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ internal class PollsTests : BaseStateIntegrationTests`
`23`	`23`	`{`
`24`	`24`	`private readonly List<string> _tempPollIds = new List<string>();`
`25`	`25`
`26`		`- [TearDown]`
	`26`	`+ [OneTimeTearDown]`
`27`	`27`	`public async void TearDown()`
`28`	`28`	`{`
`29`	`29`	`await DeleteTempPollsAsync();`
`@@ -36,8 +36,10 @@ private async Task DeleteTempPollsAsync()`
`36`	`36`	`return;`
`37`	`37`	`}`
`38`	`38`
`39`		`- foreach (var pollId in _tempPollIds)`
	`39`	`+ // Iterate in reverse to avoid collection modification issues`
	`40`	`+ for (int i = _tempPollIds.Count - 1; i >= 0; i--)`
`40`	`41`	`{`
	`42`	`+ var pollId = _tempPollIds[i];`
`41`	`43`	`try`
`42`	`44`	`{`
`43`	`45`	`await Client.Polls.DeletePollAsync(pollId);`