Update the comment correctly and use ### instead of ## for titles

Author: aleksandar-apostolov

.github/pull_request_template.md

@@ -1,13 +1,13 @@
-## Goal
+### Goal
 <!-- What & why in one or two sentences. -->
 
-## Implementation
+### Implementation
 - ...
 
-## Testing
+### Testing
 <!-- Steps to verify / commands -->
 
-## Checklist
+### Checklist
 - [ ] The title is ready for release notes
 - [ ] Issue linked (if any)  
 - [ ] Tests/docs updated

.github/workflows/pr-quality.yml

@@ -1,40 +1,43 @@
-# .github/workflows/pr-quality-check.yml
+# .github/workflows/pr-checklist.yml
 name: PR Quality check
 
-# Add a constant anchor we can always find
-env:
-  PR_QUALITY_ANCHOR: "<!-- pr-quality-anchor -->"
-
 on:
-  pull_request:
+  pull_request_target:
     types: [opened, edited, synchronize, labeled, unlabeled, reopened]
 
 permissions:
   contents: read
   pull-requests: write
   issues: write
 
+env:
+  # Hidden marker to always find/update the same comment
+  PR_CHECKLIST_ANCHOR: "<!-- pr-checklist-anchor -->"
+  # Title bypass label for release-notes length rule
+  TITLE_BYPASS_LABEL: "pr:ignore-for-release"
+  # Title word limits (for release notes)
+  MIN_TITLE_WORDS: "5"
+  MAX_TITLE_WORDS: "12"
+
 jobs:
-  pr-quality:
+  pr-checklist:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Validate PR quality
+      - name: Validate PR
         id: validate
         env:
           TITLE: ${{ github.event.pull_request.title }}
           BODY: ${{ github.event.pull_request.body }}
           LABELS_CSV: ${{ join(github.event.pull_request.labels.*.name, ',') }}
+          MIN_WORDS: ${{ env.MIN_TITLE_WORDS }}
+          MAX_WORDS: ${{ env.MAX_TITLE_WORDS }}
+          BYPASS:    ${{ env.TITLE_BYPASS_LABEL }}
         run: |
           set -euo pipefail
 
           failures=""
 
-          # ---- Settings ----
-          MIN_WORDS=5
-          MAX_WORDS=12
-          TITLE_BYPASS_LABEL="pr:ignore-for-release"
-
           has_label () {
             case ",${LABELS_CSV}," in
               *,"$1",*) return 0 ;;
@@ -51,30 +54,34 @@ jobs:
             return 1
           }
 
-          # --- 1) Title check
-          if ! has_label "$TITLE_BYPASS_LABEL"; then
-            title_words=$(echo "$TITLE" | tr -s '[:space:]' ' ' | sed -e 's/^ *//' -e 's/ *$//' | wc -w | xargs)
-            if [ -z "$title_words" ]; then title_words=0; fi
+          # ---- 1) Title length (unless bypass label present)
+          if ! has_label "$BYPASS"; then
+            title_words=$(echo "$TITLE" | tr -s '[:space:]' ' ' | sed -e 's/^ *//' -e 's/ *$//' | wc -w | xargs || true)
+            if [ -z "${title_words:-}" ]; then title_words=0; fi
             if [ "$title_words" -lt "$MIN_WORDS" ] || [ "$title_words" -gt "$MAX_WORDS" ]; then
-              failures="${failures}\n- **Title** should be ${MIN_WORDS}–${MAX_WORDS} words for release notes. Current: ${title_words} word(s). (Add \`${TITLE_BYPASS_LABEL}\` to bypass.)"
+              failures="${failures}\n- **Title** should be concise for release notes: ${MIN_WORDS}–${MAX_WORDS} words. Current: ${title_words}. (Add \`$BYPASS\` to bypass.)"
             fi
           fi
 
-          # --- 2) Has pr:* label
+          # ---- 2) At least one pr:* label
           if ! has_any_pr_label; then
-            failures="${failures}\n- Missing required label: at least one label starting with \`pr:\`."
+            failures="${failures}\n- Missing required label: at least one \`pr:\` label (e.g., \`pr:new-feature\`, \`pr:bug\`)."
           fi
 
-          # --- 3) Sections non-empty
+          # ---- 3) Required sections (### headers): Goal / Implementation / Testing
+          BODY="${BODY:-}"
+
           section_nonempty () {
+            # Extract text under '### <Header>' until next '###' (or end)
             local hdr="$1"
             local section
-            section="$(printf "%s" "$BODY" | awk -v h="^##[[:space:]]*$hdr[[:space:]]*$" '
+            section="$(printf "%s" "$BODY" | awk -v h="^###[[:space:]]*$hdr[[:space:]]*$" '
               BEGIN { insec=0 }
               $0 ~ h { insec=1; next }
-              insec && $0 ~ /^##[[:space:]]/ { insec=0 }
+              insec && $0 ~ /^###[[:space:]]/ { insec=0 }
               insec { print }
             ')"
+            # Strip HTML comments and whitespace-only lines
             section="$(printf "%s" "$section" \
               | sed -E 's/<!--(.|\n)*?-->//g' \
               | sed -E 's/^[[:space:]]+|[[:space:]]+$//g' \
@@ -84,7 +91,7 @@ jobs:
 
           for hdr in Goal Implementation Testing; do
             if ! section_nonempty "$hdr"; then
-              failures="${failures}\n- Section **${hdr}** is missing or empty."
+              failures="${failures}\n- Section **${hdr}** is missing or empty (use \`### ${hdr}\` with some content)."
             fi
           done
 
@@ -95,19 +102,22 @@ jobs:
               printf "%b\n" "$failures"
               echo 'EOF'
             } >> "$GITHUB_OUTPUT"
+            # Fail job to block merging if branch protection requires this check
             exit 1
           else
             echo "has_failures=false" >> "$GITHUB_OUTPUT"
           fi
 
-      - name: Find existing PR Quality Check comment
+      # Find sticky comment by anchor (no author filter → works for forks)
+      - name: Find PR Checklist comment
         id: find_comment
         uses: peter-evans/find-comment@v3
         with:
           issue-number: ${{ github.event.pull_request.number }}
-          comment-author: github-actions[bot]
-          body-includes: ${{ env.PR_QUALITY_ANCHOR }}
+          body-includes: ${{ env.PR_CHECKLIST_ANCHOR }}
+          direction: last
 
+      # Post or update the sticky comment to ❌ with details
       - name: Create or update failure comment
         if: failure()
         uses: peter-evans/create-or-update-comment@v4
@@ -116,18 +126,21 @@ jobs:
           comment-id: ${{ steps.find_comment.outputs.comment-id }}
           edit-mode: replace
           body: |
-            <!-- pr-quality-anchor -->
-            ### PR Quality Check ❌ Failed
+            <!-- pr-checklist-anchor -->
+            ### PR Checklist ❌
 
             The following issues were detected:
 
             ${{ steps.validate.outputs.failures }}
 
-            **What we check**
-            1. Title is concise (3–12 words) unless labeled `pr:ignore-for-release`.
-            2. At least one `pr:` label exists (e.g., `pr:bug`, `pr:new-feature`).
-            3. Sections `## Goal`, `## Implementation`, and `## Testing` contain content.
+            **We check**
+            1. Title is concise (**${{ env.MIN_TITLE_WORDS }}–${{ env.MAX_TITLE_WORDS }} words**) unless labeled `pr:ignore-for-release`.
+            2. At least one `pr:` label exists.
+            3. Sections `### Goal`, `### Implementation`, and `### Testing` contain content.
+
+            _This comment updates automatically when you edit the PR title/body or labels._
 
+      # Flip the same sticky comment to ✅ when everything passes
       - name: Create or update success comment
         if: success()
         uses: peter-evans/create-or-update-comment@v4
@@ -136,12 +149,12 @@ jobs:
           comment-id: ${{ steps.find_comment.outputs.comment-id }}
           edit-mode: replace
           body: |
-            <!-- pr-quality-anchor -->
-            ### PR Quality Check ✅ Passed
+            <!-- pr-checklist-anchor -->
+            ### PR Checklist ✅
 
             All required conditions are satisfied:
-            - Title length is OK (or ignored by label).
+            - Title length is OK (or ignored via `pr:ignore-for-release`).
             - At least one `pr:` label exists.
-            - Sections `## Goal`, `## Implementation`, and `## Testing` are filled.
+            - Sections `### Goal`, `### Implementation`, and `### Testing` are filled.
 
-            🎉 Great job! This PR is ready for review.
+            🎉 Looks good!