Skip to content

Commit 3a26ff2

Browse files
gpuntoaleksandar-apostolovVelikovPetar
authored
Apply common stream conventions plugins (#130)
Co-authored-by: Aleksandar Apostolov <[email protected]> Co-authored-by: Petar Velikov <[email protected]>
1 parent 5244e93 commit 3a26ff2

File tree

11 files changed

+42
-65
lines changed

11 files changed

+42
-65
lines changed

.gitignore

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
*.iml
22
.gradle
33
/local.properties
4-
/.idea/caches
5-
/.idea/libraries
6-
/.idea/modules.xml
7-
/.idea/workspace.xml
8-
/.idea/navEditor.xml
9-
/.idea/assetWizardSettings.xml
104
.DS_Store
11-
/build
5+
**/build
126
buildSrc/build
137
/captures
148
.externalNativeBuild
159
.cxx
1610
local.properties
1711
.idea
18-
.kotlin
12+
.kotlin

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ apply(from = "${rootDir}/gradle/scripts/sonar.gradle")
88

99
// Top-level build file where you can add configuration options common to all sub-projects/modules.
1010
plugins {
11+
alias(libs.plugins.stream.android.library) apply false
12+
alias(libs.plugins.stream.android.application) apply false
1113
alias(libs.plugins.android.application) apply false
1214
alias(libs.plugins.kotlin.android) apply false
1315
alias(libs.plugins.kotlin.compose) apply false

buildSrc/src/main/kotlin/io/getstream/feeds/android/Configuration.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
package io.getstream.feeds.android
1717

1818
object Configuration {
19-
const val compileSdk = 36
20-
const val targetSdk = 36
21-
const val sampleTargetSdk = 36
22-
const val minSdk = 21
2319
const val majorVersion = 0
2420
const val minorVersion = 4
2521
const val patchVersion = 0

gradle/libs.versions.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
[versions]
2+
compileSdk = "36"
3+
targetSdk = "36"
4+
minSdk = "21"
5+
26
agp = "8.9.3"
37
firebaseBom = "33.16.0"
48
hilt = "2.57"
@@ -32,6 +36,7 @@ lifecycleProcess = "2.9.1"
3236
lifecycleViewModelCompose = "2.4.0"
3337
sonarqube = "6.0.1.5171"
3438
spotless = "7.2.1"
39+
streamConventions = "0.1.1"
3540
turbine = "1.2.1"
3641
kotlinDokka = "1.9.20"
3742
nexusPlugin = "1.3.0"
@@ -101,5 +106,7 @@ ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
101106
arturbosch-detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }
102107
sonarqube = { id = "org.sonarqube", version.ref = "sonarqube" }
103108
spotless = { id = "com.diffplug.spotless", version.ref = "spotless" }
109+
stream-android-library = { id = "io.getstream.android.library", version.ref = "streamConventions" }
110+
stream-android-application = { id = "io.getstream.android.application", version.ref = "streamConventions" }
104111
dokka = { id = "org.jetbrains.dokka", version.ref = "kotlinDokka" }
105112
nexus = { id = "io.github.gradle-nexus.publish-plugin", version.ref = "nexusPlugin" }

metrics/stream-feeds-android-metrics/build.gradle.kts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
plugins {
2-
alias(libs.plugins.android.application)
2+
alias(libs.plugins.stream.android.application)
33
alias(libs.plugins.kotlin.android)
44
}
55

6-
apply(from = "$rootDir/scripts/android.gradle")
7-
86
android {
97
namespace = "io.getstream.feeds.android.metrics"
8+
compileSdk = libs.versions.compileSdk.get().toInt()
9+
10+
defaultConfig {
11+
minSdk = libs.versions.minSdk.get().toInt()
12+
targetSdk = libs.versions.targetSdk.get().toInt()
13+
}
14+
1015
buildTypes {
1116
release {
1217
signingConfig = signingConfigs.findByName("debug")

scripts/android.gradle

Lines changed: 0 additions & 25 deletions
This file was deleted.

scripts/publish-module.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ afterEvaluate {
8686
}
8787
developer {
8888
id = 'gpunto'
89-
name = 'Gianmarco'
89+
name = 'Gianmarco David'
9090
9191
}
9292
}

settings.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ pluginManagement {
99
}
1010
mavenCentral()
1111
gradlePluginPortal()
12+
mavenLocal()
1213
}
1314
}
15+
1416
dependencyResolutionManagement {
1517
repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
1618
repositories {

stream-feeds-android-client/build.gradle.kts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
33
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
44

55
plugins {
6-
alias(libs.plugins.android.library)
6+
alias(libs.plugins.stream.android.library)
77
alias(libs.plugins.kotlin.android)
88
alias(libs.plugins.ksp)
99
alias(libs.plugins.arturbosch.detekt)
@@ -17,17 +17,20 @@ rootProject.extra.apply {
1717
set("PUBLISH_VERSION", rootProject.extra.get("rootVersionName"))
1818
}
1919

20-
apply(from = "${rootDir}/scripts/publish-module.gradle")
21-
apply(from = "$rootDir/scripts/android.gradle")
20+
apply(from = "$rootDir/scripts/publish-module.gradle")
2221

2322
android {
2423
namespace = "io.getstream.feeds.android.client"
24+
compileSdk = libs.versions.compileSdk.get().toInt()
2525

2626
buildFeatures {
2727
buildConfig = true
2828
}
2929

3030
defaultConfig {
31+
minSdk = libs.versions.minSdk.get().toInt()
32+
testOptions.targetSdk = libs.versions.targetSdk.get().toInt()
33+
lint.targetSdk = libs.versions.targetSdk.get().toInt()
3134
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
3235
buildConfigField("String", "PRODUCT_NAME", "\"stream-feeds-android\"")
3336
buildConfigField("String", "PRODUCT_VERSION", "\"${Configuration.versionName}\"")
@@ -38,7 +41,7 @@ android {
3841
isMinifyEnabled = false
3942
proguardFiles(
4043
getDefaultProguardFile("proguard-android-optimize.txt"),
41-
"proguard-rules.pro"
44+
"proguard-rules.pro",
4245
)
4346
consumerProguardFiles("consumer-rules.pro")
4447
}
@@ -62,7 +65,6 @@ tasks.withType<KotlinCompile>().configureEach {
6265
"-opt-in=io.getstream.android.core.annotations.StreamInternalApi",
6366
),
6467
)
65-
jvmTarget.set(JvmTarget.JVM_11)
6668
}
6769
}
6870

stream-feeds-android-network/build.gradle.kts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
33
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
44

55
plugins {
6-
alias(libs.plugins.android.library)
6+
alias(libs.plugins.stream.android.library)
77
alias(libs.plugins.kotlin.android)
88
}
99

@@ -13,22 +13,25 @@ rootProject.extra.apply {
1313
set("PUBLISH_VERSION", rootProject.extra.get("rootVersionName"))
1414
}
1515

16-
apply(from = "${rootDir}/scripts/publish-module.gradle")
17-
apply(from = "$rootDir/scripts/android.gradle")
16+
apply(from = "$rootDir/scripts/publish-module.gradle")
1817

1918
android {
2019
namespace = "io.getstream.feeds.android.network"
20+
compileSdk = libs.versions.compileSdk.get().toInt()
2121

2222
defaultConfig {
2323
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
24+
minSdk = libs.versions.minSdk.get().toInt()
25+
testOptions.targetSdk = libs.versions.targetSdk.get().toInt()
26+
lint.targetSdk = libs.versions.targetSdk.get().toInt()
2427
}
2528

2629
buildTypes {
2730
release {
2831
isMinifyEnabled = false
2932
proguardFiles(
3033
getDefaultProguardFile("proguard-android-optimize.txt"),
31-
"proguard-rules.pro"
34+
"proguard-rules.pro",
3235
)
3336
consumerProguardFiles("consumer-rules.pro")
3437
}
@@ -50,7 +53,6 @@ tasks.withType<KotlinCompile>().configureEach {
5053
"-Xexplicit-api=strict",
5154
),
5255
)
53-
jvmTarget.set(JvmTarget.JVM_11)
5456
}
5557
}
5658

0 commit comments

Comments
 (0)